get_device_details RPC fails if host not specified

Bug #1784950 reported by Matthew Edmonds on 2018-08-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-powervm
Critical
Matthew Edmonds
neutron
Undecided
Unassigned

Bug Description

An optional (defaults to None) host argument was added to the get_device_details RPC method a long time ago [1] but a recent change [2] to the master branch has made that no longer really optional, at least for the pvm_sea agent from openstack/networking-powervm, since not passing it will cause VIF plugging to timeout with an error in the neutron logs stating "Device %s has no active binding in host None".

This can easily be fixed in openstack/networking-powervm by passing the host argument, but I expect that neutron also needs to bump the version for neutron.plugins.ml2.rpc.RpcCallbacks to reflect that host is no longer optional by removing the "=None" default (since it doesn't work anymore).

[1] f7064f2b6c6ba1d0ab5f9872b2d5ad7969a64e7b
[2] 01bdb47199468805b714ce4c00c7492951267585

Matthew Edmonds (edmondsw) wrote :

networking-powervm change proposed with https://review.openstack.org/#/c/588096/

Changed in networking-powervm:
status: New → In Progress
assignee: nobody → Matthew Edmonds (edmondsw)
importance: Undecided → Critical

Reviewed: https://review.openstack.org/588096
Committed: https://git.openstack.org/cgit/openstack/networking-powervm/commit/?id=59fbf0a3b6f14d54a0369408a8bc6bb2ad9df874
Submitter: Zuul
Branch: master

commit 59fbf0a3b6f14d54a0369408a8bc6bb2ad9df874
Author: Matthew Edmonds <email address hidden>
Date: Wed Aug 1 18:14:44 2018 -0400

    Pass host on get_device_details RPC

    Neutron added an optional host argument to the get_device_details RPC
    method a long time ago [1] but a recent change [2] has made that no
    longer really optional, at least for our usage. This adds host to our
    calls so that VIF plug will not timeout with an error in the neutron
    logs stating "Device %s has no active binding in host None".

    [1] f7064f2b6c6ba1d0ab5f9872b2d5ad7969a64e7b
    [2] 01bdb47199468805b714ce4c00c7492951267585

    Closes-Bug: #1784950
    Change-Id: Ida4102427405e17e42ddc463df4a63c2ba7dcb82

Changed in networking-powervm:
status: In Progress → Fix Released
Miguel Lavalle (minsel) wrote :

Please look at https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_port_binding.py#L102. This test case runs fine using 'host' default value. Yours is a corner case in which not passing host + the fact that the port is owned by compute produces and undesired result. Marking the bug as invalid. Please feel free to change the status in case we should discuss this bug any further

Changed in neutron:
status: New → Invalid

This issue was fixed in the openstack/networking-powervm 7.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers