Physical network not included in the vif details by SR-IOV mechanism driver

Bug #1651129 reported by Sridhar Venkat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-powervm
Fix Released
Undecided
Sridhar Venkat

Bug Description

SR-IOV mechanism driver in networking_powervm/plugins/ml2/drivers/mech_pvm_sriov.PvmSRIOVMechanismDriver does not include 'physical network' in the custom vif details. Method customize_vif_details prepares a dictionary like this :
{'redundancy': 1, 'physical_ports': [u'U78C9.001.WZS05TG-P1-C5-T1'], 'vlan': '2200', 'port_filter': False, 'capacity': 0.02}
It does not include physical_network.
This is not a bug, but SR-IOV vif plug mechanism in nova_powervm/virt/powervm/vif.PvmVnicSriovVifDriver.plug can use physical_network value to calculate physical ports in migration scenario (future work in nova_powervm).

Above mentioned plug mechanism currently uses get_physical_network method in nova/network/model.VIF class. This method expects physical_network in custom vif details prepared by mechanism driver.

Sridhar Venkat (svenkat)
Changed in networking-powervm:
assignee: nobody → Sridhar Venkat (svenkat)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-powervm (master)

Fix proposed to branch: master
Review: https://review.openstack.org/412458

Changed in networking-powervm:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-powervm (master)

Reviewed: https://review.openstack.org/412458
Committed: https://git.openstack.org/cgit/openstack/networking-powervm/commit/?id=e64928fd16d2f79b46f8e1f9a1649ef41471278a
Submitter: Jenkins
Branch: master

commit e64928fd16d2f79b46f8e1f9a1649ef41471278a
Author: Sridhar Venkat <email address hidden>
Date: Mon Dec 19 08:37:21 2016 -0500

    Physical network not included in vif details

    SR-IOV mechanism driver in networking_powervm/plugins/ml2/drivers/
    mech_pvm_sriov.PvmSRIOVMechanismDriver does not include
    'physical network' in the custom vif details. Method
    customize_vif_details prepares a dictionary like this :
    {'redundancy': 1, 'physical_ports': [u'U78C9.001.WZS05TG-P1-C5-T1'],
    'vlan': '2200', 'port_filter': False, 'capacity': 0.02}
    It does not include physical_network.
    This is not a bug, but SR-IOV vif plug mechanism in
    nova_powervm/virt/powervm/vif.PvmVnicSriovVifDriver.plug can use
    physical_network value to calculate physical ports in migration
    scenario (future work in nova_powervm).

    Above mentioned plug mechanism currently uses get_physical_network method
    in nova/network/model.VIF class. This method expects physical_network in
    custom vif details prepared by mechanism driver.

    This patchset fixes this by adding physical_network to vif details by
    getting it from network segment.

    Unit tests added.

    Change-Id: I379c9deceb72e4d5ea17891120d065230578d59e
    Closes-Bug: #1651129

Changed in networking-powervm:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-powervm (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/420025

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-powervm (stable/newton)

Reviewed: https://review.openstack.org/420025
Committed: https://git.openstack.org/cgit/openstack/networking-powervm/commit/?id=a35f57cc54f0d55c7879648f1512f6656bfc4b12
Submitter: Jenkins
Branch: stable/newton

commit a35f57cc54f0d55c7879648f1512f6656bfc4b12
Author: Sridhar Venkat <email address hidden>
Date: Mon Dec 19 08:37:21 2016 -0500

    Physical network not included in vif details

    SR-IOV mechanism driver in networking_powervm/plugins/ml2/drivers/
    mech_pvm_sriov.PvmSRIOVMechanismDriver does not include
    'physical network' in the custom vif details. Method
    customize_vif_details prepares a dictionary like this :
    {'redundancy': 1, 'physical_ports': [u'U78C9.001.WZS05TG-P1-C5-T1'],
    'vlan': '2200', 'port_filter': False, 'capacity': 0.02}
    It does not include physical_network.
    This is not a bug, but SR-IOV vif plug mechanism in
    nova_powervm/virt/powervm/vif.PvmVnicSriovVifDriver.plug can use
    physical_network value to calculate physical ports in migration
    scenario (future work in nova_powervm).

    Above mentioned plug mechanism currently uses get_physical_network method
    in nova/network/model.VIF class. This method expects physical_network in
    custom vif details prepared by mechanism driver.

    This patchset fixes this by adding physical_network to vif details by
    getting it from network segment.

    Unit tests added.

    Change-Id: I379c9deceb72e4d5ea17891120d065230578d59e
    Closes-Bug: #1651129
    (cherry picked from commit e64928fd16d2f79b46f8e1f9a1649ef41471278a)

tags: added: in-stable-newton
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.