Out of tree drivers fail to run hacking checks now

[Drew Thorstensen]

This change recently went in to the neutron hacking checks:

https://github.com/openstack/neutron/commit/31e1aeb66b2d8abb0d8424e9550693fad6f37c1c

While this serves the purpose of not allowing functional tests from within neturon to extend unit test functions, it blocks out of tree neutron drivers/ml2 agents from importing the neutron unit tests within their own unit tests.

Out of tree drivers/ml2 agents are no longer able to run the hacking checks that they extend from neutron against their own source tree - or they have to explicitly exclude the check_no_imports_from_tests rule.

Neutron Code: https://github.com/openstack/neutron/blame/master/neutron/hacking/checks.py#L390-L403

Example of broken check (PowerVM): https://github.com/openstack/networking-powervm/blob/master/networking_powervm/hacking/checks.py#L45

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/374425

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Fried (<email address hidden>) on branch: master
Review: https://review.openstack.org/374424
Reason: In favor of https://review.openstack.org/#/c/374439/

[Eric Fried (efried)]

https://review.openstack.org/#/c/374439/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/374441

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374439
Committed: https://git.openstack.org/cgit/openstack/networking-powervm/commit/?id=2bb923e9c04d9acb38c82778f48e9de3075ba714
Submitter: Jenkins
Branch: master

commit 2bb923e9c04d9acb38c82778f48e9de3075ba714
Author: Eric Fried <email address hidden>
Date: Wed Sep 21 18:18:20 2016 -0500

    Switch hacking.checks from neutron to neutron_lib

    Per armax recommendation in https://review.openstack.org/#/c/374425/,
    moving away from the neutron hacking checks, using neutron_lib hacking
    checks instead.

    We need to bypass N530 (direct neutron imports not allowed) for the
    forseeable future.

    Change-Id: I05804844445575a55ab33273b88fd3a5ff9df179
    Closes-Bug: #1626298

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374441
Committed: https://git.openstack.org/cgit/openstack/networking-powervm/commit/?id=00cbb6188896bd290fa7631defa9d5f204ad0724
Submitter: Jenkins
Branch: stable/newton

commit 00cbb6188896bd290fa7631defa9d5f204ad0724
Author: Eric Fried <email address hidden>
Date: Wed Sep 21 18:18:20 2016 -0500

    Switch hacking.checks from neutron to neutron_lib

    Per armax recommendation in https://review.openstack.org/#/c/374425/,
    moving away from the neutron hacking checks, using neutron_lib hacking
    checks instead.

    We need to bypass N530 (direct neutron imports not allowed) for the
    forseeable future.

    Change-Id: I05804844445575a55ab33273b88fd3a5ff9df179
    Closes-Bug: #1626298

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/390634

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390634
Committed: https://git.openstack.org/cgit/openstack/networking-powervm/commit/?id=cf05b996fdd46937ad51d3b0aab9b30eca1f1895
Submitter: Jenkins
Branch: stable/mitaka

commit cf05b996fdd46937ad51d3b0aab9b30eca1f1895
Author: Eric Fried <email address hidden>
Date: Wed Sep 21 18:18:20 2016 -0500

    Switch hacking.checks from neutron to neutron_lib

    Per armax recommendation in https://review.openstack.org/#/c/374425/,
    moving away from the neutron hacking checks, using neutron_lib hacking
    checks instead.

    We need to bypass N530 (direct neutron imports not allowed) for the
    forseeable future.

    Change-Id: I05804844445575a55ab33273b88fd3a5ff9df179
    Closes-Bug: #1626298
    (cherry picked from commit 00cbb6188896bd290fa7631defa9d5f204ad0724)