neutron

is_lsp_router_port() doesn't consider all router device owners

Bug #1941902 reported by Jakub Libosvar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Jakub Libosvar

Bug Description

On environments migrated from ml2/ovs the is_lsp_router_port() ovn function doesn't cover all router ports from ml2/ovs.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/806424

Changed in neutron:
status: New → In Progress
Hongbin Lu (hongbin.lu)
Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Jakub Libosvar (libosvar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/806866

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/806868

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/806869

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/806424
Committed: https://opendev.org/openstack/neutron/commit/903e66e8e73600fcc251fb5e8ad85d88171bf95b
Submitter: "Zuul (22348)"
Branch: master

commit 903e66e8e73600fcc251fb5e8ad85d88171bf95b
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 27 17:10:42 2021 +0200

    ovn: Consider all router ports in is_lsp_router_port()

    The function considered only device owners known to OVN. On migrated
    environments the device owner could be different. The codebase contains
    a constant tuple containing all router port device owners. This patch
    uses the constant instead.

    Change-Id: I026ac8ea9c35a425470a2eaede35b3bfeba259c3
    Closes-bug: #1941902
    Signed-off-by: Jakub Libosvar <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/806866
Committed: https://opendev.org/openstack/neutron/commit/dd7222805854496cde938f4b09aaaa3b0a1d5d1e
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit dd7222805854496cde938f4b09aaaa3b0a1d5d1e
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 27 17:10:42 2021 +0200

    ovn: Consider all router ports in is_lsp_router_port()

    The function considered only device owners known to OVN. On migrated
    environments the device owner could be different. The codebase contains
    a constant tuple containing all router port device owners. This patch
    uses the constant instead.

    Change-Id: I026ac8ea9c35a425470a2eaede35b3bfeba259c3
    Closes-bug: #1941902
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 903e66e8e73600fcc251fb5e8ad85d88171bf95b)

tags: added: in-stable-wallaby
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/806869
Committed: https://opendev.org/openstack/neutron/commit/c5cbbe51c6e1b5aa2f957d9165c61946cfee96c3
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit c5cbbe51c6e1b5aa2f957d9165c61946cfee96c3
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 27 17:10:42 2021 +0200

    ovn: Consider all router ports in is_lsp_router_port()

    The function considered only device owners known to OVN. On migrated
    environments the device owner could be different. The codebase contains
    a constant tuple containing all router port device owners. This patch
    uses the constant instead.

    Change-Id: I026ac8ea9c35a425470a2eaede35b3bfeba259c3
    Closes-bug: #1941902
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 903e66e8e73600fcc251fb5e8ad85d88171bf95b)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/806868
Committed: https://opendev.org/openstack/neutron/commit/835307a482ffd09ffd11d56e9285f5ba76fafa95
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 835307a482ffd09ffd11d56e9285f5ba76fafa95
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 27 17:10:42 2021 +0200

    ovn: Consider all router ports in is_lsp_router_port()

    The function considered only device owners known to OVN. On migrated
    environments the device owner could be different. The codebase contains
    a constant tuple containing all router port device owners. This patch
    uses the constant instead.

    Change-Id: I026ac8ea9c35a425470a2eaede35b3bfeba259c3
    Closes-bug: #1941902
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 903e66e8e73600fcc251fb5e8ad85d88171bf95b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.4.1

This issue was fixed in the openstack/neutron 16.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.2.1

This issue was fixed in the openstack/neutron 17.2.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.1.1

This issue was fixed in the openstack/neutron 18.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.0.0.0rc1

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn train-eol

This issue was fixed in the openstack/networking-ovn train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.