Typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary

Bug #1938569 reported by Eduardo Olivares
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Eduardo Olivares

Bug Description

SUPPORTED_DHCP_OPTS_MAPPING is a dictionary that maps neutron dhcp-option names to ovn dhcp-option names. OVN dhcp-option ia_addr corresponds with neutron dhcp-option names 'ia-addr' or '5'. However, there is a type here and the corresponding OVN value is defined as ip_addr instead of ia_addr [1]

Definition of ia_addr from OVN code: [2]

The following openstack command created a wrong entry in the OVN NBDB DHCP_OPTIONS
$ openstack port create --network tempest-DHCPTest-980691237 --extra-dhcp-option name=ia-addr,value=2001::2001,ip-version=6 port-test-202

# ovn-nbctl list dhcp_options c9b0f6c0-c1bf-4e91-9e66-5e75491ae9e5
_uuid : c9b0f6c0-c1bf-4e91-9e66-5e75491ae9e5
cidr : "2001:db8::/64"
external_ids : {"neutron:revision_number"="0", port_id="1188bca5-4b75-4810-a9a0-38ecc96d0274", subnet_id="567272f0-f1b8-423c-a939-9dea6b5e26ab"}
options : {dhcpv6_stateless="true", ip_addr="2001::2001", server_id="fa:16:3e:ce:f4:67"}

[1] https://opendev.org/openstack/neutron/src/commit/19372a3cd8b4e6e45f707753b914e133857dd629/neutron/common/ovn/constants.py#L163
[2] https://github.com/ovn-org/ovn/blob/1c9e46ab5c05043a8cd6c47b5fec2e1ac4c962db/lib/ovn-l7.h#L261

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/803037

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Eduardo Olivares (eolivare)
tags: added: ovn
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/803037
Committed: https://opendev.org/openstack/neutron/commit/d4b1b4a0729c187551e1fa2b2855db136456d496
Submitter: "Zuul (22348)"
Branch: master

commit d4b1b4a0729c187551e1fa2b2855db136456d496
Author: Eduardo Olivares <email address hidden>
Date: Fri Jul 30 15:49:06 2021 +0200

    Fix typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary (ia-addr)

    Closes-Bug: #1938569

    Change-Id: I10e0834594f68e06244c393c00d0b3d840c45fc5

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/803679

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/803680

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/803681

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/803679
Committed: https://opendev.org/openstack/neutron/commit/7ab4b5f246d239e74ba3f1f8bc6577ed8ee5174a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7ab4b5f246d239e74ba3f1f8bc6577ed8ee5174a
Author: Eduardo Olivares <email address hidden>
Date: Fri Jul 30 15:49:06 2021 +0200

    Fix typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary (ia-addr)

    Closes-Bug: #1938569

    Change-Id: I10e0834594f68e06244c393c00d0b3d840c45fc5
    (cherry picked from commit d4b1b4a0729c187551e1fa2b2855db136456d496)

tags: added: in-stable-wallaby
tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/803680
Committed: https://opendev.org/openstack/neutron/commit/7e28f395220ac7f8f060b7771b1c7f0299f16969
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 7e28f395220ac7f8f060b7771b1c7f0299f16969
Author: Eduardo Olivares <email address hidden>
Date: Fri Jul 30 15:49:06 2021 +0200

    Fix typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary (ia-addr)

    Closes-Bug: #1938569

    Change-Id: I10e0834594f68e06244c393c00d0b3d840c45fc5
    (cherry picked from commit d4b1b4a0729c187551e1fa2b2855db136456d496)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/803681
Committed: https://opendev.org/openstack/neutron/commit/09e80d4a702b551a8c8b4126b43ab8925f0d7d0e
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 09e80d4a702b551a8c8b4126b43ab8925f0d7d0e
Author: Eduardo Olivares <email address hidden>
Date: Fri Jul 30 15:49:06 2021 +0200

    Fix typo in OVN SUPPORTED_DHCP_OPTS_MAPPING dictionary (ia-addr)

    Closes-Bug: #1938569

    Change-Id: I10e0834594f68e06244c393c00d0b3d840c45fc5
    (cherry picked from commit d4b1b4a0729c187551e1fa2b2855db136456d496)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.4.1

This issue was fixed in the openstack/neutron 16.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.2.1

This issue was fixed in the openstack/neutron 17.2.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.1.1

This issue was fixed in the openstack/neutron 18.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.0.0.0rc1

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn train-eol

This issue was fixed in the openstack/networking-ovn train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.