ovn-neutron-db-sync deletes legitimate metadata ports

[Jakub Libosvar]

Running the db sync script on environment with existing metadata ports sometimes removes the legitimate metadata ports from Neutron.

[Jakub Libosvar (libosvar)]

Fixed at https://review.opendev.org/c/openstack/neutron/+/789085

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/796872

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/797013

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/797000

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/796872
Committed: https://opendev.org/openstack/neutron/commit/26f366119f09b637a56214a3a024ba1b7e65a2f9
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 26f366119f09b637a56214a3a024ba1b7e65a2f9
Author: Jakub Libosvar <email address hidden>
Date: Sun May 2 13:40:38 2021 +0200

    ovn: Don't use dict.remove() for filtering dhcp ports in db-sync

    The db-sync script removes ovnmeta ports because sometimes removing
    reserved_dhcp_port in the loop doesn't work.

    Closes-Bug: #1932421

    Change-Id: I78673b6a85f1c872e70026da82124d1ba2326562
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 0aab51c9f8be1d42e5b578493cefd384ee07665b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/797013
Committed: https://opendev.org/openstack/neutron/commit/5666d76ad76402ef88b277b49ba130cc0db7e555
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 5666d76ad76402ef88b277b49ba130cc0db7e555
Author: Jakub Libosvar <email address hidden>
Date: Sun May 2 13:40:38 2021 +0200

    ovn: Don't use dict.remove() for filtering dhcp ports in db-sync

    The db-sync script removes ovnmeta ports because sometimes removing
    reserved_dhcp_port in the loop doesn't work.

    Closes-Bug: #1932421

    Change-Id: I78673b6a85f1c872e70026da82124d1ba2326562
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 0aab51c9f8be1d42e5b578493cefd384ee07665b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/797000
Committed: https://opendev.org/openstack/neutron/commit/0d0acf062adb21663fc533200324cf30109f5f94
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 0d0acf062adb21663fc533200324cf30109f5f94
Author: Jakub Libosvar <email address hidden>
Date: Sun May 2 13:40:38 2021 +0200

    ovn: Don't use dict.remove() for filtering dhcp ports in db-sync

    The db-sync script removes ovnmeta ports because sometimes removing
    reserved_dhcp_port in the loop doesn't work.

    Closes-Bug: #1932421

    Conflicts:
            neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py

    Change-Id: I78673b6a85f1c872e70026da82124d1ba2326562
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 0aab51c9f8be1d42e5b578493cefd384ee07665b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 17.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn train-eol release.