networking-ovn

Skip all Neutron DHCP Agent ports in networking-ovn

Bug #1848521 reported by Daniel Alvarez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-ovn
Fix Released
Undecided
Daniel Alvarez

Bug Description

When creating OVN localports (for Metadata), we need to skip those ports created by Neutron DHCP Agent (if any):

    It looks like sometimes, the device_id for ports created
    by Neutron DHCP Agent can be in the form of:

    - dhcp-$hostuuid-$networkid
    - 'reserved_dhcp_port' (DEVICE_ID_RESERVED_DHCP_PORT)

    Current code is only taking the first form into account when
    skipping Neutron DHCP Agent ports.

We need to take both into account or we may have broken metadata service in setups where Neutron DHCP Agent is used for other purposes (baremetal provisioning for example).

Daniel Alvarez (dalvarezs)
Changed in networking-ovn:
assignee: nobody → Daniel Alvarez (dalvarezs)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (master)

Fix proposed to branch: master
Review: https://review.opendev.org/689174

Changed in networking-ovn:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (master)

Reviewed: https://review.opendev.org/689174
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=15bf8f265b14c3a1e2c89a17a77cee69cad22b9d
Submitter: Zuul
Branch: master

commit 15bf8f265b14c3a1e2c89a17a77cee69cad22b9d
Author: Daniel Alvarez <email address hidden>
Date: Thu Oct 17 16:18:17 2019 +0200

    Exclude all device_ids that belong to Neutron DHCP Agent

    It looks like sometimes, the device_id for ports created
    by Neutron DHCP Agent can be in the form of:

    - dhcp-$hostuuid-$networkid
    - 'reserved_dhcp_port' (DEVICE_ID_RESERVED_DHCP_PORT)

    Current code is only taking the first form into account when
    skipping Neutron DHCP Agent ports. This patch is changing it
    to include both forms.

    Closes-Bug: #1848521
    Co-Authored-By: Lucas Alvares Gomes <email address hidden>
    Change-Id: Ifbfc551ac68dcc5d3d39a155f7642f2f2d9272c4
    Signed-off-by: Daniel Alvarez <email address hidden>

Changed in networking-ovn:
status: In Progress → Fix Released
Bernard Cafarelli (bcafarel)
tags: added: networking-ovn-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/703191

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/703192

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/703193

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/703195

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (stable/stein)

Reviewed: https://review.opendev.org/703192
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=509e2833eee9583bd6994bacc8de1c7bd06e51bf
Submitter: Zuul
Branch: stable/stein

commit 509e2833eee9583bd6994bacc8de1c7bd06e51bf
Author: Daniel Alvarez <email address hidden>
Date: Thu Oct 17 16:18:17 2019 +0200

    Exclude all device_ids that belong to Neutron DHCP Agent

    It looks like sometimes, the device_id for ports created
    by Neutron DHCP Agent can be in the form of:

    - dhcp-$hostuuid-$networkid
    - 'reserved_dhcp_port' (DEVICE_ID_RESERVED_DHCP_PORT)

    Current code is only taking the first form into account when
    skipping Neutron DHCP Agent ports. This patch is changing it
    to include both forms.

    Closes-Bug: #1848521
    Co-Authored-By: Lucas Alvares Gomes <email address hidden>
    Change-Id: Ifbfc551ac68dcc5d3d39a155f7642f2f2d9272c4
    Signed-off-by: Daniel Alvarez <email address hidden>
    (cherry picked from commit 15bf8f265b14c3a1e2c89a17a77cee69cad22b9d)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (stable/queens)

Reviewed: https://review.opendev.org/703195
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=d2127eb634b59c8f21bef7a70f7620fc4e5a77b6
Submitter: Zuul
Branch: stable/queens

commit d2127eb634b59c8f21bef7a70f7620fc4e5a77b6
Author: Daniel Alvarez <email address hidden>
Date: Thu Oct 17 16:18:17 2019 +0200

    Exclude all device_ids that belong to Neutron DHCP Agent

    It looks like sometimes, the device_id for ports created
    by Neutron DHCP Agent can be in the form of:

    - dhcp-$hostuuid-$networkid
    - 'reserved_dhcp_port' (DEVICE_ID_RESERVED_DHCP_PORT)

    Current code is only taking the first form into account when
    skipping Neutron DHCP Agent ports. This patch is changing it
    to include both forms.

    Closes-Bug: #1848521
    Co-Authored-By: Lucas Alvares Gomes <email address hidden>
    Change-Id: Ifbfc551ac68dcc5d3d39a155f7642f2f2d9272c4
    Signed-off-by: Daniel Alvarez <email address hidden>
    (cherry picked from commit 15bf8f265b14c3a1e2c89a17a77cee69cad22b9d)

tags: added: in-stable-queens
tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (stable/train)

Reviewed: https://review.opendev.org/703191
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=53ad1170bff39d5ee7ec8abbf2ce58c94272fd3a
Submitter: Zuul
Branch: stable/train

commit 53ad1170bff39d5ee7ec8abbf2ce58c94272fd3a
Author: Daniel Alvarez <email address hidden>
Date: Thu Oct 17 16:18:17 2019 +0200

    Exclude all device_ids that belong to Neutron DHCP Agent

    It looks like sometimes, the device_id for ports created
    by Neutron DHCP Agent can be in the form of:

    - dhcp-$hostuuid-$networkid
    - 'reserved_dhcp_port' (DEVICE_ID_RESERVED_DHCP_PORT)

    Current code is only taking the first form into account when
    skipping Neutron DHCP Agent ports. This patch is changing it
    to include both forms.

    Closes-Bug: #1848521
    Co-Authored-By: Lucas Alvares Gomes <email address hidden>
    Change-Id: Ifbfc551ac68dcc5d3d39a155f7642f2f2d9272c4
    Signed-off-by: Daniel Alvarez <email address hidden>
    (cherry picked from commit 15bf8f265b14c3a1e2c89a17a77cee69cad22b9d)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (stable/rocky)

Reviewed: https://review.opendev.org/703193
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=23bcfd127db034eb18d8e674655f06b03bdb9d6a
Submitter: Zuul
Branch: stable/rocky

commit 23bcfd127db034eb18d8e674655f06b03bdb9d6a
Author: Daniel Alvarez <email address hidden>
Date: Thu Oct 17 16:18:17 2019 +0200

    Exclude all device_ids that belong to Neutron DHCP Agent

    It looks like sometimes, the device_id for ports created
    by Neutron DHCP Agent can be in the form of:

    - dhcp-$hostuuid-$networkid
    - 'reserved_dhcp_port' (DEVICE_ID_RESERVED_DHCP_PORT)

    Current code is only taking the first form into account when
    skipping Neutron DHCP Agent ports. This patch is changing it
    to include both forms.

    Closes-Bug: #1848521
    Co-Authored-By: Lucas Alvares Gomes <email address hidden>
    Change-Id: Ifbfc551ac68dcc5d3d39a155f7642f2f2d9272c4
    Signed-off-by: Daniel Alvarez <email address hidden>
    (cherry picked from commit 15bf8f265b14c3a1e2c89a17a77cee69cad22b9d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 7.1.0

This issue was fixed in the openstack/networking-ovn 7.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 6.0.1

This issue was fixed in the openstack/networking-ovn 6.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 5.1.0

This issue was fixed in the openstack/networking-ovn 5.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn queens-eol

This issue was fixed in the openstack/networking-ovn queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.