Remove "unknown" from router ports and localports addresses column

[Lucas Alvares Gomes]

networking-ovn is setting the "unknown" address on the logical switch ports solely based on whether the port security was enabled or disabled. That's not how it's intended to work.

That address should only be set for the normal LSPs (no router, localport or localnet types).

This bug is based on numans feedback (a core OVN developer):

<numans> i remember that a patch in networking-ovn added "unknown" addr if the port has no port security
<numans> but I think it should not add unknown for router ports, localnet ports..
<numans> ovn might unnecessary deliver the packets if the destination mac is not known to all these ports.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/673845

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673845
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c
Submitter: Zuul
Branch: master

commit 6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Jul 31 13:41:34 2019 +0100

    Only set "unknown" in LSP that makes sense

    Prior to this patch, the "unknown" address was being set the logical
    switch ports solely based on whether the port security was enabled or
    disabled. That's not how it's intended to work.

    With this patch the "unknown" address is only set to the normal logical
    switch ports, those which types are "router", "localnet" or "localport"
    won't be affected.

    The maintenance task was updated to correct this behavior for existing
    ports (the maintenance was suppose to be removed in the T cycle, this
    patch bumps it to U cycle instead due to this change).

    Closes-Bug: #1838535
    Related-Bug: #1815270
    Change-Id: I3c01bd7d1685c8a7e13a55e545e98baf19e9a0f9
    Signed-off-by: Lucas Alvares Gomes <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 7.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/699642

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/699643

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/699655

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/699661

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699642
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=b5ca90feacd467a8991fb42bae7d2b4c0095fa5d
Submitter: Zuul
Branch: stable/train

commit b5ca90feacd467a8991fb42bae7d2b4c0095fa5d
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Jul 31 13:41:34 2019 +0100

    Only set "unknown" in LSP that makes sense

    Prior to this patch, the "unknown" address was being set the logical
    switch ports solely based on whether the port security was enabled or
    disabled. That's not how it's intended to work.

    With this patch the "unknown" address is only set to the normal logical
    switch ports, those which types are "router", "localnet" or "localport"
    won't be affected.

    The maintenance task was updated to correct this behavior for existing
    ports (the maintenance was suppose to be removed in the T cycle, this
    patch bumps it to U cycle instead due to this change).

    Closes-Bug: #1838535
    Related-Bug: #1815270
    Change-Id: I3c01bd7d1685c8a7e13a55e545e98baf19e9a0f9
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699643
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=86eee7957b081c75d4d4d0cd810e77f10937bda1
Submitter: Zuul
Branch: stable/stein

commit 86eee7957b081c75d4d4d0cd810e77f10937bda1
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Jul 31 13:41:34 2019 +0100

    Only set "unknown" in LSP that makes sense

    Prior to this patch, the "unknown" address was being set the logical
    switch ports solely based on whether the port security was enabled or
    disabled. That's not how it's intended to work.

    With this patch the "unknown" address is only set to the normal logical
    switch ports, those which types are "router", "localnet" or "localport"
    won't be affected.

    The maintenance task was updated to correct this behavior for existing
    ports (the maintenance was suppose to be removed in the T cycle, this
    patch bumps it to U cycle instead due to this change).

    Closes-Bug: #1838535
    Related-Bug: #1815270
    Change-Id: I3c01bd7d1685c8a7e13a55e545e98baf19e9a0f9
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699655
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=13f7bedf3b7087f2ae74554f92f52406c74d0f01
Submitter: Zuul
Branch: stable/rocky

commit 13f7bedf3b7087f2ae74554f92f52406c74d0f01
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Jul 31 13:41:34 2019 +0100

    Only set "unknown" in LSP that makes sense

    Prior to this patch, the "unknown" address was being set the logical
    switch ports solely based on whether the port security was enabled or
    disabled. That's not how it's intended to work.

    With this patch the "unknown" address is only set to the normal logical
    switch ports, those which types are "router", "localnet" or "localport"
    won't be affected.

    The maintenance task was updated to correct this behavior for existing
    ports (the maintenance was suppose to be removed in the T cycle, this
    patch bumps it to U cycle instead due to this change).

    Closes-Bug: #1838535
    Related-Bug: #1815270
    Change-Id: I3c01bd7d1685c8a7e13a55e545e98baf19e9a0f9
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699661
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=63ff1f433ab9fbd56fe82e6ef48da714a3aeef0c
Submitter: Zuul
Branch: stable/queens

commit 63ff1f433ab9fbd56fe82e6ef48da714a3aeef0c
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Jul 31 13:41:34 2019 +0100

    Only set "unknown" in LSP that makes sense

    Prior to this patch, the "unknown" address was being set the logical
    switch ports solely based on whether the port security was enabled or
    disabled. That's not how it's intended to work.

    With this patch the "unknown" address is only set to the normal logical
    switch ports, those which types are "router", "localnet" or "localport"
    won't be affected.

    The maintenance task was updated to correct this behavior for existing
    ports (the maintenance was suppose to be removed in the T cycle, this
    patch bumps it to U cycle instead due to this change).

    Closes-Bug: #1838535
    Related-Bug: #1815270

    Conflicts:
       networking_ovn/common/ovn_client.py
       networking_ovn/common/constants.py

    Change-Id: I3c01bd7d1685c8a7e13a55e545e98baf19e9a0f9
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 7.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 6.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 5.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn queens-eol release.