[OVN]Missing ingress QoS in OVN

Bug #1813551 reported by sapd
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Taoyunxiang

Bug Description

Currently, OpenvSwitch is supported QoS for both directions include ingress and egress. OVN is using internal OvS so OVN can support too.

But When I saw source code in [1], OVN support egress only. So we need take some works for that.

[1] - https://github.com/openstack/networking-ovn/blob/master/networking_ovn/ml2/qos_driver.py#L38

Tags: ovn
Changed in networking-ovn:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Lucas Alvares Gomes (lucasagomes) wrote :

The OVN driver now lives in the neutron repository. Moving this bug to their tracker.

tags: added: ovn
summary: - Missing ingress QoS in OVN
+ [OVN]Missing ingress QoS in OVN
no longer affects: networking-ovn
Revision history for this message
Lajos Katona (lajos-katona) wrote :

Isn't this patch: https://review.opendev.org/703537 is related to this bug?

Changed in neutron:
assignee: nobody → Taoyunxiang (taoyunxiang)
Revision history for this message
Taoyunxiang (taoyunxiang) wrote :

In the master branch of networking-ovn, it has support both directions and DSCP of QoS. The related patch is [0]

And the code "VALID_DIRECTIONS" [1] mentioned before,means both directions, it has defined in [2].
So we should import the [0] to neutron. I will take it.

[0]https://review.opendev.org/#/c/692084/
[1]https://github.com/openstack/networking-ovn/blob/master/networking_ovn/ml2/qos_driver.py#L38

[2]https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L345

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/703537
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dcec852b7f091c67a378db96c4841c3eec0d496a
Submitter: Zuul
Branch: master

commit dcec852b7f091c67a378db96c4841c3eec0d496a
Author: Yunxiang Tao <email address hidden>
Date: Mon Feb 3 16:40:19 2020 +0800

    [OVN] Update QoS related code from networking-ovn

    In terms of [1], patch [0] has import the lasted code of ovn_client.py, but not
    "/networking_ovn/ml2/qos_driver.py", so this patch will update it.

    [0] https://review.opendev.org/#/c/697316/
    [1] https://review.opendev.org/#/c/692084/

    Change-Id: Iefff6cdf070d234c4ea9c8e1d5fdfe4542eb7fa3
    Closes-Bug: #1813551

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.0.0.0b1

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.