functional tests failing due to duplicate Encap entries

Bug #1810292 reported by Daniel Alvarez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-ovn
Undecided
Daniel Alvarez

Bug Description

When we create fake chassis from functional tests, a new Encap row is created for ip '172.24.4.10' and type 'geneve'. After this patch [0] merged in OVS, that's considered a constraint violation so our functional tests fail.

It doesn't make sense to have two chassis with the same IP address and encap type but for the purpose of functional tests we can just 'fake' it by using different IP addresses. This shouldn't have any side effect as ovn-controller is not running on functional tests and will allow us to still test multiple chassis scenarios.

Changed in networking-ovn:
assignee: nobody → Daniel Alvarez (dalvarezs)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/627961

Changed in networking-ovn:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (master)

Reviewed: https://review.openstack.org/627961
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=0cdd7ad8fe38c263b480b849d625a1ac94bea26a
Submitter: Zuul
Branch: master

commit 0cdd7ad8fe38c263b480b849d625a1ac94bea26a
Author: Daniel Alvarez <email address hidden>
Date: Wed Jan 2 11:46:20 2019 +0000

    functional: Use different IP addresses for every fake chassis

    As of OVS 2.11, the SB schema changed to not allow having two
    Encap rows with the same (ip, type) pairs. Some of our
    functional tests need more than one chassis and they all get
    created with the same (ip, type) values so they'll fail.

    This patch changes it so that a new IP address is used every
    time we create a fake chassis. It shouldn't have any impact
    as ovn-controller is not running so tunnels won't be created
    anyways.

    Change-Id: I900e847851d10f7faf474b70eaecb47b2b016a24
    Closes-Bug: #1810292
    Signed-off-by: Daniel Alvarez <email address hidden>

Changed in networking-ovn:
status: In Progress → Fix Released
tags: added: networking-ovn-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/632437

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (stable/rocky)

Reviewed: https://review.openstack.org/632437
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=aae9344330ca81cc9a9405a300dd7d0c5d74d085
Submitter: Zuul
Branch: stable/rocky

commit aae9344330ca81cc9a9405a300dd7d0c5d74d085
Author: Daniel Alvarez <email address hidden>
Date: Wed Jan 2 11:46:20 2019 +0000

    functional: Use different IP addresses for every fake chassis

    As of OVS 2.11, the SB schema changed to not allow having two
    Encap rows with the same (ip, type) pairs. Some of our
    functional tests need more than one chassis and they all get
    created with the same (ip, type) values so they'll fail.

    This patch changes it so that a new IP address is used every
    time we create a fake chassis. It shouldn't have any impact
    as ovn-controller is not running so tunnels won't be created
    anyways.

    Change-Id: I900e847851d10f7faf474b70eaecb47b2b016a24
    Closes-Bug: #1810292
    Signed-off-by: Daniel Alvarez <email address hidden>
    (cherry picked from commit 0cdd7ad8fe38c263b480b849d625a1ac94bea26a)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 6.0.0.0b1

This issue was fixed in the openstack/networking-ovn 6.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/681561

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-ovn (stable/queens)

Change abandoned by Maciej Józefczyk (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/681561

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (stable/queens)

Reviewed: https://review.opendev.org/681394
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=513647805f5ddf3917085705618f147afde4d15e
Submitter: Zuul
Branch: stable/queens

commit 513647805f5ddf3917085705618f147afde4d15e
Author: Daniel Alvarez <email address hidden>
Date: Mon Sep 9 14:45:00 2019 +0200

    Make use of OVS 2.11 in stable/queens

    This patch squash two commits:

    1) Switch stable/queens jobs to OVS 2.11 branch and remove master jobs

    While the master branch should change to build from the
    new OVN repo, stable branches should build from a stable
    version of it.

    We don't want to test stable release against master OVS/OVN, so lets
    remove those jobs.

    Signed-off-by: Daniel Alvarez <email address hidden>
    (cherry picked from commit 6d540e49e6c483990d3ae87d35992a9d67e670be)

    2) functional: Use different IP addresses for every fake chassis

    As of OVS 2.11, the SB schema changed to not allow having two
    Encap rows with the same (ip, type) pairs. Some of our
    functional tests need more than one chassis and they all get
    created with the same (ip, type) values so they'll fail.

    This patch changes it so that a new IP address is used every
    time we create a fake chassis. It shouldn't have any impact
    as ovn-controller is not running so tunnels won't be created
    anyways.

    Closes-Bug: #1810292
    Signed-off-by: Daniel Alvarez <email address hidden>
    (cherry picked from commit 0cdd7ad8fe38c263b480b849d625a1ac94bea26a)

    Change-Id: I63d12861e1ff5d444d116188a2a122eca5c45af0

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 4.0.4

This issue was fixed in the openstack/networking-ovn 4.0.4 release.

tags: removed: networking-ovn-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 5.1.0

This issue was fixed in the openstack/networking-ovn 5.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers