Octavia OVN provider: LB not created properly

[Yossi Boaron]

OVN Octavia: Load balancer is not created properly at OVN

When Octavia Load balancer is created using below steps OVN doesn't create LB rules/flows as expected.

1. Create LB

openstack loadbalancer create --provider ovn --name test_ovn --vip-subnet-id 939dd34e-4848-497b-8f26-ece38e9519df

2. Create Listener

openstack loadbalancer listener create --name l1 --protocol TCP --protocol-port 80 test_ovn

3. Create pool attached to listener

openstack loadbalancer pool create --name p1 --listener l1 --protocol TCP --lb-algorithm ROUND_ROBIN

4. Create members

openstack loadbalancer member create --address 10.0.0.66 --protocol-port 8080 --subnet-id 939dd34e-4848-497b-8f26-ece38e9519df p1

 openstack loadbalancer member create --address 10.0.0.65 --protocol-port 8080 --subnet-id 939dd34e-4848-497b-8f26-ece38e9519df p1

===================================
ovn-nbctl command output:

[stack@dfgfgfg devstack]$ ovn-nbctl list load_balancer
_uuid : 7e7a63db-6ce4-4beb-a9f1-23bf3a4ffa39
external_ids : {enabled=True, "listener_55771eed-b4f5-4c38-af1d-32518620a295"="80:", lr_ref="neutron-b58c09bc-a37b-4800-bff4-3cb3c2b977cd", ls_refs="{\"neutron-c578c34f-fcbb-4299-a097-8c669332cf6d\": 3}", "neutron:vip"="10.0.0.157", "neutron:vip_port_id"="4e038465-8c27-4001-b9c6-5e856bf3f35c", "pool_4e223c06-9d43-447a-aa5b-6256d402ef44"="10.0.0.66:8080,10.0.0.65:8080"}
name : "e91d138f-73ef-4536-beb9-79150df785c2"
protocol : tcp
vips : {}
[stack@dfgfgfg devstack]$

Expected results:
==================
'vips' should be defined in 'ovn-nbctl list' command

Actual results:
=================
'vips' fields is empty

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/603320

[Reedip (reedip-banerjee-deactivatedaccount)]

Related issue in https://storyboard.openstack.org/#!/story/2003833

The above referenced issue also causes the following bug to occur

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603320
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=c16778754ed3fbb8b012c438d05a1e3248c712e2
Submitter: Zuul
Branch: master

commit c16778754ed3fbb8b012c438d05a1e3248c712e2
Author: Reedip <email address hidden>
Date: Tue Sep 18 06:13:47 2018 +0000

    Fix Pool creation workflow

    Currently it seems that when Listener is created before pool creation,
    the pool is not updated correctly in the NBDB leading to loss of VIPs
    as the workflow continues.

    Also updated the dict to deepcopy to ensure that ovn_lb's external_ids
    dict is not directly modified as it seems to be held by Python's memory
    context which prevented updation of Pool in the listener's key-value pair
    in OVN LB.

    Also removed a trivial line which was written by dude.

    Closes-Bug: #1792317
    Change-Id: Ibb4d6a47fdaede4ccd04125bb55ead3ae31112ab

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 6.0.0.0b1 development milestone.