devstack lib function is_ovn_service_enabled seems not work

[ZongKai LI]

When I try to setup a devstack environment with ovn-controller enabled but without ovn-controller-vtep enabled, I write the following into local.conf:

enable_service ovn-controller
disable_service ovn-controller-vtep

But after ./stack.sh completed, I found devstack@ovn-controller-vtep service is installed and get started. I checked https://github.com/openstack/networking-ovn/blob/master/devstack/lib/networking-ovn#L129-L134, I think its current behavior is to return 0 once ovn is enabled and no matter what kind of ovn sub-service it is:

    function is_ovn_service_enabled {
        ovn_service=$1
        is_service_enabled ovn && return 0
        is_service_enabled $ovn_service && return 0
        return 1
    }

it makes the second checking "is_service_enabled $ovn_service" have no chance to run. I think it's not what it is expected to do.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/533846

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/533846
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=2af637e1af350adddb45a6f3ade87813ab6e61df
Submitter: Zuul
Branch: master

commit 2af637e1af350adddb45a6f3ade87813ab6e61df
Author: zongkai <[e-mail]>
Date: Tue Jan 16 09:52:26 2018 +0800

    drop is_ovn_service_enabled in devstack

    In devstack/lib/networking-ovn, function is_ovn_service_enabled is used
    to check whether a service such as ovn-controller is enabled.

    It should have similar behavior than function is_service_enabled in
    devstack, since they have the same usage, like:

        if THE_ENABLED_CHECK_FUNCTION SOME_SERVICE ; then
            TRY_TO_CONFIG_IT
        fi

    But currently, is_ovn_service_enabled doesn't work as expected, since it
    will always return 0 if ovn is enabled and no matter what kind of sub-
    service it is.

    Think more, since "enable_service ovn" doesn't enable any service indeed,
    it makes sense to replace is_ovn_service_enabled with is_service_enabled.
    This patch is going to do that, and it will also fix logical error introduced
    by is_ovn_service_enabled.

    Closes-Bug: #1743487
    Change-Id: Ic1213d0c93aea3f73f8c092b3ffb69ff23382735

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 4.0.0.0b3 development milestone.