[ovn-sync] LSP is not created when metadata port is missing

[Daniel Alvarez]

When neutron-ovn-db-sync-util is invoked and there were missing metadata ports, they get created in Neutron but not in OVN. This is due to the fact that the cmd tool overrides the OVN mechanism driver and the port doesn't get created in the postcommit method.

Also, current code assumes that the corresponding LSP will be created when syncing ports but that's
not true since db_ports are fetched prior to creating them in sync_metadata_ports.

# Create the missing port in Neutron. Later it will be
# created in OVN when sync_network_ports_and_dhcp_opts
# is called.

The solution to this bug has to be compatible with current sync code being run when neutron-server starts (which matches the functional tests). There, it works correctly.

I'll submit a patch to fix it which will consist of overriding the create_port_postcommit and create the port in OVN when the corresponding Metadata port gets created in Neutron. This should be valid for both codepaths.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/513059
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=27447582562a10fa889befeb3042dca147292da5
Submitter: Zuul
Branch: master

commit 27447582562a10fa889befeb3042dca147292da5
Author: Daniel Alvarez <email address hidden>
Date: Wed Oct 18 16:49:10 2017 +0200

    Create Metadata port in OVN when found missing in Neutron

    When running the neutron-ovn-db-sync-util tool and a Metadata port
    is missing in Neutron, the corresponding LSP is not created in OVN.
    This is due to the fact that OVN mechanism driver is overriden in the
    cmd tool.

    This patch fixes it by overriding the create_port_postcommit so that
    it also gets created in OVN.

    Closes-bug: 1724591

    Change-Id: Iacb5f6eb3cecce883afae104764221d92f8ece04
    Signed-off-by: Daniel Alvarez <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 4.0.0.0b2 development milestone.