neutron.tests.tempest.api.test_routers.RoutersIpV6Test.test_router_interface_status failed

Bug #1715126 reported by Eran Kuris on 2017-09-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-ovn
High
Lucas Alvares Gomes

Bug Description

Tests below failed because ML2/OVN not setting router interface status to ACTIVE

neutron.tests.tempest.api.test_routers.RoutersIpV6Test.test_router_interface_status
neutron.tests.tempest.api.test_routers.RoutersTest.test_router_interface_status

Traceback (most recent call last):
  File "/home/centos/tempest-upstream/neutron/neutron/tests/tempest/api/test_routers.py", line 163, in test_router_interface_status
    utils.wait_until_true(status_active, exception=AssertionError)
  File "/home/centos/tempest-upstream/neutron/neutron/common/utils.py", line 687, in wait_until_true
    raise exception
AssertionError

version Pike ovn HA setup.

Eran Kuris (ekuris) wrote :
Numan Siddique (numansiddique) wrote :

The below patches should fix this issue. There are under review now

https://patchwork.ozlabs.org/patch/820000/
https://patchwork.ozlabs.org/patch/820001/

tags: added: ovn-upstream
Changed in networking-ovn:
importance: Undecided → High
Changed in networking-ovn:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)

Fix proposed to branch: master
Review: https://review.openstack.org/572782

Changed in networking-ovn:
status: New → In Progress

Reviewed: https://review.openstack.org/572782
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=9d0bc3e93879c901eaf989aaaf2ec224acb6dac5
Submitter: Zuul
Branch: master

commit 9d0bc3e93879c901eaf989aaaf2ec224acb6dac5
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Jun 6 14:49:21 2018 +0100

    Fix: Router port always marked as DOWN

    Router ports in OVN is never bound to a host given their decentralized
    nature. For that reason, the code in Neutron core that change the status
    of the ports (router ports are normal ports underneath) was ignoring the
    OVN router ports.

    This patch is forcing the status of those router ports to ACTIVE in
    networking-ovn. A comment was left in the code in case we want to change
    the core Neutron approach in the future.

    This patch is also enabling two tempest tests that checks for this
    router port status which were disabled before.

    Change-Id: I5fd18e6e395a783e9591c058b80b63d42b24a3df
    Closes-Bug: #1715126

Changed in networking-ovn:
status: In Progress → Fix Released
tags: added: networking-ovn-proactive-backport-potential

Reviewed: https://review.openstack.org/573401
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=d93ac0454ec7738f61e535acefedeea742efeee0
Submitter: Zuul
Branch: stable/queens

commit d93ac0454ec7738f61e535acefedeea742efeee0
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Jun 6 14:49:21 2018 +0100

    Fix: Router port always marked as DOWN

    Router ports in OVN is never bound to a host given their decentralized
    nature. For that reason, the code in Neutron core that change the status
    of the ports (router ports are normal ports underneath) was ignoring the
    OVN router ports.

    This patch is forcing the status of those router ports to ACTIVE in
    networking-ovn. A comment was left in the code in case we want to change
    the core Neutron approach in the future.

    This patch is also enabling two tempest tests that checks for this
    router port status which were disabled before.

    Change-Id: I5fd18e6e395a783e9591c058b80b63d42b24a3df
    Closes-Bug: #1715126
    (cherry picked from commit 9d0bc3e93879c901eaf989aaaf2ec224acb6dac5)

tags: added: in-stable-queens

This issue was fixed in the openstack/networking-ovn 5.0.0.0b3 development milestone.

I'm reopening the bug because the route ports on the gateway nodes (N/S traffic) are still being marked as DOWN.

Changed in networking-ovn:
status: Fix Released → New

Fix proposed to branch: master
Review: https://review.openstack.org/597539

Changed in networking-ovn:
status: New → In Progress

Reviewed: https://review.openstack.org/597539
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=3d575d19b850134044bba8b89cdb9953c17a5ca7
Submitter: Zuul
Branch: master

commit 3d575d19b850134044bba8b89cdb9953c17a5ca7
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Aug 29 14:15:32 2018 +0100

    Fix gateway's router port marked as DOWN

    This patch is fixing a problem which left the external/gateway's router
    port with status DOWN even after the port was bound to a chassis.

    Since the Logical_Router_Port table in OVNNB does not have a "up" column
    (like the Logical_Switch_Port table has) the status of those ports can
    not be updpated based on it. Therefore, this patch uses the "chassis"
    column for that. If the router port has the "chassis" column in OVNNB
    database set, the binding and status ACTIVE will be set in Neutron
    otherwise it status will be udpated to DOWN (if it's not DOWN yet).

    Closes-Bug: #1715126
    Change-Id: I91026204eae6df18be47df02f99db2f95c428e2b

Changed in networking-ovn:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/600383
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=6a423e51ee0940e14f362c806bb6239dbd0b6a88
Submitter: Zuul
Branch: stable/rocky

commit 6a423e51ee0940e14f362c806bb6239dbd0b6a88
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Aug 29 14:15:32 2018 +0100

    Fix gateway's router port marked as DOWN

    This patch is fixing a problem which left the external/gateway's router
    port with status DOWN even after the port was bound to a chassis.

    Since the Logical_Router_Port table in OVNNB does not have a "up" column
    (like the Logical_Switch_Port table has) the status of those ports can
    not be updpated based on it. Therefore, this patch uses the "chassis"
    column for that. If the router port has the "chassis" column in OVNNB
    database set, the binding and status ACTIVE will be set in Neutron
    otherwise it status will be udpated to DOWN (if it's not DOWN yet).

    Closes-Bug: #1715126
    Change-Id: I91026204eae6df18be47df02f99db2f95c428e2b
    (cherry picked from commit 3d575d19b850134044bba8b89cdb9953c17a5ca7)

tags: added: in-stable-rocky

Reviewed: https://review.openstack.org/600386
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=27b6ea454b558178163055317901ddb55392c676
Submitter: Zuul
Branch: stable/queens

commit 27b6ea454b558178163055317901ddb55392c676
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Aug 29 14:15:32 2018 +0100

    Fix gateway's router port marked as DOWN

    This patch is fixing a problem which left the external/gateway's router
    port with status DOWN even after the port was bound to a chassis.

    Since the Logical_Router_Port table in OVNNB does not have a "up" column
    (like the Logical_Switch_Port table has) the status of those ports can
    not be updpated based on it. Therefore, this patch uses the "chassis"
    column for that. If the router port has the "chassis" column in OVNNB
    database set, the binding and status ACTIVE will be set in Neutron
    otherwise it status will be udpated to DOWN (if it's not DOWN yet).

    Closes-Bug: #1715126
    Change-Id: I91026204eae6df18be47df02f99db2f95c428e2b
    (cherry picked from commit 3d575d19b850134044bba8b89cdb9953c17a5ca7)

This issue was fixed in the openstack/networking-ovn 4.0.3 release.

This issue was fixed in the openstack/networking-ovn 5.0.1 release.

This issue was fixed in the openstack/networking-ovn 6.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers