Remove BEFORE_UPDATE event from _subnet_gateway_ip_update

Bug #1691422 reported by Dong Jun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-ovn
Fix Released
Undecided
Dong Jun

Bug Description

In patch[1], resources.SUBNET_GATEWAY was replaced by resources.SUBNET in _subnet_gateway_ip_update.
After this change, we have both original subnet and current subnet in context, that we no longer need BEFORE_UPDATE event, and routes operations will be move to one transaction to make them atomic.

[1] https://review.openstack.org/#/c/464775/

Dong Jun (dongj)
Changed in networking-ovn:
assignee: nobody → Dong Jun (dongj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/465839

Changed in networking-ovn:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (master)

Reviewed: https://review.openstack.org/465839
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=268de3f32b06b63ae056bb90ac1ee6297ffa565d
Submitter: Jenkins
Branch: master

commit 268de3f32b06b63ae056bb90ac1ee6297ffa565d
Author: Dong Jun <email address hidden>
Date: Thu May 18 14:22:48 2017 +0800

    Remove BEFORE_UPDATE event from _subnet_gateway_ip_update

    After patch [1] merged, BEFORE_UPDATE event is no longer needed, and
    routes operations can be move to one transaction to make them atomic.
    This patch also changes method name to _subnet_update.
    [1] https://review.openstack.org/#/c/464775/

    Change-Id: I08b1a149df69efc7786b59a6595141ea51b49e2d
    Closes-Bug: #1691422
    Signed-off-by: Dong Jun <email address hidden>

Changed in networking-ovn:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-ovn 3.0.0.0b2

This issue was fixed in the openstack/networking-ovn 3.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.