update port should fail when port not exists

[ZongKai LI]

Steps to reproduce:
 - create a port with --no-security-group
 - [1] update the port with a certain security-group
 - [2] delete the port

if steps [1] and [2] come in the same time, and delete_lswitch_port get called before set_lswitch_port. (You may insert a sleep time in _update_port_in_ovn to make it easier to happen. Logical_Switch_Port will be deleted, but with ACL rules for ghost port left behind.

[Richard Theis (rtheis)]

This may be another case of https://bugs.launchpad.net/networking-ovn/+bug/1605089

[Richard Theis (rtheis)]

https://review.openstack.org/#/c/374585/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374585
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=ff4a8d4a9f1b29301e2f12fd848649d77504ca55
Submitter: Jenkins
Branch: master

commit ff4a8d4a9f1b29301e2f12fd848649d77504ca55
Author: lzklibj <email address hidden>
Date: Thu Sep 22 07:24:25 2016 +0000

    enhance DHCP with improved transaction

    Based on improved neutron ovsdb transaction, we can put two ovsdb commands
    into to one transaction, when they have dependency on data structure.
    Like, before we set port dhcp options for a port, or create a port with port
    dhcp options, we need to insert the port dhcp options first, and get the
    inserted UUID. And currently, we do these by separated transactions.

    Separated transactions make orphan row can happen, and to clean orphan rows
    related to ports left behind, we do full table scan to locate them, lose in
    performance.

    Since the patch will fix the orphan DHCP_Options row issue,
    DelLSwitchPortCommand will be also enhanced to remove port dhcp options
    referred by port within the same transaction.

    Depends-on: I1781794958af1483dabc0f5d17f2df6fea828564
    Closes-bug: #1626812
    Closes-bug: #1626828
    Change-Id: Id078d57fe84e1af8db061ae6b812f162fed02dcd

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 2.0.0.0b1 development milestone.