Add more funtional test

[Numan Siddique]

The initial commit which added functional tests covered only lswitch and lport db sync. we need to test the db sync for other resources as well.

[Richard Theis (rtheis)]

I've pushed a patch to address one of the TODOs in the functional test code: https://review.openstack.org/#/c/333404/

[Richard Theis (rtheis)]

Another patch pushed for static routes: https://review.openstack.org/#/c/333584/

[Numan Siddique (numansiddique)]

Another one here - https://review.openstack.org/#/c/332663/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333404
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=563cb606ca84d5edb84ed999246b2a0a0034c5d2
Submitter: Jenkins
Branch: master

commit 563cb606ca84d5edb84ed999246b2a0a0034c5d2
Author: Richard Theis <email address hidden>
Date: Thu Jun 23 10:06:30 2016 -0500

    Functional Test: Create OVN NB DB resources

    Enhance functional tests to create resources in the OVN NB DB which
    will be deleted by the OVN NB DB sync repair processing.

    Change-Id: I613b0ce7b527374bc3e709570b1a7236bdd77bc1
    Partial-Bug: #1594241

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333584
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=d60d906b900639eff94c0f41a0093abaa5378118
Submitter: Jenkins
Branch: master

commit d60d906b900639eff94c0f41a0093abaa5378118
Author: Richard Theis <email address hidden>
Date: Thu Jun 23 15:55:15 2016 -0500

    Functional Test: Sync lrouter static routes

    Enhance functional tests to ensure that lrouter static routes
    are properly synchronized during OVN NB DB synchronization.

    Change-Id: Ic564281c319e82d2e93522cd20ebf2b5bb34f841
    Partial-Bug: #1594241

[Numan Siddique (numansiddique)]

Functional tests related to ACL sync are still missing. I couldn't add those in the review - https://review.openstack.org/#/c/332663/.

I am un-assigning from this bug, so that some one interested can work on the ACL sync functional tests.

[Richard Theis (rtheis)]

I can work on this. I'll probably wait for address set support (https://bugs.launchpad.net/networking-ovn/+bug/1560817) before adding the ACL sync tests.

[Numan Siddique (numansiddique)]

@Richard - Thanks :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332663
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=f7f347d2d259020e92de6466e8633d22db504f59
Submitter: Jenkins
Branch: master

commit f7f347d2d259020e92de6466e8633d22db504f59
Author: Numan Siddique <email address hidden>
Date: Wed Jun 22 11:37:12 2016 +0530

    Add functional tests for ovsdb-monitor

    This patch adds functional tests to test ovsdb monitor.

    Change-Id: I4abf5ace581053fdbca823256817b0a3b13267d8
    Partial-Bug: #1594241

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/347898

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/347898
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=63b4601db0f33fb68f79eebd41de136c1a5d2017
Submitter: Jenkins
Branch: master

commit 63b4601db0f33fb68f79eebd41de136c1a5d2017
Author: Richard Theis <email address hidden>
Date: Tue Jul 26 16:59:35 2016 -0500

    Functional Test: Sync ACLs

    Enhance functional tests to ensure that ACLs are properly
    synchronized during OVN NB DB synchronization.

    While enhancing the tests, a bug was discovered that resulted
    in synchronization removing all ACLs for a port when it only
    needed to create the port in OVN (ACLs already exist). This
    was caused by duplicate ACLs being created during the port sync.

    Change-Id: Ief64f73511de70ff16aaf2a2a9d26ae5a718c3b3
    Closes-Bug: #1594241

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/networking-ovn 1.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 1.0.0.0b3 development milestone.