Not support set router admin down

Bug #1563175 reported by Na Zhu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-ovn
Fix Released
Medium
Na Zhu

Bug Description

In neutron, when set the router admin down, the netns for the router is deleted.
But in OVN, there is no support about router admin state up/down.

Tags: ovn-upstream
Revision history for this message
Russell Bryant (russellb) wrote :

We could implement this by deleting the router from OVN for now.

We implemented administrative port state in OVN for ports. I suppose we could do the same for routers.

Changed in networking-ovn:
status: New → Confirmed
importance: Undecided → Medium
tags: added: ovn-upstream
Revision history for this message
Na Zhu (nazhu) wrote :

Can you assign this bug to me, i think i can fix it.

Changed in networking-ovn:
assignee: nobody → Na Zhu (nazhu)
Revision history for this message
Na Zhu (nazhu) wrote :

@Russel, there is column "enabled" in table Logical_Port, when set admin state down for neutron port, the plugin set the column "enabled" to false, not delete the logical port.

Since table Logical_Router does not have column "enabled", we can not do router admin state the same as port.
I think delete the router from OVN is a simple way.

Revision history for this message
Russell Bryant (russellb) wrote :

Yes, deleting the router is fine. That's the only way to do it today.

I'd also be happy with a patch to OVN adding an enabled flag to Logical_Router.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ovn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/299835

Changed in networking-ovn:
status: Confirmed → In Progress
Revision history for this message
Na Zhu (nazhu) wrote :

@Russell, I think add enabled flag to Logical_Router is a better, I will submit a patch for it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (master)

Reviewed: https://review.openstack.org/299835
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=0320b7c9dbb064b469b0a603f687f7a50bd293b5
Submitter: Jenkins
Branch: master

commit 0320b7c9dbb064b469b0a603f687f7a50bd293b5
Author: Na <email address hidden>
Date: Thu Mar 31 04:39:27 2016 -0500

    Add configuration for router admin state

    The ovn table logical_router has column 'enabled',
    when admin-state-up is true, set the column 'enabled' to true,
    when admin-state-up is false, set the column 'enabled' to false.

    Change-Id: I1be984989858bd3277f915637b10b49efc3cb507
    Closes-Bug: #1563175

Changed in networking-ovn:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.