Move L3 related code to networking_ovn/l3/l3_ovn.py

Bug #1514998 reported by Amitabha Biswas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-ovn
Fix Released
Undecided
Amitabha Biswas

Bug Description

Some of the current patches for e.g. https://review.openstack.org/#/c/237820/ embedded the L3 code for add/delete router interface in the networking_ovn/plugin.py file. These functions belong in the networking_ovn/l3/l3_ovn.py files.

Changed in networking-ovn:
assignee: nobody → Amitabha Biswas (azbiswas)
Revision history for this message
Russell Bryant (russellb) wrote :

I know that file was created a long time ago, but is there a reason we have to use it instead of just remove it?

Changed in networking-ovn:
status: New → Incomplete
Revision history for this message
Amitabha Biswas (azbiswas) wrote :

We don't have to use it, this bug was filed in response to a comment made on the https://review.openstack.org/#/c/237820/ patch stating that the add/delete router code belongs in the L3 file. We can delete the l3 file, once we make sure all the stub routines are handled in the base plugin.py file.

Revision history for this message
Russell Bryant (russellb) wrote :

Sounds good. We can keep this bug open to either use the file or delete it. I tend to think we'll just delete it though.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (master)

Reviewed: https://review.openstack.org/267119
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=a320a1338d4dc2e5650077629bb181a08afe8693
Submitter: Jenkins
Branch: master

commit a320a1338d4dc2e5650077629bb181a08afe8693
Author: Russell Bryant <email address hidden>
Date: Wed Jan 13 14:15:49 2016 -0500

    Drop l3 directory.

    This directory was created at the beginning of the project but was never
    used. The l3 support is in plugin.py.

    Closes-bug: 1514998
    Change-Id: I35ebfef399aaf82212bb229f6c3f3c26b01b67c7
    Signed-off-by: Russell Bryant <email address hidden>

Changed in networking-ovn:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.