devstack does not handle double-digit version numbers of ODL

[Elod Illes]

ODL's latest releases are
- Neon (version: 0.10)
- Sodium (version: 0.11)

If the local.conf contains for example the
 ODL_RELEASE=nitrogen-snapshot-0.7
then devstack uses latest release of ODL Nitrogen (version 0.7).
However in case of recent releases, for example:
 ODL_RELEASE=neon-snapshot-0.10
devstack fails that it cannot download the given version:

wget -O /opt/stack//opendaylight/maven-metadata.xml https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.10-SNAPSHOT/maven-metadata.xml
--2019-08-28 13:20:51-- https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.10-SNAPSHOT/maven-metadata.xml
Resolving nexus.opendaylight.org (nexus.opendaylight.org)... 199.204.45.87, 2604:e100:1:0:f816:3eff:fe45:48d6
Connecting to nexus.opendaylight.org (nexus.opendaylight.org)|199.204.45.87|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-08-28 13:20:52 ERROR 404: Not Found.

the correct link would be:

https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.10.2-SNAPSHOT/maven-metadata.xml

The root cause of the problem is that networking-odl's devstack scripts does not handle double-digit versions.

ODL version Neon is supported since Rocky [1], so this problem affects master, stable/stein, stable/rocky.

[1] https://docs.opendaylight.org/projects/netvirt/en/stable-neon/user-guide/support.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/679091

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/679091
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=a9282bb005a67b44b3db6613838aa2fa84d0a30d
Submitter: Zuul
Branch: master

commit a9282bb005a67b44b3db6613838aa2fa84d0a30d
Author: Elod Illes <email address hidden>
Date: Wed Aug 28 16:24:09 2019 +0200

    Fix double-digit ODL version number handling for devstack

    Latest releases of ODL (Neon: 0.10; Sodium 0.11) snapshots download
    fails in case of adding for example 'ODL_RELEASE=neon-snapshot-0.10' to
    local.conf. This patch fixes pattern to allow double-digit version
    string match.

    Closes-Bug: #1841760
    Change-Id: I0f7fcc49a528cf5c57f11ce9685ddd0e4d559d56

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/682053

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/682053
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=cae2107fcce10ffe183efeb8db270ce34490ad9d
Submitter: Zuul
Branch: stable/stein

commit cae2107fcce10ffe183efeb8db270ce34490ad9d
Author: Elod Illes <email address hidden>
Date: Wed Aug 28 16:24:09 2019 +0200

    Fix double-digit ODL version number handling for devstack

    Latest releases of ODL (Neon: 0.10; Sodium 0.11) snapshots download
    fails in case of adding for example 'ODL_RELEASE=neon-snapshot-0.10' to
    local.conf. This patch fixes pattern to allow double-digit version
    string match.

    Conflicts:
        devstack/odl-releases/common
    Note(elod.illes): conflict is due to not having patch
    I9245f22c12dc41801323b02f42d2c7d2b8905a80 on stable/stein. That patch
    is not necessary to fix the bug in stable/stein.

    Closes-Bug: #1841760
    Change-Id: I0f7fcc49a528cf5c57f11ce9685ddd0e4d559d56
    (cherry picked from commit a9282bb005a67b44b3db6613838aa2fa84d0a30d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 15.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 14.0.1 release.