networking_odl.tests.unit.common.test_odl_features.TestOdlFeaturesNoFixture.test_feature_configs_does_not_mutate_default_features randomly failes

[Lajos Katona]

The unit test test_feature_configs_does_not_mutate_default_features randomly fails in openstack-tox-cover and in unit test jobs with the following traceback:
ft1.2: networking_odl.tests.unit.common.test_odl_features.TestOdlFeaturesNoFixture.test_feature_configs_does_not_mutate_default_features_StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/networking-odl/.tox/cover/lib/python3.6/site-packages/neutron/tests/base.py", line 177, in func
    return f(self, *args, **kwargs)
  File "/home/zuul/src/opendev.org/openstack/networking-odl/networking_odl/tests/unit/common/test_odl_features.py", line 147, in test_feature_configs_does_not_mutate_default_features
    odl_features.feature_configs)
  File "/home/zuul/src/opendev.org/openstack/networking-odl/.tox/cover/lib/python3.6/site-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/zuul/src/opendev.org/openstack/networking-odl/.tox/cover/lib/python3.6/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: {} != {'operational-port-status': '', 'bgpvpn-vni': ''}

I tried to reproduce the issue locally without success.

[Lajos Katona (lajos-katona)]

logstash query:
http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22operational-port-status%5C%22

By this it seems that sometimes this happens with neutron-lib periodic as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/668904

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lajos Katona (<email address hidden>) on branch: master
Review: https://review.opendev.org/668985
Reason: https://review.opendev.org/668904 seems to solve the unit test problem (of course I rechecked just a few times). This dummy patch was just a reference to see the difference in failure rates of unit test jobs with the failure of test_feature_configs_does_not_mutate_default_features.
Out of 7 rechecks/rebases/whatever 4 was failing (see: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22operational-port-status%5C%22%20AND%20build_change%3A%5C%22668985%5C%22)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/668904
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=ef695842c97236d8eba23ffe883f6cead7a153dc
Submitter: Zuul
Branch: master

commit ef695842c97236d8eba23ffe883f6cead7a153dc
Author: elajkat <email address hidden>
Date: Wed Jul 3 15:14:25 2019 +0200

    Try deinit odl_features in TestOdlFeaturesNoFixture setUpClass

    test_feature_configs_does_not_mutate_default_features sporadically fails
    with the following:
    testtools.matchers._impl.MismatchError: {} !=
    {'operational-port-status': '', 'bgpvpn-vni': ''}
    This patch runs odl_features.deinit at the beginning of the test to run
    it on a clean beases.

    Change-Id: I2185c30f260f95ef2e0b90c14399260702837f29
    Closes-Bug: #1835216

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/695365

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 16.0.0.0b1 development milestone.

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/695365
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/networking-odl/+/695365
Committed: https://opendev.org/openstack/networking-odl/commit/651843888b2c4a86490e1e2386b52fb24e6f7360
Submitter: "Zuul (22348)"
Branch: stable/train

commit 651843888b2c4a86490e1e2386b52fb24e6f7360
Author: elajkat <email address hidden>
Date: Wed Jul 3 15:14:25 2019 +0200

    Try deinit odl_features in TestOdlFeaturesNoFixture setUpClass

    test_feature_configs_does_not_mutate_default_features sporadically fails
    with the following:
    testtools.matchers._impl.MismatchError: {} !=
    {'operational-port-status': '', 'bgpvpn-vni': ''}
    This patch runs odl_features.deinit at the beginning of the test to run
    it on a clean beases.

    Change-Id: I2185c30f260f95ef2e0b90c14399260702837f29
    Closes-Bug: #1835216
    (cherry picked from commit ef695842c97236d8eba23ffe883f6cead7a153dc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl train-eol release.