[SecurityGroups] group delete fails if done right after a child rule delete

[Jaime Caamaño Ruiz]

When deleting a security group rule and then parent security group in rapid succession, the operation fails and the security group remains, both in neutron database and OpenDaylight.

Attached an excerpt of neutron server log with more context but this is the relevant log:

2018-01-23 12:06:56.423 28678 DEBUG neutron_lib.callbacks.manager [req-8d92b278-7282-4bb5-875f-9f335c6909ae 34ff53d0ba7044548fc78fd9769ac9e7 35a4e1c124aa4b0dace689d63d83af5f - default default] Callback networking_odl.common.callback.OdlSecurityGroupsHandler.sg_callback_precommit-761259 raised argument of type 'NoneType' is not iterable _notify_loop /openstack/venvs/neutron-master/lib/python2.7/site-packages/neutron_lib/callbacks/manager.py:184

If the security group with child security rules is deleted without first deleting the rules, everything is fine.

If the security group with child security rules is deleted some time after deleting the rules, everything is fine..

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/536935

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536935
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=2c15a7926dfd24ee363a15c53ac44dedfae7e0ce
Submitter: Zuul
Branch: master

commit 2c15a7926dfd24ee363a15c53ac44dedfae7e0ce
Author: Jaime Caamaño Ruiz <email address hidden>
Date: Tue Jan 23 19:44:12 2018 +0100

    Fix missing parentid on rule delete journal record

    This fixes an error raised when deleting a security group if there are
    pending rules to be deleted of that group as records in the journal
    that were not triggered by the group deletion operation itself so that
    they did not have the parent security group id as data of the record.

    This happens when the rule and the group are deleted independently but
    in rapid succession. It does not happen when the rules are deleted as a
    consequence of deleting the group since the parentid is correctly set
    in that case, neither when the group is deleted some time after the
    rules when their records might have already been processed and removed.

    This problem was encountered in OPNFV functest environment but may also
    fix https://jira.opendaylight.org/browse/NETVIRT-896 and complement
    change #533706.

    Change-Id: I5ccdbdea9d803334c8ae9416b40e3c4b48a8144b
    Closes-Bug: 1744966
    Signed-off-by: Jaime Caamaño Ruiz <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/538352

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 12.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/538352
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=684c46437dbeb97bb71dde248d39db4dbebcd65e
Submitter: Zuul
Branch: stable/pike

commit 684c46437dbeb97bb71dde248d39db4dbebcd65e
Author: Jaime Caamaño Ruiz <email address hidden>
Date: Tue Jan 23 19:44:12 2018 +0100

    Fix missing parentid on rule delete journal record

    This fixes an error raised when deleting a security group if there are
    pending rules to be deleted of that group as records in the journal
    that were not triggered by the group deletion operation itself so that
    they did not have the parent security group id as data of the record.

    This happens when the rule and the group are deleted independently but
    in rapid succession. It does not happen when the rules are deleted as a
    consequence of deleting the group since the parentid is correctly set
    in that case, neither when the group is deleted some time after the
    rules when their records might have already been processed and removed.

    This problem was encountered in OPNFV functest environment but may also
    fix [1] and complement [2].

    [1] https://jira.opendaylight.org/browse/NETVIRT-896
    [2] https://review.openstack.org/#/c/536935

    Change-Id: I5ccdbdea9d803334c8ae9416b40e3c4b48a8144b
    Closes-Bug: 1744966
    Signed-off-by: Jaime Caamaño Ruiz <email address hidden>
    (cherry picked from commit 2c15a7926dfd24ee363a15c53ac44dedfae7e0ce)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 11.0.1 release.