port pair group creation failed

[rajiv]

Dependency calculation is failing in sfc driver with following stack trace

ERROR networking_sfc.services.sfc.driver_manager [^[[01;36mNone req-93e02145-6228-441f-93be-c860e15ad425 ^[[00;36madmin admin] ^[[01;35mstring indices must be integers^[[00m: TypeError: string indices must be integers
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00mTraceback (most recent call last):
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m File "/opt/stack/new/networking-sfc/networking_sfc/services/sfc/driver_manager.py", line 101, in _call_drivers
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m getattr(driver.obj, method_name)(context)
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_log/helpers.py", line 67, in wrapper
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m return method(*args, **kwargs)
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m File "/opt/stack/new/networking-odl/networking_odl/sfc/sfc_driver_v2.py", line 67, in create_port_pair_group_precommit
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m context, odl_const.ODL_SFC_PORT_PAIR_GROUP, odl_const.ODL_CREATE)
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m File "/opt/stack/new/networking-odl/networking_odl/sfc/sfc_driver_v2.py", line 57, in _record_in_journal
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m context.current['id'], operation, data)
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m File "/opt/stack/new/networking-odl/networking_odl/journal/journal.py", line 96, in record
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m plugin_context.session, operation, object_type, object_uuid, data)
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m File "/opt/stack/new/networking-odl/networking_odl/journal/dependency_validations.py", line 222, in calculate
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m object_ids = dep_generator(data)
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m File "/opt/stack/new/networking-odl/networking_odl/journal/dependency_validations.py", line 136, in _generate_sfc_port_pair_group_deps
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m port_pairs = [port_pair['id'] for port_pair in data['port_pairs']]
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00mTypeError: string indices must be integers
ERROR networking_sfc.services.sfc.driver_manager ^[[01;35m^[[00m
ERROR networking_sfc.services.sfc.driver_manager [^[[01;36mNone req-93e02145-6228-441f-93be-c860e15ad425 ^[[00;36madmin admin] ^[[01;35mSFC driver 'odl_v2' failed in create_port_pair_group_precommit^[[00m

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/509688

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/509688
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=4469bc3d829d97ad56d36f6cb41e3042bb3a3976
Submitter: Zuul
Branch: master

commit 4469bc3d829d97ad56d36f6cb41e3042bb3a3976
Author: Rajiv Kumar <email address hidden>
Date: Thu Oct 5 00:22:53 2017 -0400

    Correction in dependency calculation for port pair group

    port_pair_group resource depends on port_pairs. As per current
    implementation, it is assumed that list of port_pair(dict
    representing port_pair) is present in port_pair_group dict,
    under key "port_pairs". But list of port_pair "id" is received
    from database. It causes dependency calculations to fail.

    Change-Id: I5c0cf37152eaa88a99a67d206416315982dc1c23
    Closes-bug: #1721441

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/513408

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 12.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/513408
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=0022243a9ad40e8dee5c9488e7248d6e368ef3ac
Submitter: Zuul
Branch: stable/pike

commit 0022243a9ad40e8dee5c9488e7248d6e368ef3ac
Author: Rajiv Kumar <email address hidden>
Date: Thu Oct 5 00:22:53 2017 -0400

    Correction in dependency calculation for port pair group

    port_pair_group resource depends on port_pairs. As per current
    implementation, it is assumed that list of port_pair(dict
    representing port_pair) is present in port_pair_group dict,
    under key "port_pairs". But list of port_pair "id" is received
    from database. It causes dependency calculations to fail.

    Change-Id: I5c0cf37152eaa88a99a67d206416315982dc1c23
    Closes-bug: #1721441
    (cherry picked from commit 4469bc3d829d97ad56d36f6cb41e3042bb3a3976)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 11.0.1 release.