bgpvpn update fails

[rajiv]

bgpvpn update fails with following error

ERROR neutron.api.v2.resource [^[[01;36mNone req-c6b401bc-ba8b-4a92-9aec-97ad5e43b881 ^[[00;36madmin admin] ^[[01;35mupdate failed: No details.^[[00m: TypeError: update_bgpvpn_precommit() takes exactly 3 arguments (4 given)
ERROR neutron.api.v2.resource ^[[01;35m^[[00mTraceback (most recent call last):
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/neutron/neutron/api/v2/resource.py", line 98, in resource
ERROR neutron.api.v2.resource ^[[01;35m^[[00m result = method(request=request, **args)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/neutron/neutron/api/v2/base.py", line 615, in update
ERROR neutron.api.v2.resource ^[[01;35m^[[00m return self._update(request, id, body, **kwargs)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/neutron/neutron/db/api.py", line 92, in wrapped
ERROR neutron.api.v2.resource ^[[01;35m^[[00m setattr(e, '_RETRY_EXCEEDED', True)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
ERROR neutron.api.v2.resource ^[[01;35m^[[00m self.force_reraise()
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
ERROR neutron.api.v2.resource ^[[01;35m^[[00m six.reraise(self.type_, self.value, self.tb)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/neutron/neutron/db/api.py", line 88, in wrapped
ERROR neutron.api.v2.resource ^[[01;35m^[[00m return f(*args, **kwargs)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 150, in wrapper
ERROR neutron.api.v2.resource ^[[01;35m^[[00m ectxt.value = e.inner_exc
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
ERROR neutron.api.v2.resource ^[[01;35m^[[00m self.force_reraise()
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
ERROR neutron.api.v2.resource ^[[01;35m^[[00m six.reraise(self.type_, self.value, self.tb)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 138, in wrapper
ERROR neutron.api.v2.resource ^[[01;35m^[[00m return f(*args, **kwargs)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/neutron/neutron/db/api.py", line 127, in wrapped
ERROR neutron.api.v2.resource ^[[01;35m^[[00m LOG.debug("Retry wrapper got retriable exception: %s", e)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
ERROR neutron.api.v2.resource ^[[01;35m^[[00m self.force_reraise()
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
ERROR neutron.api.v2.resource ^[[01;35m^[[00m six.reraise(self.type_, self.value, self.tb)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/neutron/neutron/db/api.py", line 123, in wrapped
ERROR neutron.api.v2.resource ^[[01;35m^[[00m return f(*dup_args, **dup_kwargs)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/neutron/neutron/api/v2/base.py", line 663, in _update
ERROR neutron.api.v2.resource ^[[01;35m^[[00m obj = obj_updater(request.context, id, **kwargs)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/networking-bgpvpn/networking_bgpvpn/neutron/services/plugin.py", line 164, in update_bgpvpn
ERROR neutron.api.v2.resource ^[[01;35m^[[00m return self.driver.update_bgpvpn(context, id, bgpvpn)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/opt/stack/new/networking-bgpvpn/networking_bgpvpn/neutron/services/service_drivers/driver_api.py", line 121, in update_bgpvpn
ERROR neutron.api.v2.resource ^[[01;35m^[[00m self.update_bgpvpn_precommit(context, old_bgpvpn, bgpvpn)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m File "/usr/local/lib/python2.7/dist-packages/oslo_log/helpers.py", line 67, in wrapper
ERROR neutron.api.v2.resource ^[[01;35m^[[00m return method(*args, **kwargs)
ERROR neutron.api.v2.resource ^[[01;35m^[[00mTypeError: update_bgpvpn_precommit() takes exactly 3 arguments (4 given)
ERROR neutron.api.v2.resource ^[[01;35m^[[00m

[Isaku Yamahata (yamahata)]

The reason of the bug is clear and triaged as high.

[Nikos Karandreas (nikos.karandreas)]

Hi folks,

this bug affects a test case in SDNVPN project [0] of OPNFV.

A fix would be much appreciated.

cheers
Nikos

[0] https://wiki.opnfv.org/display/sdnvpn

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yenuganti Vasudha (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/634197

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/networking-odl/+/634861
Reason: If needed, feel free to restore the patch, fix the merge conflict and address the comments