Journal recovery fails

Bug #1713697 reported by rajiv on 2017-08-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-odl
Critical
rajiv

Bug Description

During journal recovery a resource is fetched from ODL https://github.com/openstack/networking-odl/blob/master/networking_odl/journal/recovery.py#L64-L65 will lead to call get_<resource_type> but some of the resources like bgpvpn expect other parameters also, like https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/services/plugin.py#L220

rajiv (rajiv-kumar) on 2017-08-29
Changed in networking-odl:
assignee: nobody → rajiv (rajiv-kumar)
Changed in networking-odl:
importance: Undecided → Critical
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/500366

Changed in networking-odl:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/513158
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=7366ac0455a335e8f56a8467515bca33f3d29e28
Submitter: Zuul
Branch: master

commit 7366ac0455a335e8f56a8467515bca33f3d29e28
Author: Tim Rozet <email address hidden>
Date: Wed Oct 18 14:22:05 2017 -0400

    Fixes URL path for SFC v2 Driver

    Due to this fix https://review.openstack.org/#/c/496388/,
    now URL for OpenDaylight driver is not created correctly.

    Correct url has format

    http://<hostname>/controller/nb/v2/neutron/sfc/portpairs

    Now it produces

    http://<hostname>/controller/nb/v2/neutron/sfc/port-pairs

    Closes-Bug: 1724644
    Partial-bug: #1713697
    Duplicate-patch: https://review.openstack.org/#/c/512951/

    Change-Id: Ie4a75323694c69aaa5e682890647beaf461b6888
    Signed-off-by: Tim Rozet <email address hidden>
    Co-Authored-By: Rajiv Kumar <email address hidden>

Reviewed: https://review.openstack.org/514404
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=ab4c69a47228315448a1ccbd21829b4029b74bb7
Submitter: Zuul
Branch: stable/pike

commit ab4c69a47228315448a1ccbd21829b4029b74bb7
Author: Tim Rozet <email address hidden>
Date: Wed Oct 18 14:22:05 2017 -0400

    Fixes URL path for SFC v2 Driver

    Due to this fix https://review.openstack.org/#/c/496388/,
    now URL for OpenDaylight driver is not created correctly.

    Correct url has format

    http://<hostname>/controller/nb/v2/neutron/sfc/portpairs

    Now it produces

    http://<hostname>/controller/nb/v2/neutron/sfc/port-pairs

    Closes-Bug: 1724644
    Partial-bug: #1713697
    Duplicate-patch: https://review.openstack.org/#/c/512951/

    Change-Id: Ie4a75323694c69aaa5e682890647beaf461b6888
    Signed-off-by: Tim Rozet <email address hidden>
    Co-Authored-By: Rajiv Kumar <email address hidden>
    (cherry picked from commit 7366ac0455a335e8f56a8467515bca33f3d29e28)

tags: added: in-stable-pike

Fix proposed to branch: master
Review: https://review.openstack.org/527624

Fix proposed to branch: master
Review: https://review.openstack.org/527654

Fix proposed to branch: master
Review: https://review.openstack.org/527676

Fix proposed to branch: master
Review: https://review.openstack.org/533157

Reviewed: https://review.openstack.org/521815
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=24675835eef2f8aae4dde9d37fb772706c1892fa
Submitter: Zuul
Branch: master

commit 24675835eef2f8aae4dde9d37fb772706c1892fa
Author: Rajiv Kumar <email address hidden>
Date: Thu Nov 16 04:02:38 2017 +0000

    Base mechanism for full sync

    This patch introduce a base class containing for all drivers. This
    class is responsible for returning all resources of a specific
    types.

    Change-Id: I6e855422ce9da70c333013985b7d25a2a63bb658
    Partial-bug: #1713697

Reviewed: https://review.openstack.org/533157
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=1196e9de2823d7041abb322019044821e37c72bd
Submitter: Zuul
Branch: master

commit 1196e9de2823d7041abb322019044821e37c72bd
Author: Rajiv Kumar <email address hidden>
Date: Fri Jan 12 16:26:42 2018 +0530

    Remove redundant exception

    Remove UnsupportedResourceType exception defined in
    networking_odl/journal/journal.py and use exception defined in
    neworking_odl/common/exceptions.py.

    Change-Id: Icaaae5f62f58be9f57ab71f1d4b9f946f0840867
    Partial-Bug: #1713697

Reviewed: https://review.openstack.org/523043
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=64f0692d680b15530c8c1dc9f6366a49aec57d0d
Submitter: Zuul
Branch: master

commit 64f0692d680b15530c8c1dc9f6366a49aec57d0d
Author: Rajiv Kumar <email address hidden>
Date: Fri Nov 24 05:43:36 2017 +0000

    Base mechanism for recovery

    This patch introduces default implmentation of get_resource method
    to ResourceBaseDriver class to allow recovery mechanism to fetch a
    resource based on id. If a driver wants to provide its own
    implementation then introduced method has to be overridden.

    Change-Id: I951d05783ccbe1bc873a76511d254f90e71a4914
    Partial-Bug: #1713697

Reviewed: https://review.openstack.org/527391
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=6e9cb606ec837ec5e380703c895132d7f7df6591
Submitter: Zuul
Branch: master

commit 6e9cb606ec837ec5e380703c895132d7f7df6591
Author: Rajiv Kumar <email address hidden>
Date: Tue Dec 12 18:07:37 2017 +0530

    Enabling ML2 for new full sync and recovery mechanism

    This patch provide basic code for enabling full sync and recovery
    for ML2. It keeps existing mechanism as it is, but implements
    other protocols expected by new full sync mechanism.

    This patch adds resources to driver classes, which will be used
    by base driver to register for full sync and recovery.

    Change-Id: I00b5a5f927ef3b2cce1bfa203a1402dd3cd1c61e
    Partial-Bug: #1713697

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers