Error during full sync with QoS

[Tim Rozet]

Error when specifying qos extension driver and service plugin:

2017-08-15 17:47:41.859 64185 INFO neutron.wsgi [-] 192.168.24.3 "OPTIONS / HTTP/1.0" status: 200 len: 249 time: 0.0029640
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task [req-5a639c24-7563-4b14-9f42-7d151264fe84 - - - - -] Failed during periodic task operation full_sync.: TypeError: get_objects() argument after ** must be a mapping, not NoneType
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task Traceback (most recent call last):
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task File "/usr/lib/python2.7/site-packages/networking_odl/journal/periodic_task.py", line 61, in _execute_op
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task operation(context=context)
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task File "/usr/lib/python2.7/site-packages/networking_odl/journal/full_sync.py", line 84, in full_sync
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task collection_name)
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task File "/usr/lib/python2.7/site-packages/networking_odl/journal/full_sync.py", line 120, in _sync_resources
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task resources = obj_getter(context)
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task File "/usr/lib/python2.7/site-packages/neutron/db/db_base_plugin_common.py", line 62, in inner_filter
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task result = f(*args, **kwargs)
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task File "/usr/lib/python2.7/site-packages/neutron/db/db_base_plugin_common.py", line 48, in inner
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task result = f(*args, **kwargs)
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task File "/usr/lib/python2.7/site-packages/neutron/services/qos/qos_plugin.py", line 267, in get_policies
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task **filters)
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task TypeError: get_objects() argument after ** must be a mapping, not NoneType
2017-08-15 17:47:42.007 63696 ERROR networking_odl.journal.periodic_task

[Isaku Yamahata (yamahata)]

This is a candidate for backport to Pike. So this is marked as critical.

[Manjeet Singh Bhatia (manjeet-s-bhatia)]

can you add more details when do you exactly see the error ? is it when you enable qos with networking-odl,

like on restarting q-svc after adding qos to service_plugins and extension driver ?
I don't see issue when i add qos to service plugins and extension driver and restart the q-svc.

or steps to reproduce ?

[Manjeet Singh Bhatia (manjeet-s-bhatia)]

Please also add details, which mechanism_driver are you using opendaylight_v2 or v1 ?

[Tim Rozet (trozet)]

This is with V2 driver. Attached neutron server log with error.

[Manjeet Singh Bhatia (manjeet-s-bhatia)]

Tim can you try https://review.openstack.org/#/c/494663/ and confirm if it is still an issue ?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Isaku Yamahata (<email address hidden>) on branch: master
Review: https://review.openstack.org/494663
Reason: Now neutron patches were merged to master and stable/pike.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/495904
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=13ab6e350cc011e40b79b1e0f680bbabc4af3fe1
Submitter: Jenkins
Branch: stable/pike

commit 13ab6e350cc011e40b79b1e0f680bbabc4af3fe1
Author: Reedip <email address hidden>
Date: Fri Aug 18 05:43:03 2017 +0000

    Treat Filter as Dict in get_policies

    Currently QoS plugin's get_policies doesnt check if the filter
    is a dict or not, though similar checks exist in get_rule_types()
    and get_policy_rules().
    This patch adds the check so that if any consumer passes filters=None
    then it is converted to a dict.

    TrivialFix
    Partial-Bug: #1711165

    Change-Id: Id50674c44cd3720dcd8fd6d66361d937599f5992
    (cherry picked from commit 23ef48ad558def5ed2ce701e651a50590ac323c0)