fullsync: networking-odl fills neutron_server log with errors

[jiriprox]

We have pike rc1 deployment with ODL enabled. Neutron server log is full of error bellow.

    def get_policies(self, context, filters=None, fields=None, sorts=None,
                     limit=None, marker=None, page_reverse=False):

filters should not have default value None. Empty dict should be avoid that exception.

2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task [req-d76b87e4-163c-42aa-874f-08acccb7eda5 - - - - -] Failed during periodic task operation full_sync.: TypeError: get_objects() argument after ** must be a mapping, not NoneType
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task Traceback (most recent call last):
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_odl/journal/periodic_task.py", line 61, in _execute_op
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task operation(context=context)
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_odl/journal/full_sync.py", line 84, in full_sync
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task collection_name)
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_odl/journal/full_sync.py", line 120, in _sync_resources
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task resources = obj_getter(context)
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task File "/var/lib/kolla/venv/lib/python2.7/site-packages/neutron/db/db_base_plugin_common.py", line 62, in inner_filter
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task result = f(*args, **kwargs)
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task File "/var/lib/kolla/venv/lib/python2.7/site-packages/neutron/db/db_base_plugin_common.py", line 48, in inner
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task result = f(*args, **kwargs)
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task File "/var/lib/kolla/venv/lib/python2.7/site-packages/neutron/services/qos/qos_plugin.py", line 267, in get_policies
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task **filters)
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task TypeError: get_objects() argument after ** must be a mapping, not NoneType
2017-08-14 20:55:55.005 7 ERROR networking_odl.journal.periodic_task

[Isaku Yamahata (yamahata)]

The fix will be backport candidate to Pike. So this is marked as critical.

[rajiv (rajiv-kumar)]

Solved in https://review.openstack.org/#/c/494953/