devstack regression: neutron-odl-ovs-hostconfig doesnt exist on compute hosts, prevents devstack from loading

[Alon Kochba]

regression since merging https://review.openstack.org/#/c/346283/

neutron-odl-ovs-hostconfig only exists on control nodes with neutron
it should not be run on compute nods

currently compute nodes cannot load - need to see how we test and gate these changes (how is getting the ODL gating build back up going?)

2016-08-03 10:46:57.383 | ++ /opt/stack//networking-odl/devstack/entry_points:bind_opendaylight_controller:271 : sudo neutron-odl-ovs-hostconfig --config-file=/etc/neutron/neutron.conf '--ovs_hostconfigs={"ODL L2": { "supported_vnic_types":[{"vnic_type":"normal", "vif_type":"ovs","vif_details":{}}], "allowed_network_types":["local","vlan","vxlan","gre"], "bridge_mappings":{"physnet1":"br-ex"}},"ODL L3": {}}'
2016-08-03 10:46:57.386 | sudo: neutron-odl-ovs-hostconfig: command not found

[Isaku Yamahata (yamahata)]

Ideally multinode CI something similar to neutron's gate-tempest-dsvm-neutron-multinode-full should be enabled.
So far we haven't reached it yet.

[Mohammed Z Malick (mohammed-zaheeruddin-malick)]

Try with fix: https://review.openstack.org/350722

[Isaku Yamahata (yamahata)]

status is usually automatically updated by bot when patch is merged.
Anyway until the patch is really merged/release, please don't change it so.

[Federico Ressi (federico-ressi-9)]

The problem should be fixed by this two changes:

https://review.openstack.org/#/c/350722/
https://review.openstack.org/#/c/359501/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/359501
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=088e0c4f024e152eb40df7c79e5ea718acf10678
Submitter: Jenkins
Branch: master

commit 088e0c4f024e152eb40df7c79e5ea718acf10678
Author: mzmalick <email address hidden>
Date: Wed Aug 24 21:23:53 2016 +0000

    Cloud admin script auto-config hostconfig defaults

    - Support for auto-generation of hostconfig JSON for use with
        networking-odl/pseudo port binding controller
    - Command line options added for customization of hostconfigs
    - Auto detect OVS data path type for appropriate hostconfig JSON generation

    Change-Id: If2ef52d21e272e8bbfe5b5c7f358004099015e9e
    Closes-bug: #1609359
    Co-Authored-By: Federico Ressi <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/350722
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=3b92aad252d08dc3a8d18ddec774f5611a90e9e9
Submitter: Jenkins
Branch: master

commit 3b92aad252d08dc3a8d18ddec774f5611a90e9e9
Author: Isaku Yamahata <email address hidden>
Date: Fri Aug 5 12:11:16 2016 -0700

    devstack: setup hostconfig on compute node

    For pseudo agent port binding, hostconfig in ovsdb needs to be setup
    properly.
    Since on compute node also needs networking-odl for helper commands,
    install networking-odl on compute node.
    rename install_opendaylight_neutron_thin_ml2_driver to
    install_networkign_odl to reflect the reality. the old one was named
    for historical reason.

    Change-Id: Id0c0da15814e1f63868911194734a82fcc37fd4f
    Closes-bug: #1609359
    Co-Authored-By: Isaku Yamahata <email address hidden>
    Co-Authored-By: Federico Ressi <email address hidden>

[Alon Kochba (alonkochba)]

We just added newton runs in ODL test (these are multinode).
Could you use the runs in the links below to test this functionality?

This error happens in computes -
2016-10-12 00:03:08.045 | ++ /opt/stack/networking-odl/devstack/entry_points:bind_opendaylight_controller:279 : sudo neutron-odl-ovs-hostconfig --config-file=/etc/neutron/neutron.conf --debug --noovs_dpdk --bridge_mappings=physnet1:br-ex
2016-10-12 00:03:08.572 | Traceback (most recent call last):
2016-10-12 00:03:08.572 | File "/usr/bin/neutron-odl-ovs-hostconfig", line 10, in <module>
2016-10-12 00:03:08.572 | sys.exit(main())
2016-10-12 00:03:08.573 | File "/opt/stack/networking-odl/networking_odl/cmd/set_ovs_hostconfigs.py", line 254, in main
2016-10-12 00:03:08.573 | conf = setup_conf(args)
2016-10-12 00:03:08.573 | File "/opt/stack/networking-odl/networking_odl/cmd/set_ovs_hostconfigs.py", line 383, in setup_conf
2016-10-12 00:03:08.573 | conf.import_opt('host', 'neutron.common.config')
2016-10-12 00:03:08.573 | File "/usr/lib/python2.7/site-packages/oslo_config/cfg.py", line 2445, in import_opt
2016-10-12 00:03:08.573 | __import__(module_str)
2016-10-12 00:03:08.573 | ImportError: No module named neutron.common.config
2016-10-12 00:03:08.601 | + /opt/stack/networking-odl/devstack/entry_points:bind_opendaylight_controller:1 : exit_trap

https://jenkins.opendaylight.org/releng/view/netvirt/job/netvirt-vpnservice-csit-1node-openstack-newton-transparent-carbon/1/
https://logs.opendaylight.org/releng/jenkins092/netvirt-vpnservice-csit-1node-openstack-newton-transparent-carbon/1/archives/
https://logs.opendaylight.org/releng/jenkins092/netvirt-vpnservice-csit-1node-openstack-newton-transparent-carbon/1/archives/openstack_compute_stack_1.log.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/385622

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385622
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=7035ed972e5a182a48278949cfa354e5794bcbf4
Submitter: Jenkins
Branch: master

commit 7035ed972e5a182a48278949cfa354e5794bcbf4
Author: Federico Ressi <email address hidden>
Date: Wed Oct 12 22:16:34 2016 +0100

    Remove dependency from neutron and move main() to the end.

    This follows the reviews comments not handlerd before merging
    this change:

    https://review.openstack.org/#/c/350722/

    Change-Id: I43aab59778830b3a208dc5e0327d52a7bdfd4097
    Closes-bug: #1609359

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 3.0.0 release.