Race condition in journal between event write and thread processing

[Mike Kolesnik]

Journal rows are written in the pre-commit hook, thus available only when the original operation (i.e. add port) commits.
The journal is triggered on the end of the pre-commit hook to handle the event asynchronously with a new DB transaction.

Therefore, if the commit doesn't happen before the journal tries to read the row it won't see it yet and the processing will only occur on the next thread run (after interval has passed).

[yalei wang (yalei-wang)]

good point!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306818
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=1962b0a15188e411d4b9a955530a899351f8a27a
Submitter: Jenkins
Branch: master

commit 1962b0a15188e411d4b9a955530a899351f8a27a
Author: oshvartz <email address hidden>
Date: Sun Apr 17 12:21:24 2016 +0300

    Fix race between event write and thread processing

    Journal rows are written in the pre-commit hook,
    thus available only when the original operation (i.e. add port) commits.
    In order to prevent race condition the journal triggering was moved
    from pre-commit to post-commit.

    Change-Id: I0b52ccb43b405e7dd3d4f65066169a8bbee58c39
    Closes-Bug: #1569986

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/networking-odl 2.0.0 release.