SDN assist driver binds to ports on disallowed physnets

[Mark Goddard]

When using the mlnx_sdn_assist mechanism driver to bind ports for bare metal compute nodes, teh driver will attempt to bind ports on physical networks outside of the allowed list.

Steps to reproduce
==================

Configure the driver to use a specific physical network using ml2_conf.ini, e.g. physnet1:

[sdn]
physical_networks = physnet1

Create an instance on an ironic bare metal compute node using nova, using a port on a network with a different physnet e.g. physnet2

[Mark Goddard (mgoddard)]

Review: https://review.openstack.org/#/c/554631/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554631
Committed: https://git.openstack.org/cgit/openstack/networking-mlnx/commit/?id=3d7dc5f1d32fa34eeda73edafcde573f8282bfd8
Submitter: Zuul
Branch: master

commit 3d7dc5f1d32fa34eeda73edafcde573f8282bfd8
Author: Mark Goddard <email address hidden>
Date: Tue Mar 20 13:30:03 2018 +0000

    Don't bind ports on disallowed physical networks

    The existing logic in the mlnx_sdn_assist mechanism driver means that a
    port may be bound, even if the port's network's physical network is not
    allowed for the driver. This change fixes that.

    Change-Id: Id3ba9ddffa008662791265f16efa532544152756
    Closes-Bug: #1757206

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/554852

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/554853

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554852
Committed: https://git.openstack.org/cgit/openstack/networking-mlnx/commit/?id=8440ae054c73832cdd267157f310a194d72d8451
Submitter: Zuul
Branch: stable/queens

commit 8440ae054c73832cdd267157f310a194d72d8451
Author: Mark Goddard <email address hidden>
Date: Tue Mar 20 13:30:03 2018 +0000

    Don't bind ports on disallowed physical networks

    The existing logic in the mlnx_sdn_assist mechanism driver means that a
    port may be bound, even if the port's network's physical network is not
    allowed for the driver. This change fixes that.

    Change-Id: Id3ba9ddffa008662791265f16efa532544152756
    Closes-Bug: #1757206
    (cherry picked from commit 3d7dc5f1d32fa34eeda73edafcde573f8282bfd8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554853
Committed: https://git.openstack.org/cgit/openstack/networking-mlnx/commit/?id=947b6d7552e94de187a6a8e8978bf54e07e53a76
Submitter: Zuul
Branch: stable/pike

commit 947b6d7552e94de187a6a8e8978bf54e07e53a76
Author: Mark Goddard <email address hidden>
Date: Tue Mar 20 13:30:03 2018 +0000

    Don't bind ports on disallowed physical networks

    The existing logic in the mlnx_sdn_assist mechanism driver means that a
    port may be bound, even if the port's network's physical network is not
    allowed for the driver. This change fixes that.

    Change-Id: Id3ba9ddffa008662791265f16efa532544152756
    Closes-Bug: #1757206
    (cherry picked from commit 3d7dc5f1d32fa34eeda73edafcde573f8282bfd8)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/555150

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/555150
Committed: https://git.openstack.org/cgit/openstack/networking-mlnx/commit/?id=20a77bc2e06cfabcd9a7be9283723e63f5daa4b4
Submitter: Zuul
Branch: stable/ocata

commit 20a77bc2e06cfabcd9a7be9283723e63f5daa4b4
Author: Mark Goddard <email address hidden>
Date: Tue Mar 20 13:30:03 2018 +0000

    Don't bind ports on disallowed physical networks

    The existing logic in the mlnx_sdn_assist mechanism driver means that a
    port may be bound, even if the port's network's physical network is not
    allowed for the driver. This change fixes that.

    Change-Id: Id3ba9ddffa008662791265f16efa532544152756
    Closes-Bug: #1757206
    (cherry picked from commit 3d7dc5f1d32fa34eeda73edafcde573f8282bfd8)