lack of client for midonet variant of l2gw

[Yoichiro Iura]

The upstream 'networking-l2gw' API is re-used on midonetplugin, but "devices" parameter's format has been changed.
So, l2-gateway-create cli cannot work with midonetplugin.

l2-gateway-create cli cannot create correct body for midonetplugin.
https://github.com/openstack/networking-midonet/blob/master/specs/mitaka/border_gw.rst

[YAMAMOTO Takashi (yamamoto)]

can you provide a pointer to the "devices" parameter's format change?

[Yoichiro Iura (iura-yoichiro)]

Hi YAMAMOTO,

I point the followings about "devices parameter" in json body.
Currently, l2-gateway-create cli create only a body for l2gw(upstream),
so l2-gateway-createc cli is failed with midonetplugin.

- midonetplugin
  "devices": [{"device_id": "<device-id1>", "segmentation-id": <seg-id1>}]

- l2gw(upstream)
  "devices": [{"device_name": "<device-name1>",
                             "interfaces": [{"name":"<interface-name1>",
                                             "segmentation-id":[<seg-id1>]},
                                            {"name":"<interface-name2>",
                                             "segmentation-id":[<seg-id2>,
                                                                <seg-id3>]}]
                            },
                            {"device_name": "<device-name2>",
                             "interfaces": [{"name":"<interface-name1>",
                                             "segmentation-id":[<seg-id1>]},
                                            {"name":"<interface-name2>",
                                             "segmentation-id":[<seg-id2>,
                                                                <seg-id3>]}]

And I attached a excerpt of the result of the cli.

DEBUG: keystoneauth.session REQ: curl -g -i -X POST http://172.16.33.14:9696/v2.0/l2-gateways.json -H "User-Agent: python-neutronclient" -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: {SHA1}e503752fa025391213e87078e52d09fbc99b3747" -d '{"l2_gateway": {"name": "l2gw", "devices": [{"interfaces": [{"name": "4b09f863-4a28-451d-b1ea-61b7328b87ef"}], "device_name": "gw-device-az1"}]}}'
DEBUG: keystoneauth.session RESP: [400] Date: Wed, 11 May 2016 11:25:14 GMT Connection: keep-alive Content-Type: application/json; charset=UTF-8 Content-Length: 156 X-Openstack-Request-Id: req-ed3e3fee-7aaf-40b5-8d51-e0472df236b3
RESP BODY: {"NeutronError": {"message": "Invalid input for devices. Reason: Cannot create a gateway with an empty device_id.", "type": "HTTPBadRequest", "detail": ""}}

DEBUG: neutronclient.v2_0.client Error message: {"NeutronError": {"message": "Invalid input for devices. Reason: Cannot create a gateway with an empty device_id.", "type": "HTTPBadRequest", "detail": ""}}
ERROR: neutronclient.shell Invalid input for devices. Reason: Cannot create a gateway with an empty device_id.

[YAMAMOTO Takashi (yamamoto)]

i got it, thank you for explanation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/323669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/323669
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=64090b55dd3e81a9ecf94e674628c8b73c304ca5
Submitter: Jenkins
Branch: master

commit 64090b55dd3e81a9ecf94e674628c8b73c304ca5
Author: Yoichiro Iura <email address hidden>
Date: Mon May 30 06:01:28 2016 +0000

    Fix lack of client for midonet variant of l2gw

    This patch supports l2 gateway cli for midonet l2gateway.

    Note: L2gateway create CLI name of Midonet are different from that of
          networking-l2gw and includes "midonet-" prefix.

    Change-Id: Ie1e3072bea09af6bdf528621326859322167f984
    Closes-bug: #1580566

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/337493

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337493
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=748c4ec756d054cba3b534026f324198f869e897
Submitter: Jenkins
Branch: master

commit 748c4ec756d054cba3b534026f324198f869e897
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Jul 5 16:14:53 2016 +0900

    Disable l2gw cli extension

    Disable our variant of l2gw cli extension for now because:

    - It needs networking-l2gw installed, but we don't want to make it
      a hard requirement right now

    - It uses the duplicated entry ("l2_gateway") as the one provided by
      networking-l2gw project

    Closes-Bug: #1599043
    Related-Bug: #1580566
    Change-Id: Ia6d40a8f66adc649c5d85828fb371f07f2e72199

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/348789

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/348789
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=aee8c149fd299914d13ae78a59ff7cd863bda365
Submitter: Jenkins
Branch: stable/mitaka

commit aee8c149fd299914d13ae78a59ff7cd863bda365
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Jul 5 16:14:53 2016 +0900

    Disable l2gw cli extension

    Disable our variant of l2gw cli extension for now because:

    - It needs networking-l2gw installed, but we don't want to make it
      a hard requirement right now

    - It uses the duplicated entry ("l2_gateway") as the one provided by
      networking-l2gw project

    Closes-Bug: #1599043
    Related-Bug: #1580566
    Change-Id: Ia6d40a8f66adc649c5d85828fb371f07f2e72199

[YAMAMOTO Takashi (yamamoto)]

the fix was reverted.
https://bugs.launchpad.net/networking-midonet/+bug/1608382