networking-midonet

Format chack is failing with N330 Use assertEqual(*empty*, observed) in test_extension_gateway_device.py

Bug #1533047 reported by Kengo Hobo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-midonet
Fix Released
Critical
YAMAMOTO Takashi
networking-midonet 2.0.0

Bug Description

Format chack is failing with N330 Use assertEqual(*empty*, observed) in test_extension_gateway_device.py

The affected commit:
https://github.com/openstack/neutron/commit/3491cbc0c510404bfb4ddc2e60fde5c5d23400fd

Error detail:
./midonet/neutron/tests/unit/test_extension_gateway_device.py:333:17: N330 Use assertEqual(*empty*, observed) instead of assertEqual(observed, *empty*). *empty* contains {}, [], (), set(), '', ""
                self.assertEqual(

See original description
Kengo Hobo (hobo-kengo)
description: updated
Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

critical as it affects gate

Changed in networking-midonet:
importance: Undecided → Critical
milestone: none → 2.0.0
status: New → Confirmed
Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

https://review.openstack.org/266144

Changed in networking-midonet:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (master)

Reviewed: https://review.openstack.org/266144
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=ac0a30e41ffb89c133f6cd2019d509f98c3f21ed
Submitter: Jenkins
Branch: master

commit ac0a30e41ffb89c133f6cd2019d509f98c3f21ed
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Jan 12 13:46:13 2016 +0900

    Correct assertion argument order

    This fixes pep8 failure. (N330)

    Closes-Bug: #1533047
    Change-Id: Ie895a1b92eb6d9a89e26ee4f096c65bc4262fdaf

Changed in networking-midonet:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.