l2gw's devstack Q_PLUGIN_EXTRA_CONF vars overwrite any user-specified valued

Bug #1600664 reported by Michael Micucci
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-l2gw
Fix Released
Undecided
Michael Micucci

Bug Description

The devstack vars Q_PLUGIN_EXTRA_CONF_PATH and Q_PLUGIN_EXTRA_CONF_FILES are meant to be used in local.conf and other settings files in order to make sure the --config-file parameters get filled out and sent properly to neutron-server start.

The Q_PLUGIN_EXTRA_CONF_FILES parameter, in particular is a bash array and can be added to in order to set up multiple files. The Q_PLUGIN_EXTRA_CONF_PATH parameter will be prepended to each of the files specified in Q_PLUGIN_EXTRA_CONF_FILES, and is almost always set to '/etc/neutron'

The settings file in networking-l2gw's devstack plugin sets the Q_PLUGIN_EXTRA_CONF_FILES parameter, which, given the flow of devstack's stack command, will actually overwrite anything the user had set in local.conf, as well as any other plugins which have set up this variable prior to networking-l2gw's settings code getting run. This has the effect of sending only the l2gw_plugin.ini to --config-file upon neutron-server start, and will cause failures if other config files were needed by the devstack user.

Instead, this value should be appended to, to preserve any user settings. Also, setting the Q_PLUGIN_EXTRA_CONF_PATH also has the unfortunate side-effect of overwriting any user preference, or anything set by other plugins. Therefore, it might actually be preferable to not set it at all, and leave it to the user to set it in the local.conf.

Changed in networking-l2gw:
assignee: nobody → Michael Micucci (micucci-t)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-l2gw (master)

Fix proposed to branch: master
Review: https://review.openstack.org/340204

Changed in networking-l2gw:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-l2gw (master)

Reviewed: https://review.openstack.org/340204
Committed: https://git.openstack.org/cgit/openstack/networking-l2gw/commit/?id=db32638df0fe34108b4bb50fb6f34266f979bc35
Submitter: Jenkins
Branch: master

commit db32638df0fe34108b4bb50fb6f34266f979bc35
Author: Michael Micucci <email address hidden>
Date: Mon Jul 11 11:32:10 2016 +0900

    Fix Q_PLUGIN_EXTRA_CONF_FILES usage

    Change Q_PLUGIN_EXTRA_CONF_FILES to append to the bash array
    rather than set (and overwrite). This will keep any values
    set previously by the user and other plugins.

    Change-Id: I2d4d103b7c0912082dc5f8d984f3800d77d2a690
    Closes-Bug: #1600664
    Signed-off-by: Michael Micucci <email address hidden>

Changed in networking-l2gw:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-l2gw (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/343826

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-l2gw (stable/mitaka)

Reviewed: https://review.openstack.org/343826
Committed: https://git.openstack.org/cgit/openstack/networking-l2gw/commit/?id=dae36b253c85e867e49f36e17d9db1bd85d8360f
Submitter: Jenkins
Branch: stable/mitaka

commit dae36b253c85e867e49f36e17d9db1bd85d8360f
Author: Michael Micucci <email address hidden>
Date: Mon Jul 11 11:32:10 2016 +0900

    Fix Q_PLUGIN_EXTRA_CONF_FILES usage

    Change Q_PLUGIN_EXTRA_CONF_FILES to append to the bash array
    rather than set (and overwrite). This will keep any values
    set previously by the user and other plugins.

    Change-Id: I2d4d103b7c0912082dc5f8d984f3800d77d2a690
    Closes-Bug: #1600664
    Signed-off-by: Michael Micucci <email address hidden>
    (cherry picked from commit db32638df0fe34108b4bb50fb6f34266f979bc35)

tags: added: in-stable-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.