Invalid RPC call prevents agent from getting device details

Bug #1852612 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-hyperv
Fix Released
Undecided
Lucian Petrut

Bug Description

The host argument used when calling "get_devices_details_list" used to be optional until Rocky. [1] added a check, validating the expected host against the retrieved bindings.

The Hyper-V agent isn't passing this host argument, preventing it from getting port details from the Neutron server, thus failing to process those ports.

[1] https://github.com/openstack/neutron/commit/5c3bf124#diff-f37e2160fa93889ab1ae5eee9fef8244R294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-hyperv (master)

Fix proposed to branch: master
Review: https://review.opendev.org/694370

Changed in networking-hyperv:
assignee: nobody → Lucian Petrut (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-hyperv (master)

Reviewed: https://review.opendev.org/694370
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=1b1ee11fb075f489d497579a3d75a8060abae15f
Submitter: Zuul
Branch: master

commit 1b1ee11fb075f489d497579a3d75a8060abae15f
Author: Lucian Petrut <email address hidden>
Date: Thu Nov 14 19:37:32 2019 +0200

    Update RPC call, allowing the agent to retrieve port info

    The host argument used when calling "get_devices_details_list" used
    to be optional until Rocky. The Hyper-V agent isn't passing this host
    argument, preventing it from getting port details from the Neutron
    server, thus failing to process those ports.

    This change updates this RPC call accordingly.

    Change-Id: Ic36d405b7163eaeb71f53a56a386bc42094d58fa
    Closes-Bug: #1852612

Changed in networking-hyperv:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-hyperv (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/694501

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-hyperv (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/694502

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-hyperv (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/694503

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-hyperv (stable/train)

Reviewed: https://review.opendev.org/694501
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=537e9aeb7841f810e49cd157295468441ecda981
Submitter: Zuul
Branch: stable/train

commit 537e9aeb7841f810e49cd157295468441ecda981
Author: Lucian Petrut <email address hidden>
Date: Thu Nov 14 19:37:32 2019 +0200

    Update RPC call, allowing the agent to retrieve port info

    The host argument used when calling "get_devices_details_list" used
    to be optional until Rocky. The Hyper-V agent isn't passing this host
    argument, preventing it from getting port details from the Neutron
    server, thus failing to process those ports.

    This change updates this RPC call accordingly.

    Change-Id: Ic36d405b7163eaeb71f53a56a386bc42094d58fa
    Closes-Bug: #1852612
    (cherry picked from commit 1b1ee11fb075f489d497579a3d75a8060abae15f)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-hyperv (stable/stein)

Reviewed: https://review.opendev.org/694502
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=dd15b0e6c4b553b7120aa06054cfce5010e7c304
Submitter: Zuul
Branch: stable/stein

commit dd15b0e6c4b553b7120aa06054cfce5010e7c304
Author: Lucian Petrut <email address hidden>
Date: Thu Nov 14 19:37:32 2019 +0200

    Update RPC call, allowing the agent to retrieve port info

    The host argument used when calling "get_devices_details_list" used
    to be optional until Rocky. The Hyper-V agent isn't passing this host
    argument, preventing it from getting port details from the Neutron
    server, thus failing to process those ports.

    This change updates this RPC call accordingly.

    Change-Id: Ic36d405b7163eaeb71f53a56a386bc42094d58fa
    Closes-Bug: #1852612
    (cherry picked from commit 1b1ee11fb075f489d497579a3d75a8060abae15f)

tags: added: in-stable-stein
tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-hyperv (stable/rocky)

Reviewed: https://review.opendev.org/694503
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=4bc34c3178e31b78df186ff82dcc5c2bd602ec59
Submitter: Zuul
Branch: stable/rocky

commit 4bc34c3178e31b78df186ff82dcc5c2bd602ec59
Author: Lucian Petrut <email address hidden>
Date: Thu Nov 14 19:37:32 2019 +0200

    Update RPC call, allowing the agent to retrieve port info

    The host argument used when calling "get_devices_details_list" used
    to be optional until Rocky. The Hyper-V agent isn't passing this host
    argument, preventing it from getting port details from the Neutron
    server, thus failing to process those ports.

    This change updates this RPC call accordingly.

    Change-Id: Ic36d405b7163eaeb71f53a56a386bc42094d58fa
    Closes-Bug: #1852612
    (cherry picked from commit 1b1ee11fb075f489d497579a3d75a8060abae15f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-hyperv 7.3.1

This issue was fixed in the openstack/networking-hyperv 7.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-hyperv 7.0.1

This issue was fixed in the openstack/networking-hyperv 7.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-hyperv 7.2.1

This issue was fixed in the openstack/networking-hyperv 7.2.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.