Issue with deleting security rules

[Alin Balutoiu]

Port security rules might contain rules that apply to any protocol.

Currently there is no checking to see if a rule
which will be deleted belongs to a security
rule that applies to all protocols.

Steps to reproduce the issue:
1. Boot a VM with default security rule allowing any protocol egress.
2. Add and delete a security rule which allows ICMP egress.

Expected output: VM should be able to send ICMP traffic since the rule that applies to any protocol is still there
Actual output: The VM is not able to send ICMP traffic anymore

[Claudiu Belu (cbelu)]

Addressed by: https://review.openstack.org/#/c/387316/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/387316
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=02e2337ac7223f97d78812846defe345372b785e
Submitter: Jenkins
Branch: master

commit 02e2337ac7223f97d78812846defe345372b785e
Author: Alin Balutoiu <email address hidden>
Date: Sun Oct 16 21:38:36 2016 +0300

    Fixes port security rules deletion

    Port security rules might contain rules that apply
    to any protocol.

    Currently there is no checking to see if a rule
    which will be deleted belongs to a security
    rule that applies to all protocols.

    This patch addresses this issue by adding a check
    to make sure the rule can be safely removed.

    Closes-Bug: #1634082
    Change-Id: Icfa7d77609394a2a7030f68c2643baf309a5de74

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/395077

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/395078

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395077
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=08eba4e73081882f590ccd2dc50faea0b8e8ea61
Submitter: Jenkins
Branch: stable/newton

commit 08eba4e73081882f590ccd2dc50faea0b8e8ea61
Author: Alin Balutoiu <email address hidden>
Date: Sun Oct 16 21:38:36 2016 +0300

    Fixes port security rules deletion

    Port security rules might contain rules that apply
    to any protocol.

    Currently there is no checking to see if a rule
    which will be deleted belongs to a security
    rule that applies to all protocols.

    This patch addresses this issue by adding a check
    to make sure the rule can be safely removed.

    Closes-Bug: #1634082
    Change-Id: Icfa7d77609394a2a7030f68c2643baf309a5de74
    (cherry picked from commit 02e2337ac7223f97d78812846defe345372b785e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395078
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=d66448b13a61d943d0305105bd366d648fa9be3b
Submitter: Jenkins
Branch: stable/mitaka

commit d66448b13a61d943d0305105bd366d648fa9be3b
Author: Alin Balutoiu <email address hidden>
Date: Sun Oct 16 21:38:36 2016 +0300

    Fixes port security rules deletion

    Port security rules might contain rules that apply
    to any protocol.

    Currently there is no checking to see if a rule
    which will be deleted belongs to a security
    rule that applies to all protocols.

    This patch addresses this issue by adding a check
    to make sure the rule can be safely removed.

    Closes-Bug: #1634082
    Change-Id: Icfa7d77609394a2a7030f68c2643baf309a5de74
    (cherry picked from commit 02e2337ac7223f97d78812846defe345372b785e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-hyperv 4.0.0 release.