Few Vm's not getting IP due to missing security group rules in scale scenarios

[Krishna Kanth]

Few Vm's are not getting IP due to missing security group rules(outbound rules and sometimes inbound dhcp allow rules in scale scenarios of 1000)

Steps to reproduce:

1. Boot 1000 vm's on a scale setup of 20 computes or more
2. Ping the VM's after boot
3. Some fail to ping as they failed to get ip due to missing outbound allow rules and some times missing inbound udp rules for dhcp ports.

Root cause: Rules are getting missed due to synchronization issues while adding and removing rules.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/328210

[Krishna Kanth (krishna-kanth-mallela)]

https://review.openstack.org/#/c/328218/ is raised on os_win repo

[Krishna Kanth (krishna-kanth-mallela)]

Please note that https://review.openstack.org/328210 and https://review.openstack.org/#/c/328218/ are required to solve this issue.
greenthread.sleep is no more required reason being:
1. currently all wmi rules are applied at one shot and port binding is much faster and reporting is not a problem. verified that there is no issue with reporting threads.
2. Also we observed that sleep results in giving away the lock when there are wmi exceptions while applying rules hence causing sync problems in scale.
3. Also this solves the problem of wmi exception file already exists while applying rule problem which is also a sync problem which https://review.openstack.org/328210 resolves.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/os-win 1.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/328210
Committed: https://git.openstack.org/cgit/openstack/networking-hyperv/commit/?id=ff663bc8f3aa136a3c6b8c32a85e76d5327bfc8b
Submitter: Jenkins
Branch: master

commit ff663bc8f3aa136a3c6b8c32a85e76d5327bfc8b
Author: krishna kanth <email address hidden>
Date: Fri Jun 10 15:08:05 2016 +0530

    Fix for VM's not getting IP due to missing SG rules

    This patch set fixes missing outbound/inbound rules due
    to missing SG rules due to synchronizatin issues while
    adding and removing rules seen on a scale environment

    Change-Id: I716f64a74add80e11e3ce7ac8641578d63eec69b
    Co-Authored-By: sonu <email address hidden>
    Co-Authored-By: ShivaKumar M <email address hidden>
    Co-Authored-By: Vinod Kumar <email address hidden>
    Closes-Bug: 1591114

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-hyperv 3.0.0.0rc1 release candidate.

[Krishna Kanth (krishna-kanth-mallela)]

Cheery-picking the changes from master to stable/mitaka for os-win repo.
https://review.openstack.org/#/c/413508/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/413519

[OpenStack Infra (hudson-openstack)]

Change abandoned by Claudiu Belu (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/413519
Reason: Patch breaks stable/mitaka, and was not updated since January. We are also approaching Mitaka EOL.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win 0.5.0 release.