Detect switch failure earlier during port creation

Bug #1476723 reported by Carol Bouchard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-cisco
Fix Released
Undecided
Carol Bouchard
Kilo
Fix Committed
Undecided
Carol Bouchard
Liberty
Fix Released
Undecided
Carol Bouchard

Bug Description

Make a call to switch during port creation. It it fails, it will prevent continual retries, prevents VM from coming up, and cleans up port data from other component data bases (ex: openvswitch).

Changed in networking-cisco:
status: New → In Progress
assignee: nobody → Carol Bouchard (caboucha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-cisco (master)

Fix proposed to branch: master
Review: https://review.openstack.org/205080

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (master)

Reviewed: https://review.openstack.org/205080
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=81a7c328276659d917c053964e8eb33408f568cc
Submitter: Jenkins
Branch: master

commit 81a7c328276659d917c053964e8eb33408f568cc
Author: Carol Bouchard <email address hidden>
Date: Thu Jul 23 10:27:38 2015 -0400

    Detect switch failure earlier during port create

    This code set performs a get call to the switch earlier during the call
    to create_port_postcommit(). This will detect if the switch is up. If
    it fails, we will no longer have persistent retries and other
    components will clean up their data bases which does not happen with
    failed calls to update_port_postcommit().

    Change-Id: Ibc8d7163f27e5c040e502b1743d805996aff6643
    Closes-bug: #1476723

Changed in networking-cisco:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-cisco (master)

Fix proposed to branch: master
Review: https://review.openstack.org/205679

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (master)

Reviewed: https://review.openstack.org/205679
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=d447a1f964b71a3d770ba2060733c21585035f48
Submitter: Jenkins
Branch: master

commit d447a1f964b71a3d770ba2060733c21585035f48
Author: Carol Bouchard <email address hidden>
Date: Fri Jul 24 15:06:10 2015 -0400

    Part II-Detect switch failure earlier-Port Create

    This changeset addresses comments received post merge.
    ref: https://review.openstack.org/#/c/205080/

    Change-Id: I070725601e2135328897fdbc84e1cde0d930aecf
    Closes-bug: #1476723

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-cisco (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/205997

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/206164

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-cisco (stable/kilo)

Change abandoned by Carol Bouchard (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/205997
Reason: Use 'git cherry-pick -x' method instead ref: https://review.openstack.org/#/c/206164/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (stable/kilo)

Reviewed: https://review.openstack.org/206164
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=87fb3d6f75f9b0ae574df17b494421126a636199
Submitter: Jenkins
Branch: stable/kilo

commit 87fb3d6f75f9b0ae574df17b494421126a636199
Author: Carol Bouchard <email address hidden>
Date: Thu Jul 23 10:27:38 2015 -0400

    Detect switch failure earlier during port create

    This code set performs a get call to the switch earlier during the call
    to create_port_postcommit(). This will detect if the switch is up. If
    it fails, we will no longer have persistent retries and other
    components will clean up their data bases which does not happen with
    failed calls to update_port_postcommit().

    Change-Id: Ibc8d7163f27e5c040e502b1743d805996aff6643
    Closes-bug: #1476723
    (cherry picked from commit 81a7c328276659d917c053964e8eb33408f568cc)

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-cisco (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/209230

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (stable/kilo)

Reviewed: https://review.openstack.org/209230
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=825cf6d1239600917f8fa545cc3745517d363838
Submitter: Jenkins
Branch: stable/kilo

commit 825cf6d1239600917f8fa545cc3745517d363838
Author: Carol Bouchard <email address hidden>
Date: Fri Jul 24 15:06:10 2015 -0400

    Part II-Detect switch failure earlier-Port Create

    This changeset addresses comments received post merge.
    ref: https://review.openstack.org/#/c/205080/

    Change-Id: I070725601e2135328897fdbc84e1cde0d930aecf
    Closes-bug: #1476723
    (cherry picked from commit d447a1f964b71a3d770ba2060733c21585035f48)

Sam Betts (sambetts)
Changed in networking-cisco:
milestone: none → 1.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-cisco (master)

Fix proposed to branch: master
Review: https://review.openstack.org/246547

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (master)
Download full text (23.9 KiB)

Reviewed: https://review.openstack.org/246547
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=7b1eb2b6d5e55563c084f60e44adc1d32706eb17
Submitter: Jenkins
Branch: master

commit d9b9a6421d7ff92e920ed21b01ebc7bf49e38bd6
Author: Sam Betts <email address hidden>
Date: Tue Sep 29 09:18:10 2015 +0100

    Set default branch for stable/kilo

    Change-Id: I31f51ff60f95639f459839f4c7d929d5ec7c458d

commit f08fb31f20c2d8cc1e6b71784cdfd9604895e16d
Author: Rich Curran <email address hidden>
Date: Thu Sep 3 13:23:52 2015 -0400

    ML2 cisco_nexus MD: VLAN not created on switch

    As described in DE588,
    "With neutron multiworkers configured, there is a potential race condition
    issue where some of the VLANs will not be configured on one or more N9k
    switches.

    /etc/neutron/neutron.conf
    -------------------------
    api_workers=3
    rpc_workers=3"

    Fix is to allow the vlan create command to be sent down to a switch
    under most event conditions. Long term fix will be to introduce a new
    column in the port binding DB table that indicates the true state of the
    entry/row.

    Closes-Bug: #1491940
    Change-Id: If1da1fcf16a450c1a4107da9970b18fc64936896
    (cherry picked from commit 0e48a16e77fc5ec5fd485a85f97f3650126fb6fe)

commit d400749e43e9d5a1fc92683b40159afce81edc95
Author: Carol Bouchard <email address hidden>
Date: Thu Sep 3 15:19:48 2015 -0400

    Create knob to prevent caching ssh connection

    Create a new initialization knob named never_cache_ssh_connection.
    This boolean is False by default allowing multiple ssh connections
    to the Nexus switch to be cached as it behaves today. When there
    are multiple neutron processes/controllers and/or non-neutron ssh(xml)
    connections, this is an issue since processes hold onto a connection
    while the Nexus devices supports a maximum of 8 sessions. As a result,
    further ssh connections will fail. In this case, the boolean should be
    set to True causing each connection to be closed when a neutron event
    is complete.

    Change-Id: I61ec303856b757dd8d9d43110fec8e7844ab7c6d
    Closes-bug: #1491108
    (cherry picked from commit 23551a4198c61e2e25a6382f27d47b0665f054b8)

commit 0050ea7f1fb3c22214d7ca49cfe641da86123e2c
Author: Carol Bouchard <email address hidden>
Date: Wed Sep 2 11:10:42 2015 -0400

    Bubble up exceptions when Nexus replay enabled

    There are several changes made surrounding this bug.

    1) When replay is enabled, we should bubble exceptions
       for received port create/update/delete post_commit
       transactions. This was suppressed earlier by
       1422738.

    2) When an exception is encountered during a
       post_commit transaction, the driver will no longer
       mark the switch state to inactive to force a replay.
       This is no longer needed since 1481856 was introduced.
       So from this point on, only the replay thread will
       determine the state of the connection to the switch.

    3) In addition to accommodating 1 & 2 above, more detail
       data verification was added to the test code.

    Change-Id: I97...

Changed in networking-cisco:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.