Reviewed: https://review.openstack.org/218710 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2c5f44e1b3bd4ed8a0b7232fd293b576cc8c1c87 Submitter: Jenkins Branch: feature/pecan commit f35d1c5c50dccbef1a2e079f967b82f0df0e22e9 Author: Adelina Tuvenie Date: Thu Aug 27 02:27:28 2015 -0700 Fixes wrong neutron Hyper-V Agent name in constants Change Id03fb147e11541be309c1cd22ce27e70fadc28b5 moved the AGENT_TYPE_HYPERV constant from common.constants to plugins.ml2.drivers.hyperv.constants but change the value of the constant from 'HyperV agent' to 'hyperv'. This patch changes the name back to 'HyperV agent' Change-Id: If74b4b2a84811e266c8b12e70bf6bfe74ed4ea21 Partial-Bug: #1487598 commit de604de334854e2eb6b4312ff57920564cbd4459 Author: OpenStack Proposal Bot Date: Sun Aug 30 01:39:06 2015 +0000 Updated from global requirements Change-Id: Ie52aa3b59784722806726e4046bd07f4a4d97328 commit f0415ac20eaf5ab4abb9bd4839bf6d04ceee85d0 Author: armando-migliaccio Date: Fri Aug 28 13:53:04 2015 -0700 Revert "Add support for unaddressed port" This implementation may expose a vulnerability where a malicious user can sieze the opportunity of a time window where a port may land unaddressed on a shared network, thus allowing him/her to suck up all the tenant traffic he/she wants....oh the shivers. This reverts commit d4c52b7f5a36a103a92bf9dcda7f371959112292. Change-Id: I7ebdaa8d3defa80eab90e460fde541a5bdd8864c commit 013fdcd2a6d45dbe4de5d6e7077e5e9b60985ef9 Author: Assaf Muller Date: Fri Aug 28 16:41:07 2015 -0400 Improve logging upon failure in iptables functional tests This will help us nail down a more accurate and efficient logstash query. Change-Id: Iee4238e358f7b056e373c7be8d6aa3202117a680 Related-Bug: #1478847 commit 622dea818d851224a43d5276a81d5ce8a6eebb76 Author: Ivar Lazzaro Date: Mon Aug 17 17:17:42 2015 -0700 handle gw_info outside of the db transaction on router creation Move the gateway interface creation outside the DB transaction to avoid lock timeout. Change-Id: I5a78d7f32e8ca912016978105221d5f34618af19 Closes-bug: 1485809 commit 5b27d290a0a95f6247fc5a0fe6da1e7d905e6b2d Author: Assaf Muller Date: Wed Aug 26 10:07:03 2015 -0400 Remove ml2 resource extension success logging This is the cause of a tremendous amount of logs, for no perceivable gain. A normal dvr run in the gate shows this debug message around 120K times, which is way too much. Closes-Bug: #1489952 Change-Id: I26fca8515d866a7cc1638d07fa33bc04479ae221 commit 8d3faf549cba2f58c872ef4121b2481e73464010 Author: huangpengtao Date: Fri Aug 28 23:20:46 2015 +0800 Replace "prt" variable by "port" the local variable prt is meaningless, and port is used popular. Change-Id: I20849102cf5b4d84433c46791b4b1e2a22dc4739 commit ee374e7a5f4dea538fcd942f5b6a42a6ebd1503f Author: ajmiller Date: Mon Aug 24 21:04:02 2015 -0700 Add optional file permission argument to replace_file() The replace_file() utility function currently sets the mode of all files it creates to 0o644. This is not appropriate for all files. This patch adds an optional "file_mode" argument to the function. Change-Id: I9744abde10b95fadef6e74c55332d041e5372071 Partial-Bug: 1488320 commit 9731240e7d7aeef939e27ca6511bc9453d4c013f Author: vikram.choudhary Date: Fri Aug 28 13:22:42 2015 +0530 Add lieutenants contact for networking-onos Change-Id: If8cd40eb49acddfce3d951b41aa3b17f8460ec72 commit e5c0cfeb1c34a28480f72987c1db42c9548edb67 Author: vikram.choudhary Date: Fri Aug 28 13:09:09 2015 +0530 Adding networking-onos to sub_projects document Change-Id: I5b09373cc98e8727b349835aaf26dff64c0be9a1 commit c1599337ab8b3ae77ee431f8282673cb0720717d Author: gong yong sheng Date: Wed Aug 26 17:20:25 2015 +0800 Base on SqlTestCase to init db tables correctly Change-Id: I6c6503d4b8b0677cb31fa54185b1aacda68f7b53 Closes-bug: #1488868 commit ce3fb9065efacdc9e8503f5ba630c4ba1b85855f Author: Miguel Angel Ajo Date: Fri Aug 28 07:49:28 2015 +0200 Stops patching an object method which could be gone at cleanup Stop patching the qos plugin 'notification_driver_manager' method and instead substitute for a mock since it's destroyed and reloaded on every test run. Closes-Bug: #1489716 Change-Id: I0e84b19bba92a7cbef837de7994a605a78936250 commit a6c8d60e5e5ad41096dcf1f258b2983d2c6beb77 Author: Hirofumi Ichihara Date: Wed Aug 26 14:47:36 2015 +0900 Add enable_new_agents to neutron server Neutron doesn't have a way to test a newly added network node by deploying test resource before any customer resource on the node is deployed. Nova and Cinder has the setting of “enable_new_services” in each conf to disable the initial service status to achieve this. This proposal adds enable_new_agents config. DocImpact Change-Id: Ie0d0b2dd4d95de95f3839d1c35f24b708e893801 Implements: blueprint enable-new-agents Related-Bug: 1472076 commit 5920835a58ae9310a25843bfdb552519c06f4f6f Author: Assaf Muller Date: Thu Aug 27 19:00:56 2015 -0400 Document prefix delegation testing issues Change-Id: I06071c7497dcd4654c2b03a9b66120b919feb8dc Related-Bug: #1489650 commit a158d62f30d056ac2ab6bb30efd7fafc2b7a3153 Author: Assaf Muller Date: Thu Aug 27 17:44:50 2015 -0400 Fix Prefix delegation router deletion key error Change-Id: I1b7008bc6a9dd7d23a651023fd540eec3e46f072 Closes-Bug: #1489576 commit 7b7c15ba4e2f0646000ecca2acecb98081268772 Author: Aaron Rosen Date: Tue May 5 14:35:08 2015 -0700 Add Geneve type driver support to ML2 More information about Geneve protocol can be found here: https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf Following configuration variables were added: [ml2_type_geneve] vni_ranges - Comma-separated list of : tuples enumerating ranges of Geneve VNI IDs that are available for tenant network allocation max_header_size - Geneve encapsulation header size is dynamic, this value is used to calculate the maximum MTU for the driver this is the sum of the sizes of the outer ETH + IP + UDP + GENEVE header sizes DocImpact Change-Id: I8c29a1c1a7c79e02c26ac9e2ad2645d30dfbeefc Closes-Bug: #1461069 commit 177f738ffe1ee6acb3ecd31f7e147d7608d2ad9e Author: Swaminathan Vasudevan Date: Wed Aug 26 11:39:24 2015 -0700 Fix DVR log strings in agent This patch fixes a couple of DVR log strings that was not reporting the right information. Change-Id: Ic6919d00214a001ecdaa709c4e0f01a84adab2c7 commit c4989982016ac8bd6fb319011ace1d3530a8d78d Author: Kyle Mestery Date: Thu Aug 27 14:01:57 2015 +0000 devref: Add sub-project release notes Add some notes on the release process we'll utilize for sub-projects under the Neutron stadium. Change-Id: Ib7bce1e3ced959bc7931bd2ecbfe8effba5ed9c0 Signed-off-by: Kyle Mestery commit bdfe8dcf42275f22afa457fccf188d2e3352e4a7 Author: Mohammad Banikazemi Date: Thu Aug 27 09:10:33 2015 -0400 Removing the SDN-VE monolithic plugin As the SDN-VE monolithic plugin is no longer in use by anyone, this is to remove the code from the Neutron source tree. DocImpact Change-Id: I8def7fc2e92f967785b9ab05f8496de641e8f866 commit 4d1febcb16c47707fe2eadae670f2ada8c0408df Author: AKamyshnikova Date: Thu Aug 27 10:53:26 2015 +0300 Update template for ModelMigrationSync test Add some more useful details in template and update contribute.rst with link for template. Related-bug: #1470678 Change-Id: I8785129ba85236220650b2ba7ec0bc605847b1b7 commit a584f4b42d5a93959d23ef03d06f6acb3eb62c00 Author: Assaf Muller Date: Wed Aug 26 16:27:37 2015 -0400 Fix py34 No sql_connection parameter is established error Tests that were using DB connections that did not happen to import config.py were not setting the DB connection string. The base test class now sets the string instead of relying on an import to happen. Change-Id: I7aceffff427d6526c0059dd88f67a58783292abd Closes-Bug: #1489098 commit 76292856308be2904f10125665c88251a2f38b69 Author: armando-migliaccio Date: Wed Aug 26 14:01:04 2015 -0700 Switch to using os-testr's copy of subunit2html Since Ib65c41fc5f137eedb21fccfcee1e96b6990ae30d removes the local jenkins slave script copy of subunit2html we must start using the version packaged in os-testr. Change-Id: I7b7908986eb503a0d2ae8e2365b34516e6e68f92 commit b68236d32b4afca162f02052d25fa9030d530192 Author: Clark Boylan Date: Tue Aug 25 10:58:57 2015 -0700 Run py34 tests with testr This doesn't use os-testr but it results in html reports built from the subunit logs. A note from amuller: tox -e py27 uses ostestr. The primary difference between testr and ostestr (For my money) is that ostestr spits out progression. After a conversation with mtreinish (The author of ostestr) it doesn't seem to be possible to use tox with ostestr for our py34 tests because we use a long regex that is split on newlines. ostestr supports the --regex flag as such (regex_a|regex_b), however it's not possible to use that with newlines and to play nice with tox. Since I think that we do want to use ostestr (Just like the py27 venv), I'll work with mtreinish to introduce a white list regex file in to ostestr. The file will be maintained in the repo and passed in to ostestr via tox. Change-Id: I1f1030cca4fd356e468d15126a730725ac9c099c commit 2cb5e831b8337fd620d9fdc13aa190c1192b044f Author: Carl Baldwin Date: Tue Aug 25 20:51:16 2015 +0000 Make a couple of methods private I was just going over this class trying to understand what methods really are used outside of the class. I found that these two are not. I thought I'd submit a quick patch to mark them "private". Change-Id: Id91907996631b670e23a506e0a1feae4518e42ba commit 305dcb1dbccfcaff92c39bfb5763d5b9660e91cb Author: John Davidge Date: Thu Aug 13 18:51:57 2015 +0100 Add IPv6 Prefix Delegation compatibility to ipam_pluggable_backend This patch makes the necessary changes for IPv6 PD to function when pluggable ipam is enabled with the reference driver. Includes a unit test for this functionality. Change-Id: I4227cc08fdd62922632629c424dbeb542a48a67f Partially-Implements: blueprint ipv6-prefix-delegation commit 9a4f2e51a5b8f6f96535ee6968e5a209dd518654 Author: Oleg Bondarev Date: Tue Aug 18 12:48:41 2015 +0300 Validate router admin_state_up on upgrade to distributed For proper upgrade of centralized router to distributed the router needs to be disabled (admin_state_up set to false). The patch adds corresponding validation. Closes-Bug: #1428713 Change-Id: Idf25db0936eee892ecb169a8678ba7f0a2cfceb6 commit b939672d6bc84e7fb9c27857ee5e641f7c18aeb1 Author: Brian Haley Date: Tue Aug 25 09:42:12 2015 -0400 Fix AttributeError in _clean_updated_sg_member_conntrack_entries() The conntrack work that recently merged introduced a bug due to an incorrect 'if' statement, it was only detecting when one variable was not set instead of both, which can cause an exception. This is currently causing jenkins failures with a number of other changes. Introduced in Change Id Ibfd2d6a11aa970ea9e5009f4c4b858544d8b7463 Change-Id: I2519fdceefc9255c21d8226cdeffec40a7d444f6 Closes-bug: #1488284 commit 97452d1e30e46f6b17c6c5c03535e2d8f56fb32d Author: Fawad Khaliq Date: Mon Aug 10 07:13:26 2015 -0700 PLUMgrid plugin decomposition part II As part of the phase II plugin decomposition [1], this change moves PLUMgrid plugin to its new home: networking-plumgrid [2] [1] http://docs.openstack.org/developer/neutron/devref/contribute.html [2] https://github.com/openstack/networking-plumgrid Partial-Implements: blueprint core-vendor-decomposition Change-Id: Ifc6bbb4fe45ee9b8d298ff171ee43c0da37d075c Signed-off-by: Fawad Khaliq commit 91852a7f529d276052e898480307c727be20fab3 Author: salvatore Date: Fri Aug 21 10:10:56 2015 +0200 Quota enforcement: remove locks on _dirty_tenants This lock was used to avoid errors due to list contents changing during iteration, but is causing issues with pymysql. This patch proposes an alternative approach which makes the use of a lock unnecessary. With this change a copy of the dirty_tenants set is made before setting the dirty bit on resources, and then the mark_dirty routine operates on this copy. This still guaranteses operations correctness, as all the tenants that should be marked dirty are marked dirty before the completion of the relevant API request. Related-Blueprint: better-quotas Change-Id: Ib39e7089889d3f906bdc025c843128a1fa3e8797 commit 4b329c345c7820ff12bf25a91228cdfbf99500df Author: John Davidge Date: Wed Jun 24 14:52:13 2015 +0100 L3 agent changes and reference implementation for IPv6 PD This patch adds the common framework to be used by specific implementations of the DHCPv6 protocol for Prefix Delegation. It also includes a reference implementation based on the Dibbler DHCPv6 client. Dibbler version 1.0.1 or greater is required. Sanity tests are included to verify the installed version. A patch for admin/user documentation is up for review here: https://review.openstack.org/#/c/178739 Video guides for configuring and using this feature are available on YouTube: https://www.youtube.com/watch?v=wI830s881HQ https://www.youtube.com/watch?v=zfsFyS01Fn0 Co-Authored-By: Baodong (Robert) Li Co-Authored-By: Sam Betts Change-Id: Id94acbbe96c717f68f318b2d715dd9cb9cc7fe4f Implements: blueprint ipv6-prefix-delegation commit cfa8f537710d8d7ef407b4194295f15ed03b3fa0 Author: Akihiro Motoki Date: Mon Aug 24 10:12:52 2015 +0900 Decomposition phase2 of NEC plugin As part of plugin decomposition effort, NEC plugin is removed from the main neutron repo and moved to networking-nec repo. Related blueprint core-vendor-decomposition Closes-Bug: #1487929 Change-Id: I2ef7ec241f061516b72c4df9f959af027c4c366c commit 255ef141460e730bc60ab9ad96f830fe16b9422f Author: armando-migliaccio Date: Mon Aug 24 20:56:08 2015 -0700 Allow py34 to run tests individually Prior to this patch, when I do: tox -epy34 the argument is ignored and all whitelisted tests are executed. This is not in line with the other testenv's. This patch ensures that posargs are processed if available, and that we fall back on the lot of tests when not specified. Change-Id: I176d7bba690b1c7e0c64d11528d9c851472b503b commit 3d28fc0bfcf7f8c1fa11f83b6f4f35d82ee2eafd Author: Miguel Lavalle Date: Sun Jul 12 18:00:50 2015 -0500 Add dns_label processing for Ports Functionallity is added to enable users to specify a dns_label field during port creation and update. This dns_label field will be used for DNS resolution of the hostname in dnsmasq and also will be used when Neutron can integrate with external DNS systems. Change-Id: I6beab336dfd9b70b1af6e975939c602047faa651 DocImpact APIImpact Closes-Bug: #1459030 Implements: blueprint internal-dns-resolution commit e394b04e5c339e08435e9635a58c6d4689b6545b Author: Cedric Brandily Date: Fri Aug 21 22:48:42 2015 +0200 Move in-tree vendor AGENT_TYPE_* constants AGENT_TYPE_* constants[1] define all agent types BUT vendor ones are only used by in-tree vendor code. This changes moves in-tree AGENT_TYPE_* constants[2] to vendor modules to ensure they will be removed from neutron code on decomposition. [1] in neutron.common.constants [2] AGENT_TYPE_HYPERV/MLNX/SDNVE Change-Id: Id03fb147e11541be309c1cd22ce27e70fadc28b5 Partial-Bug: #1487598 commit 6830c9fd4ed759575e70b0f777aa3ce3b952f83b Author: Ihar Hrachyshka Date: Mon Aug 24 19:29:46 2015 +0200 devref: added guidelines on how to maintain sub-projects I was involved lately in several boring attempts to fix broken sub-project requirements and stable branches, and I think part of the problem here is that we don't communicate our expectations to sub-projects clear enough. This is a first attempt to set brief and clear guidelines to sub-project maintainers on how to maintain their repositories without much hassle. Change-Id: I9180ee530f96a885b5667e050d141ce0ab52a8ce commit 423392564e6c135be4cf6270659065b2c8b08b37 Author: Matthew Treinish Date: Mon Aug 24 13:28:22 2015 -0400 Stop logging STDOUT and STDERR on every shell out Sometimes you can log too much. For example, logging a complete iptables dump on every security group operation, OMG TMI. Doing this during DSVM run results in a log file >7M compressed. To mitigate this issue this commit switches the execute method to only log the command and it's exit code on the success case. If there is a failure the entire stdin, stdout and stderr are logged. Change-Id: Iaf17297306dc752e666612033c805a528f078f2f commit 05fbc0415edaa285b2c8b2573a72d2bd55925d81 Author: Christian Berendt Date: Mon Aug 24 09:07:35 2015 +0200 Update the URLs to the Cloud Admin Guide The Cloud Admin Guide was converted to RST and the URLs changed. Also add the Networking Guide to the README file. Change-Id: I485254db6d2264aaa80e4f7146cfc61c56b27b27 commit ccf73311c862f4f62a5012b6fcb4459b2d2bef17 Author: Ryan Moats Date: Mon Aug 24 08:49:09 2015 -0500 Remove redundant logging statements from RootWrapDaemonHelper create_process and execute_rootwrap_daemon both current log the command they are about to run. Remove these statements as redundant (the log message showing the command's result includes the command itself) Signed-off-by: Ryan Moats Change-Id: I8bdea7212f8a32a3b6b0b47c5b824ac1c561d83f commit 545df90f0af1418e9b53dd933e5bb916c4cc9046 Author: Ryan Moats Date: Fri Aug 21 09:16:52 2015 -0500 Rationalize neutron logs to help in troubleshooting router issues Currently the neutron logs are not very useful for troubleshooting router issues - this patch adds additional logging statements to help the triage process. Change-Id: I014e0119205d4a947a1be142aeeb29940c4de3bd Signed-off-by: Ryan Moats commit 4bbd854740abee8bedaa2a1156961690613e24dd Author: Oleg Bondarev Date: Mon Aug 24 11:29:25 2015 +0300 Move db agent schedulers test to a more appropriate place Current placing is confusing as in fact the tests have little to do with ml2 and openvswitch. This was triggered by discussion on https://review.openstack.org/199514 Next step should be to separate dhcp and l3 schedulers tests. Change-Id: Ie05874fdc1c3070ed319e8f624c8217c5c0bb646 commit d74c57a1be28f6a3fd9dad77ee2d6da136c4554b Author: rossella Date: Fri Aug 21 12:52:11 2015 +0000 OVS agent don't hard code tunnel bridge name In setup_tunnel_br the name of the tunnel bridge should not be hard coded Change-Id: I7aebc27eb8d9dd347b34e31f7810fbffd6edf49a Closes-bug: #1487435 commit 2ef027ed39e0398f2dbdd63b09a6a0279d6bc6c4 Author: Kevin Benton Date: Mon Aug 24 03:13:14 2015 -0700 Make models_v2 explicitly import rbac_db_models The Network model was implicitly relying on a core plugin to import the db_base_plugin_v2 module which would import the rbac model module so "NetworkRBAC" would be defined by the time something would query the DB. However, this isn't the case for scripts or agents that are importing models_v2 and trying to query the DB directly so they will now break with an sqlaclhemy error about a missing model. This patch makes models_v2 import the rbac_db_models module directly so the model will always be defined. This would have resulted in a circular import because the rbac_db_models module required the HasId and HasTenant classes in models_v2. So this patch also moves these helper classes into model_base. Change-Id: I338ce1c0ba55647e6410a63f937737f75a63057d Closes-Bug: #1488032 commit df31ac1f11b8139d8b930d05565003ba74150e82 Author: Miguel Angel Ajo Date: Wed Aug 19 15:15:21 2015 +0200 Make NeutronDbObjectDuplicateEntry exception more verbose NeutronObjectDuplicateEntry is an exception derived from Conflict, which is mapped to HTTPConflict. When such exception is thrown during an API layer call, we will provide more detail to the caller about what was exactly duplicated, and for which fields, the information is extracted from the DB exception. NeutronObjectDuplicateEntry is renamed into NeutronDbObjectDuplicate to make clear it is for handling db duplicate exceptions, in the future we could generalize to a base NeutronObjectDuplicate class if we need separate handling for other object backings (mem, keystore, etc). Change-Id: I6ec5883b3456ebc842f3f7bffd8cc924293f5766 commit 20459979e0b37ad74190d77cb9b7574b012f8ac4 Author: gong yong sheng Date: Fri Aug 21 14:51:45 2015 +0800 Add empty policy rule to get_rule_type action Without this empty policy rule, get_rule_type will use default, which will demand admin role or tenant_id in object. but rule_type has no tenant_id in its body. Change-Id: I92b1222fbcdc2efd13ca6f586cfefefc55b59189 Closes-bug: #1487324 commit 4d5146833b4d79502c6745919113fb13658d2a82 Author: YAMAMOTO Takashi Date: Mon Aug 24 17:41:08 2015 +0900 test_ovs_neutron_agent: Fix test_cleanup_stale_flows_iter_0 - Mock the correct variable - Ensure that non-stale flows are not removed Change-Id: I68b360d4d3cdaaa9077244a5783418456af5c48c commit 09b09de925a69bdb4f83b3709b83634f98d8d99f Author: Marga Millet Date: Wed Aug 12 03:49:09 2015 -0700 Support dhcp metadata service for all networks Vendors implementing Neutron L3 API in their devices may not be able to provide metadata server access via the Neutron router. In such cases we want to allow the metadata service as done for non-isolated networks segments. DocImpact Change-Id: I5f6ee9788717c3d4f1f2e2a4b9734fdd8dd92b40 Closes-Bug:#1483939 commit 5dbdf1102602a2fbb83acc2644dc737ac420fae3 Author: Cedric Brandily Date: Sat Aug 22 11:49:24 2015 +0200 Move docstring to FakeMachineBase This change moves FakeMachine docstring to FakeMachineBase because it is valid for all FakeMachineBase subclasses. Change-Id: Ic30098f7d84dd3a5d6c5f7ff675d3f6e7b0a4cae commit 373141b0d33272bfeb86f429077b2aa131f6fa2e Author: John Davidge Date: Fri Aug 21 19:07:57 2015 +0100 Update rootwrap.conf to add /usr/local/sbin This update will allow for local executables that require root privileges, such as dibbler-client for IPv6 Prefix Delegation. Change-Id: Id7aebb50e60b1cc64c113be63c599387be5f1765 commit 6334cac7c83dc53d20a91315eb3e75142c519fce Author: Vlad Gridin Date: Thu Aug 20 16:15:03 2015 +0200 Remove the ML2 Nuage driver code This changeset removes ML2 Nuage driver vendor code, currently present in neutron core to vendor repo. Closes-bug: #1486662 Related-Blueprint: core-vendor-decomposition Change-Id: I6388e91ba56aa6b8f16c723f7d07234d262b6c16 commit 1787c85acfa800e88335d8336fbaadecece80fe2 Author: Ann Kamyshnikova Date: Fri Aug 14 15:25:36 2015 +0300 Template for ModelMigrationTest for external repos This change adds tempate for ModelMigrationTest which should be implemented in all driver/plugin repositoties that were split out from Neutron. Also split DRIVER_TABLES into separate lists for each driver. This is needed for easier implementation of test. Closes-bug:#1470678 Change-Id: I02100d15d71519014db7c8894bd2cb36c86d32a0 commit 16142d8d372482182564a416aa66d10133571ff2 Author: Cyril Roelandt Date: Fri Aug 21 11:56:42 2015 +0200 Python 3: do not do "assertFalse(filter(...))" This does not work in Python 3 since filter does not return a list. Fix this by replacing it with a list comprehension. Blueprint: neutron-python3 Change-Id: I59a63f7adedaf2217aa8fc9aae63045b4e620361 commit e6708f6d47dc0bfdde3c9ced5066857c695ff717 Author: Neil Jerram Date: Mon Jul 27 14:43:18 2015 +0100 ip_lib: support creating Linux dummy interface This is for use by a DHCP agent interface driver in the networking-calico project. networking-calico connects VMs without using bridging, so it needs an unbridged DHCP port interface with which it can associate the DHCP subnet prefix, and the Linux dummy interface (in conjunction with use of Dnsmasq's --bridge-interface feature) is suitable for that purpose. Partial-Bug: #1486649 Change-Id: I5485c187bc44bac3c2942c4fc9e5a502912a81a2 commit 053bfc5a4f03c620edf4d17a9bd7cebe001c142f Author: Ann Kamyshnikova Date: Fri Aug 21 15:13:25 2015 +0300 Graceful OVS restart for DVR Graceful OVS restart that was intoduced in I95070d8218859d4fff1d572c1792cdf6019dd7ea missed that flows are also dropped in setup_dvr_flows_on_integ_br. Related-bug: #1383674 Change-Id: I7b24a159962af7b58c096a1b2766e2169e9f8aed commit 43d62c62a8525a1f2aa67b0ee201c09409fefa9a Author: Neil Jerram Date: Thu Jul 23 18:17:12 2015 +0100 DHCP agent: clarify logic of setup_dhcp_port When the DHCP port already exists, the code for finding it is unhelpfully mixed up with the code for updating its subnet IDs and fixed IP addresses. Clarify that area by splitting setup_dhcp_port into 3 subroutines, for each of the existing, reserved and new port cases. Related-Bug: #1486649 Change-Id: I2a537560dc7a37299f4b7b4cd508d9309bbe1209 commit 63b03362821deadc0e65cce54b11cb7d4c2262d2 Author: Sean Mooney Date: Fri Jun 26 10:48:26 2015 +0100 Add config option to specify ovs datapath. This change introduces a new datapath_type parameter to allow specification of the ovs datapath to be used. This change introduces new functional and unit tests. DocImpact Change-Id: I929d8d15fc6cfdb799c53ef0f3722f4ed5c1096d Partial-Bug: #1469871 commit 6f76ca6b908fc2fc256abee618e99670d461e9b0 Author: Cyril Roelandt Date: Fri Aug 21 12:19:30 2015 +0200 Python 3: fix test_ovs_tunnel In Python 3, __bool__ should be used instead of __nonzero__. Change-Id: I04b688a6ac079a161bd888c53b8b98b574171ea9 Blueprint: neutron-python3 commit 4af5ee82e39b3cf6f14e6ae4f14b566c83ac8ed4 Author: Cyril Roelandt Date: Fri Aug 21 11:20:27 2015 +0200 Python 3: use __code__ instead of func_code The former works with both Python 2 and 3. Change-Id: Id2f6d313bf90777e02b20b7f6f4fb99e79e85aff Blueprint: neutron-python3 commit 9750ab79c67f0f5b24cbbb9b7f2c499d4b911283 Author: sridhargaddam Date: Mon Aug 3 11:16:37 2015 +0000 IPv6 display suitable message when MTU is invalid on iface IPv6 protocol requires a minimum MTU of 1280 bytes on the interface to configure an IPv6 address to the interface. This patch logs an appropriate error message and exits the agent if ipv6 is enabled and network_device_mtu is less than the minimum value. DocImpact Closes-Bug: #1475015 Change-Id: I13666de4e6f5f6775ad26342e513c3c17a003b8e commit f4069c02837a70e7bb0d85ec432a4c73372c6cd5 Author: Miguel Angel Ajo Date: Fri Aug 21 07:42:22 2015 +0200 Update oslo messaging configuration section for fullstack rabbit_virtual_host, rabbit_hosts, rabbit_userid, and rabbit_password for oslo_messaging are now deprecated in the DEFAULT config section. Those settings should be provided under the oslo_messaging_rabbit section now. Closes-Bug: 1487322 Change-Id: I12d560aefceeadb03f7a4ee1e4e2f920b2cf57f2 commit 4a0a8ac58df1e0e03f8f55ba9d9b942324c2b596 Author: OpenStack Proposal Bot Date: Fri Aug 21 06:08:23 2015 +0000 Imported Translations from Transifex For more information about this automatic import see: https://wiki.openstack.org/wiki/Translations/Infrastructure Change-Id: Ie7eece283fcc43f872e28b72bac9b2f92913b84c commit 6063e70927ed436772c602ce0cf26d5d24486fbd Author: Moshe Levi Date: Tue Aug 18 17:03:01 2015 +0300 QoS: fix get bandwidth limit rules to filter them per policy add qos_policy_id as filter before calling QosBandwidthLimitRule.get_objects to get the bw rule(s) which attached to that policy. Closes-Bug: #1486053 Change-Id: Ie316cbe48c94f113699b09d9784115a3b0ade32f commit 4595899f7f2b3774dc2dac2f8dd1a085b1e7973d Author: Kevin Benton Date: Tue Jun 16 23:43:59 2015 -0700 Neutron RBAC API and network support This adds the new API endpoint to create, update, and delete role-based access control entries. These entries enable tenants to grant access to other tenants to perform an action on an object they do not own. This was previously done using a single 'shared' flag; however, this was too coarse because an object would either be private to a tenant or it would be shared with every tenant. In addition to introducing the API, this patch also adds support to for the new entries in Neutron networks. This means tenants can now share their networks with specific tenants as long as they know the tenant ID. This feature is backwards-compatible with the previous 'shared' attribute in the API. So if a deployer doesn't want this new feature enabled, all of the RBAC operations can be blocked in policy.json and networks can still be globally shared in the legacy manner. Even though this feature is referred to as role-based access control, this first version only supports sharing networks with specific tenant IDs because Neutron currently doesn't have integration with Keystone to handle changes in a tenant's roles/groups/etc. DocImpact APIImpact Change-Id: Ib90e2a931df068f417faf26e9c3780dc3c468867 Partially-Implements: blueprint rbac-networks commit 7ea4eb6c760af72c1937f3857fa524206ecf639d Author: Liang Bo Date: Thu Aug 20 14:24:46 2015 +0800 Fixed broken link in neutron-server's documents The neutron-server document contains a link (http://neutron.openstack.org) which is not exist anymore. This patch updates the link to neutron's doc site and wiki page. Change-Id: I9d137ed9c877fc1a12590bd743fac67d06711f7f Closes-Bug: #1486848 commit e36d62b8e4b9e2fc06e93c26a92dc5ad7f0c3035 Author: Salvatore Orlando Date: Thu Aug 20 15:33:27 2015 -0700 Used namedtuple for ReservationInfo The code already uses a namedtuple for ResourceUsageInfo and it is a nonsense to not use it for ReservationInfo. Related-Blueprint: bp/better-quotas Change-Id: I99666ac865fbdeef2d84353eff49d60b6d87fddc commit 86476becd884a0f238354335bc87e5209d67c94f Author: Cedric Brandily Date: Wed Aug 19 02:02:17 2015 +0200 Move in-tree vendor VIF_TYPE_* constants VIF_TYPE_* constants[1] defines all vif types BUT vendor ones are only used by in-tree/out-of-tree vendor code. This changes moves in-tree VIF_TYPE_* constants[2] to vendor modules to ensure they will be removed from neutron code on decomposition. [1] in neutron.extensions.portbindings [2] VIF_TYPE_HYPERV/IB_HOSTDEV/HW_WEB/VROUTER Change-Id: Iee73426221d693689ba24d2ce2660bb7351f02fc Partial-Bug: #1486279 commit e8303ce77c27391213948573108be02a72c34027 Author: Cedric Brandily Date: Tue Aug 18 00:17:34 2015 +0200 Remove VIF_TYPES constant VIF_TYPES[1] lists all vif types including out-of-tree ones BUT was only used by out-of-tree bigswitch code: dependent change defined VIF_TYPES in bigswitch repo in order to allow VIF_TYPES removal from neutron code. [1] in neutron.extensions.portbindings Closes-Bug: #1486277 Related-Bug: #1486279 Depends-On: I79d0af975bb62a2ccea87eda5cf43f3f064b5078 Change-Id: I39fc344361c21332b947f21f157d4f2a27caad47 commit 01c0466d74a4c1e50d53f9215b95aa3db62760c9 Author: Ihar Hrachyshka Date: Tue Aug 18 16:57:44 2015 +0200 Added initial devstack plugin For now it only supports q-qos service that is used to configure QoS service plugin. It also adds ability to enable l2 agent extensions. To check that it works, I am enabling QoS tests back for API job. Partially-Implements: blueprint quantum-qos-api Change-Id: I19e4fe0cf5ecc55397628017631c3ff6718ce36f commit 7b960af9b0ff44ed0e2a7bcfa7c40200552bbc6b Author: Miguel Angel Ajo Date: Thu Aug 20 15:57:19 2015 +0200 Fix qos api-tests after policy changes The policy.json update in change Ide1cd30979f99612fe89dddf3dc0e029d3f4d34a breaks the qos api-tests due to actions which the default policy won't allow, like qos rules or policies creation by non-admins. We removed test_rule_association_nonshared_policy which is not possible with the default policy.json in favor of test_policy_create_forbidden_for_regular_tenants. This commit unblocks the qos api-test re-enablement. Partially-Implements: blueprint quantum-qos-api Change-Id: Ib77412bd95ad5b65ad0f6964d9809b5f707847f5 commit 99fd239ba679d16b73684fbe0dbe31a2e472cba7 Author: Jakub Libosvar Date: Thu Aug 20 16:02:11 2015 +0000 fullstack: use migration scripts to create db schema Previously, we used create_all() based on models. We don't use create_all() in production code and there is no guarantee models and scripts are in sync even though we have a good functional test that validates that. There are still pieces that can't be compared by alembic. Change-Id: I72fa67811f0763298416e6e084a8b9b86619795b Closes-Bug: 1486528 commit b6fd5b9613203819d24a452df982a76c5e7d1daf Author: John Schwarz Date: Thu Aug 20 17:05:02 2015 +0300 Only validate local_ip if using tunneling Change I4b4527c28d0738890e33b343c9e17941e780bc24 introduced a new validation to make sure that local_ip holds a valid IP that is present in one of the interfaces on the machine. However, this test is not relevant if tunneling is not enabled, since the value is ignored anyway. This patch changes validate_local_ip to not check local_ip in case tunneling is not enabled (if no value was put in the 'tunnel_types' option). Change-Id: I07119341076573a4226b5ad998bdff09c021ae30 Closes-Bug: #1487053 Related-Bug: #1408603 commit 20df8ce45f14d91633d46e08d5b28cd0006124ef Author: Jakub Libosvar Date: Tue Aug 18 13:42:37 2015 +0000 qos: Delete bw limit rule when policy is deleted We need to add ON DELETE CASCADE to qos_policy_id on bw limit rule table in order to delete policy successfully. There is a migration script that creates db scheme with correct foreign key constraint but we miss this in models. Currently, we have a functional test that guarantees parity between migration scripts and models but we don't have guaranteed foreign keys parity due to alembic bug [1]. https://bitbucket.org/zzzeek/alembic/issues/317 Change-Id: I06fa32dd11a5a52a80ae5a7952f8b32511c3f39d Closes-Bug: 1485926 commit 09852988d131bdd61e5685541fd2cec1e0e7b73d Author: Salvatore Orlando Date: Wed Aug 19 06:10:08 2015 -0700 Do not query reservations table when counting resources Reservations are temporarily disabled, and therefore querying them is pointless, and potentially harmful. Change-Id: Iab1d0ffdc54cb5bd06a0d4fbd4eb095ac4b754b8 Related-Bug: #1486134 commit d4c52b7f5a36a103a92bf9dcda7f371959112292 Author: Yalei Wang Date: Fri Aug 7 22:43:30 2015 +0800 Add support for unaddressed port Neutron could create a port without the IP address when the network doesn't have a subnet. In this case, neutron will have no L3 knowledgee and we need remove the L3 filter on it but reserve the L2 filter if there is. This patch will make L2 agent verify the fixed_ips before converting the security-group-rules into firewall rules, L3 rules in it will be removed. And filter like arp-spoofing will be disabled for this port. Partially Implements: blueprint vm-without-l3-address Change-Id: I5cd1fdfa13a7e57258be7251768eaa8ba64d486e commit fad17a2d8449f8a364f40896ee0efe8248dbffd3 Author: Jakub Libosvar Date: Thu Aug 20 12:33:59 2015 +0000 Sync FK constraints in db models with migration scripts We do have a functional test that compares Neutron's db models with migration scripts. The comparison is based on alembic library that had a bug which is gonna be solved in the next release [1]. Once we start using newer alembic, functional test mentioned above will start failing due to models and scripts are not in sync. This patch adds needed constraints discovered by running functional test locally with dev version of alembic. Note: There is already a patch [2] that fixes QoS. [1] https://bitbucket.org/zzzeek/alembic/issues/317 [2] https://review.openstack.org/#/c/214215/ Change-Id: I0d0bddb05f543365d09e592bd81759534de49367 Closes-Bug: 1486936 commit 7aa3b2eace75f846249595bba5d6d6fdd571c372 Author: John Schwarz Date: Sun Aug 9 17:00:57 2015 +0300 Add EnvironmentDescription, pass it down * The EnvironmentDescription class describes an entire fullstack environment (as opposed to the currently implemented host-only descriptions). This will allow future patches to signify that a test should set up an environment that supports tunneling, l2pop, QoS and more. * Now, most fullstack fixtures (config and process ones, at least), expect both the EnvironmentDescription for the current test and the HostDescription for the 'host' the config/process is on. This allows for easier and most robust future changes, as now adding a new parameter to one of the description objects doesn't mean adding that argument to a number of other objects which are using it. * Changed HostDescription's default argument of l3_agent to False, since adding new configurations and defualting them to True forces the author to go through ALL the tests and explicitly turn them on/off. However, defaulting new configurations to False only requires explicitly turning them on, which we ought to do anyway. Change-Id: Ib2f12016ba4371bfda76c82e11d0794acc759955 commit af7fb6c9da0b7e4ae75e02c138f1542b6db02301 Author: Ihar Hrachyshka Date: Thu Aug 20 13:01:46 2015 +0200 Dropped release name from migration branch labels Since the plan is to attach first Mitaka scripts to Liberty branches with down_revision, and since labels are inherited from all other revisions in the chain, using release names in branch labels would mean that the following commands would be valid: neutron-db-manage upgrade liberty_expand@ neutron-db-manage upgrade mitaka_expand@ which may be confusing to users. So let's drop release names from branch labels and use expand@head and contract@head to access latest migrations. Change-Id: Id524d7673ad248c831f6dbb3a6f2f3c50094acae Partially-Implements: blueprint online-schema-migrations commit f36d03f70bfaab09568ca871e00c4bb2e42577d8 Author: Ann Kamyshnikova Date: Thu Aug 20 11:27:39 2015 +0300 Split DRIVER_TABLES in external.py Split DRIVER_TABLES into separate lists for each driver. This is needed for easier implementation of ModelMigrationSyncTest in driver/plugin repositoties that were split out from Neutron. Related-bug: #1470678 Change-Id: Id4558f2230f42377be1dd4f319a2c97122d1fa9d commit 09cad21208ca1745d2859aabeb43c5b028f227b6 Author: Oleg Bondarev Date: Thu Aug 20 12:02:55 2015 +0300 DVR: make sure snat portion is always scheduled when needed commit 236e408272bcb9b8e957524864e571b5afdc4623 introduced a regression where if router without external gateway was already scheduled to all dvr_snat agents, then when adding external gateway to the router, snat portion scheduling was skipped. The patch fixes regression and adds corresponding unit (functional in fact) test. Closes-Bug: #1486627 Change-Id: Iad7e53bd57836f257d7110bc054d58029484ab99 commit 905064eb61479fcd8fdf0e600aaea38ba505d3bb Author: Ihar Hrachyshka Date: Thu Aug 20 11:50:09 2015 +0200 neutron-db-manage: sync HEADS file with 'current' output alembic.get_heads() returns all heads for all branches it can find in scripts dir, while in alembic_version table, it does not store any heads that were overridden by other branches, even if those depends_on it instead of having it as down_revision. To keep 'current' output in sync with what is in HEADS file, we can attach liberty_* branches explicitly to kilo revision. It's also a good idea to have a separate 'heads' command that would show the latest alembic heads based on scripts dir state. See [1] for more details. While at it, since different subprojects can link their expand/contract branches to kilo in different way (some using depends_on the previous release branch, while others, as suggested in this patch, thru down_revision to kilo), we kill the check on the number of heads returned by script.get_heads() since it may differ. If we want to validate that we don't branch more than twice from kilo, we may add a separate validation just for that. [1]: https://review.openstack.org/#/c/204551/ Change-Id: If551633ab26e0eac549c1e13cfa0771383a1a060 Partially-Implements: blueprint online-schema-migrations commit 80ee562dec3f397ea6c18a4ca3a1e69ab996341e Author: Eugene Nikanorov Date: Sun Jul 19 03:17:43 2015 +0400 Fix _ensure_default_security_group logic In a case when first attempt to fetch default security group fails and attempt to add it fails too due to a concurrent insertion, later attempt to fetch the same default sg may fail due to REPEATABLE READ transaction isolation level. For this case RetryRequest should be issued to restart the whole transaction and be able to see default group. The patch also removes 'while True' logic as it's unsafe Closes-Bug: #1475938 Change-Id: I20f65d3eae9421429aced1f4586cb6988ab577ff commit a79bc732c5add649dc62742bd15a498e106bcd31 Author: Yalei Wang Date: Thu Aug 20 00:09:04 2015 +0800 Add missing tenant_id validation in RESOURCE_ATTRIBUTE_MAP This patch will add the validation for tenant_id of 255 bytes string. Change-Id: Iaa8f78d2b70693d3365a41834d29e0f12ad3dd36 Closes-Bug: #1486314 commit 73673beacd75a2d9f51f15b284f1b458d32e992e Author: Eugene Nikanorov Date: Mon May 11 03:10:29 2015 +0400 Graceful ovs-agent restart When agent is restarted it drops all existing flows. This breaks all networking until the flows are re-created. This change adds an ability to drop only old flows. Agent_uuid_stamp is added for agents. This agent_uuid_stamp is set as cookie for flows and then flows with stale cookies are deleted during cleanup. Co-Authored-By: Ann Kamyshnikova Closes-bug: #1383674 DocImpact Change-Id: I95070d8218859d4fff1d572c1792cdf6019dd7ea commit 9016c1f810ee734d4a19032a470d4acb9462639d Author: Kevin Benton Date: Tue Aug 18 23:35:46 2015 -0700 l2pop: check port mac in pre-commit to stop change Check that a port mac address hasn't changed during the precommit phase of the port update rather than the post commit so the resulting exception actually stops it from happening. Change-Id: I62f120b3c954fa4251a7d676cf2c623e6da5a98b Closes-Bug: #1486379 commit 68167a817450c3fb2a9f24a6cb7364a3c7897916 Author: Vadivel Poonathan Date: Tue Aug 18 12:15:16 2015 +0700 Adding Ale Omniswitch to sub_projects document Change-Id: Iad00ce04fd506a559943fa4f30d4f92c62c2191b commit b1fe6426e37ef687c46d05a39d5a404656746461 Author: Assaf Muller Date: Tue Apr 28 10:47:13 2015 -0400 Add high-level functional/integration DVR tests * A note from the legal team: These tests in no way replace any existing tests. I would never dream of such a thing. Nor would anyone ever consider calling these 'unit' tests. That would be mad! Change-Id: I73c2b2096e767575a196bf08e7d4cc7ec52fdfa3 Co-Authored-By: Lynn Li commit 53fe9ddd6cc6943774fae609586a0adf9b2989f2 Author: Assaf Muller Date: Fri Jun 12 15:07:17 2015 -0400 Add a fullstack fake VM, basic connectivity test * Full stack tests' fake VMs are represented via a namespace, MAC, IP address and default gateway. They're plugged to an OVS bridge via an OVS internal port. As opposed to the current fake machine class used in functional testing, this new fake machine also creates a Neutron port via the API and sets the IP and MAC according to it. It also sets additional attributes on the OVS port to allow the OVS agent to do its magic. * The functional fake machine and the full stack fake machine should continue to share commonalities. * The fullstack fake machine currently takes the IP address from the port and statically assigns it to the namespace device. Later when I'll add support for the DHCP agent in full stack testing this assignment will look for the dhcp attribute of the subnet and either assign the IP address via 'ip' or call a dhcp client. * Added a basic L2 connectivity test between two such machines on the same Neutron network. * OVSPortFixture now uses OVSInterfaceDriver to plug the port instead of replicate a lot of the code. I had to make a small change to _setup_arp_spoof_for_port since all OVS ports are now created with their external-ids set. Change-Id: Ib985b7e742f58f1a6eb6fc598df3cbac31046951 commit d91cd8dc1a59a3d53009e34f1e2f47ed352f5205 Author: Sandhya Dasu Date: Mon Aug 17 06:26:53 2015 -0400 Final decomposition of ML2 Cisco UCSM driver The ML2 Cisco UCSM driver's entry point is being switched to the networking-cisco vendor repo. The definition of the driver's db file and all references to it in the neutron branch are removed. Change-Id: I75eb165f3bb78d31bece26762ca0ff47cab2b79b Implements: blueprint: core-vendor-decomposition Closes-bug: #1484165 commit 9ebc9f808316ca249348d2c5cd2b9762373f96dd Author: Ann Kamyshnikova Date: Wed Aug 19 14:19:11 2015 +0300 Fix query in get_reservations_for_resources For PostgreSQL if you're using GROUP BY everything in the SELECT list must be an aggregate SUM(...) or used in the GROUP BY. For reference: http:// Closes-bug: #1486467 Change-Id: Ieb4ead5c785ff17f580bfbc58f370a491733d96d commit bdc8f16f768093821a0490d4f60398de42993fc4 Author: Pavel Bondar Date: Tue Aug 11 13:13:28 2015 +0300 Move tests for non pluggable ipam backend Tests specific for non pluggable ipam backend were located in test_db_base_plugin_v2. Create appropriate test file and move tests there. Updated test class name and doc string to match tested class. Fix contains only tests moving without changes inside tests itself. Change-Id: Ia40fa3626e073e61e61463c9adab0b6d9a966ca1 commit a84216b1e0df6cab917e1f6a0af55a8372093ba0 Author: Jakub Libosvar Date: Tue Aug 18 15:05:21 2015 +0000 fullstack: Skip NotFound in safe_client cleanup If we explicitly remove resource in the test we don't need to fail in safe_client during cleanup phase. Change-Id: Ia3b0756b7aa9b159de1949889ae03ca5248bc5fa Closes-Bug: 1486081 commit 6d6980903c36c2609a98145886b53723d33fed29 Author: Miguel Angel Ajo Date: Tue Aug 18 08:35:00 2015 +0200 Fix tenant access to qos policies fix policy.json to not allow tenants to create policies or rules by default and allow tenants attach ports and networks to policies, please note that policy access is checked in the QoSPolicy neutron object in such case. Closes-Bug: #1485858 Change-Id: Ide1cd30979f99612fe89dddf3dc0e029d3f4d34a commit fab2f8eeca0ab7470be668b56b736463d9d82858 Author: Henry Gessau Date: Thu Aug 13 19:58:58 2015 -0400 Rename args for alembic 0.8.0 Version 0.8.0 of alembic has renamed some arguments in some of its methods. This generates warnings when running neutron's alembic migration scripts. Change-Id: I4f90a66c2465dd1d7f6631f297146754fd5e9cc4 commit b5c7bbee35c4009fa5867ac65b9672fe5adebfe6 Author: Cedric Brandily Date: Tue Aug 18 23:56:32 2015 +0200 Update sub projects git urls Some sub projects[1] have been moved from stackforge to openstack namespace. This change updates their git repo urls. [1] networking-arista/cisco/plumgrid Change-Id: I0847c3ff9e73508420ae67b432ad1e3654d07b6a commit a8bddee4f43c2772e4ca96acdee9b95feec733a9 Author: Salvatore Orlando Date: Tue Aug 18 10:01:50 2015 -0700 Stop using quota reservations on base controller The reservation engine is subject to failures due to concurrency; the switch to pymysql is likely to also have a part in observed failures. While no gate failures have been observed so far, this is a time bomb waiting to explode and must be addressed. For this reason this patch acts conservatively by ensuring the API controllers do not use anymore reservation. The code for reservation management is preserved, and will wired again on the controller when these issues are sorted. The devref for neutron quotas is updated accordingly as a part of this patch. Related bug: #1486134 Change-Id: I2a95fef0fdf64ef8781bef99be0fdc743346c17a commit 14e67087828d46a504180b7ac130732286502fb5 Author: Carol Bouchard Date: Fri Aug 14 13:39:45 2015 -0400 Final decomposition of ML2 Nexus Driver This changeset removes the remaining ML2 Nexus Driver Vendor code from the neutron repo. It has been moved to the networking-cisco repo. Change-Id: I95540f35f80ad8eba4bc3f6fa37095842e42c037 Closes-bug: #1482366 Implements: blueprint: core-vendor-decomposition commit 7cfcbac066842e2d1dd3578e9eb5801bb4a1af34 Author: Michael Smith Date: Tue Sep 16 17:00:05 2014 -0700 manual add/remove router for dvr_snat agent This patch is to address the failure of manual move of dvr_snat routers from one service node to another. The entry in the csnat_l3_agent_bindings table is now removed during the router to agent unbind operation. Appropriate notification is now sent to the agent to remove snat/qrouter namespace. There were other places in the code that needed to examine the snat binding table to check if updates were required - validate_agent_router_combination() and check_agent_router_scheduling_needed(). Additionally, schedule_routers() was made optional within the rpc _notification path since it can override the manual move being attempted. Change-Id: Iac9598eb79f455c4ef3d3243a96bed524e3d2f7c Closes-Bug: #1369721 Co-Authored-By: Ila Palanisamy Co-Authored-By: Oleg Bondarev commit a264b329df82f3c391f75bd9ad73a1327616a43d Author: Oleg Bondarev Date: Tue Jul 7 13:36:00 2015 +0300 DVR: fix router rescheduling on agent side The patch makes L3 agent aware of possible SNAT role rescheduling to/from it. The gist is to compare gw_port host change. If it was changed and agent is not on target host then it needs to clear snat namespace if one exists. If agent is on target host it needs to create snat namespace from scratch if it doesn't exist. Host field was excluded from gw_port comparison on agent side as part of HA Router feature implementation. This code was moved to corresponding module. Closes-Bug: #1472205 Change-Id: I840bded9eb547df014c6fb2b4cbfe4a876b9b878 commit 5afd046d53fd6cca4ad8b28ed37586f9d352a315 Author: Cyril Roelandt Date: Fri Aug 14 14:40:51 2015 +0200 Python 3: fix test_utils In Python 3, the error message returned when unpacking too many values is a bit different from the one we see in Python 2: Python 2: ValueError: too many values to unpack Python 3: ValueError: too many values to unpack (expected ) Blueprint: neutron-python3 Change-Id: Ib607a526c007567a370c521fd7e2e4f8b504b934 commit 4f2f619a6394cfc2e6f4a0ce02408610d47428b1 Author: Ihar Hrachyshka Date: Fri Jun 19 11:34:12 2015 +0200 lb: stop handling Havana device updates In Havana, device details did not contain segmentation_id but vlan_id. Those times are long gone. Change-Id: I7ea5d2cb114371692439c0518ce6bf497837e485 commit 852752edad15e13ab08aee67ea54a1fd2e829942 Author: Ihar Hrachyshka Date: Tue Aug 18 12:35:15 2015 +0200 quota: synchronize resync and count with other dirty_tenants code We should synchronize every access or modification of self._dirty_tenants or self._out_of_sync_tenants. Closes-Bug: #1485969 Change-Id: If17f57e8905fd8d13438d0421f73468e77f723d9 commit b5eef0e2661d43b05fae367706be5aaafaa14f0a Author: Doug Hellmann Date: Fri Aug 14 22:30:46 2015 +0000 Add logging to debug oslo.messaging failure It looks like recent changes to oslo.messaging master are conflicting with changes in neutron master with the way RPC services are started when the rpc_workers value == 0. Change-Id: Iea2197ad0ea9ceb9a2a850a9e03e53b4b39ca288 commit 75edc1ff28a460342a9b5e5b7d63c6f4fb59862d Author: Sudhakar Babu Gariganti Date: Fri Aug 7 16:07:12 2015 +0530 Setup firewall filters only for required ports We can skip trying to setup firewall filters for ports which are having port_security_enabled as False or which are not associated to any security group. Closes-Bug: #1482554 Change-Id: Ie65201308d93c746fe4ef38f402ec300227b7d27 commit 23c1c0bdc90b5f730544015900715416c282f76d Author: OpenStack Proposal Bot Date: Tue Aug 18 01:35:13 2015 +0000 Updated from global requirements Change-Id: I7c2244869509221deb0cee47b215ac66eccf1f2b commit 09324277aec6c09d981fe255270be5ab10577329 Author: Salvatore Orlando Date: Tue Jul 21 03:52:09 2015 -0700 Quota enforcement: python3 compatibility This patch does a simple fix to the quota DB driver in order to ensure its compatibility with python3 and adds the quota enforcement unit tests to the list of those executed as a part of the py34 test environment. Change-Id: I9b5601632866e1fb42f860d1cca5f77b5f14f2c8 Related-blueprint: better-quotas commit 0a6dd153c93fb882f5aae4571bdc9f9a6c595548 Author: Salvatore Orlando Date: Sun May 17 17:43:38 2015 -0700 Devref for quotas This patch adds developer documentation for quota management and enforcement. Partially-Implements blueprint better-quotas Change-Id: Ia990484caf6f5818104109e3d28e2990b9347726 commit 574b25b857419eed74237f61749cb76c4e612fb4 Author: Salvatore Orlando Date: Wed Mar 11 17:28:43 2015 -0700 Reservations support Add the concept of resource reservation in neutron. Usage tracking logic is also updated to support reservations. Reservations are not however available with the now deprecated configuration-based quota driver. The base API controller will now use reservations to perform quota checks rather than counting resource usage and then invoking the limit_check routine. The limit_check routine however has not been removed and depreacated as a part of this patch. In order to ensure all quota drivers expose a consistent interface, a make_reservation method has been added to the configuration based driver as well. This method simply performs "old-style" limit checks by counting resource usage and then invoking limit_check. DocImpact Implements blueprint better-quotas. Change-Id: Ifea07f461def564884af5b291c8a56655a4d818b commit aa436612cb58fc86af7e27e113bafc1ffe9cbcf4 Author: Doug Wiegley Date: Mon Aug 17 13:51:51 2015 -0600 Fix .gitreview to not point at a branch Change-Id: I072e5867965565908bdacf3ada9855d686060fad commit 805496dd5ce85c9280342f1702b12dd30b201bbb Author: Doug Wiegley Date: Mon Aug 17 09:17:46 2015 -0600 Don't fatal error during initialization for missing service providers Sometime during the split, code was added to fixup driver paths, which imports service providers even for plugins which are not in use. That, combined with neutron including default service providers for VPN and LOADBALANCER, resulted in a really messy mess in terms of removing VPN from the main neutron test suites. This change stops the imports, so that if one of the services is missing, neutron server can still start. It likely breaks the driver path fixup, which can be fixed outside of this gate blockage. Closes-Bug: #1483266 Change-Id: I23f9007357d8cbbae599997c244561a4e2f32ce1 commit 9d0088d0fb14fa21891e434c0b983036f86ae62a Author: Abhishek Raut Date: Mon Aug 10 09:54:05 2015 -0700 NSX: Move DB models as part of core vendor decomposition This patch removes the database models from neutron repo. Also removes README, common modules and plugin module. Change-Id: I5d5b0acf34417889c2a449f22b92fd105697d90d Related-Blueprint: core-vendor-decomposition Partial-bug: #1483453 commit 82a7e2f91941ae98c2fb5ad9c9f85af1a5cc035c Author: YAMAMOTO Takashi Date: Fri Jul 31 17:43:37 2015 +0900 doc: Improve table rendering using multi-row cells Also, fix a nearby typo. (nic -> nick) Change-Id: If94b123f9b9291db1d889026de679d91645271bc commit 57b49e5f93235e446c109c1d5ee7c3e2b738d556 Author: shihanzhang Date: Wed Aug 12 17:12:27 2015 +0800 Rename function '_update_port_down' The function _update_port_down is renamed to _get_agent_fdb because it generates the fdb entries which are send to related l2 agents, but the old name is hard to understand. Change-Id: Ibd5447311361b62a18195a958cbdeb64fc685b24 commit 320d7a83ba269b16874f19e39a33bdc1d815ed5d Author: Madhu Mohan Nelemane Date: Tue Aug 4 09:21:52 2015 +0200 Redundant tests removed from ovs-lib unit tests: The idea here was to remove redundant unit tests. The approach here has been that if the function being tested does not implement any custom logic (apart from calling ovsdb), the unit test does not help. Refer to the bug description for more details of the specific tests removed. Change-Id: I35dc60bb714566c33f5cee5aab3e5b83bd0610e3 Closes-Bug: #1459811 commit 7e0a4dc9797101833e183c3d1b95fb947af49eac Author: armando-migliaccio Date: Wed Aug 12 11:49:46 2015 -0700 Unskip firewall test Dependent patch addresses the issue, so we no longer need to skip the test Related-bug: #1483875 Depends-on: I455bbe00395377509beca5ec1d54cf4f7a57152d Depends-on: I00d99c05328268b33c6f20b1d24e7507afccb92c Change-Id: I41b51f36c1344dce20b1b9437c175469acfafb57 commit 8d0e5dac4d99b97d91db4e3781677bf83fc656aa Author: Roey Chen Date: Sun Aug 16 06:29:26 2015 -0700 NSX plugin: Moving away plugin extensions As part of plugin decomposition, this patch moves vmware-nsx extensions out of the neutron repository. Change-Id: Iff4c4781dd96b10733a98f176cf2f0f4d25cb34f Related-Blueprint: core-vendor-decomposition Partial-bug: #1483453 commit 7e699606bb30422c87cf554470b6c98cfe183417 Author: Kevin Benton Date: Sun Aug 16 02:32:39 2015 -0700 Get rid of exception converter in db/api.py The exception converter was necessary because the exceptions the oslo db decorator looked for before were statically defined. The retry decorator now accepts an exception_checker argument that takes a function to call on exceptions to determine if they should be caught. This patch gets rid of the converted and replaces the one use case with the new exception_checker argument. Closes-Bug: #1485819 Change-Id: Ic619b03737cbf51276f87c4458ecc4183424731c commit 048316e98114145ad19285cdeedd0040b59a66f8 Author: fumihiko kakuma Date: Wed Jul 22 14:00:25 2015 +0900 Python 3: encode or decode i/o data of Popen.communicate() In Python 3, input and output for Popen.communicate() is bytes type. Therefore, encode input data and decode return data for Popen.communicate(). Change-Id: I70f009e3366f0eeda5790652ea14f3627b934664 Blueprint: neutron-python3 Closes-Bug: #1479159 commit aea9c825740fe4b7b2d1ac2ee3b80a6282c5d639 Author: OpenStack Proposal Bot Date: Sat Aug 15 20:50:51 2015 +0000 Updated from global requirements Change-Id: I5fc0be8c97c21ef68174ff6b8807e05a5e1f19a4 commit 7e9b0e4ac53e83b18dd949564435710e86c7b81e Author: Kevin Benton Date: Thu Jul 30 18:07:03 2015 -0700 Use a conntrack zone per port in OVS Conntrack zones per network are not adequate because VMs on the same host communicating with each other cross iptables twice. If conntrack is sharing the same zone for each cross, the first one can remove the connection from the table on a RST and then the second one marks the RST as invalid. This patch adjusts the logic to use a conntrack zone per port instead of per network. In order to avoid interrupting upgrades or restarts, the initial zone map is built from the existing iptables rules so existing port->zone mappings are maintained. Closes-Bug: #1478925 Change-Id: Ibe9e49653b2a280ea72cb95c2da64cd94c7739da commit fdd96e9a00cdb537217de51488aa59890564d0a8 Author: Matthew Treinish Date: Fri Aug 14 11:41:49 2015 -0400 Fix some issues around tempest in fullstack testing doc The why section in the fullstack testing doc gives a good explanation of the rational behind the testing and where it fits in the testing pyramid. However, some of the drawbacks of tempest mentioned aren't accurate or are misleading. This commit attempts to reword that piece to clear up any potential sources of confusion. The difficulty in running tempest doesn't change depending on the nature of the deployment, since tempest is an external test suite that interacts with any deployment only through the api. The configuration and run mechanics do not change whether your cloud is 1 or multiple nodes. The real difficulty lies in setting up a multinode deployment. For the failure reporting, if you can't figure out why something failed from a tempest run it's the same for any end user of the API. It should be treated as a bug in the project if an end user can't figure out why something failed from logs and what gets returned by the API. But, since the fullstack tests are a bit lower level its not necessarily trying to catch bugs like that. This commit attempts to reword it to make that distinction clear. Change-Id: Ie5b01047412deb84fe1457100ecd4af48a1d7efc commit 50665e131a90e2166634ab165a8a3c385fc742bb Author: Gal Sagie Date: Fri Aug 14 15:45:32 2015 +0300 Add lieutenants contact for kuryr Change-Id: I873b88b1fab513d8a4a4ad81a0c2d3161b4cef88 commit dfe9a2b9185f984f54424e32c857d1a6aac616f7 Author: Ryan Moats Date: Fri Aug 14 08:25:17 2015 -0500 Add dashboard folder and graphite dashboard to doc Create a dashboard folder to hold HTML files that provide dashboard views into various parts of neutron. This allows the dashboards to be "living code" rather than frozen in amber via shortened URLs. The first dashboard example is a simple HTML file that shows thumbnails of graphite plots of all neutron jobs in the check pipeline. Clicking a thumbnail brings up the larger graphite plot page. Change-Id: I47e7718c2aae41c8308fd331377984e47a892294 Signed-off-by: Ryan Moats commit d3784b30df447e239ff560c48142e8ab1a3c2c81 Author: Kyle Mestery Date: Thu Aug 13 16:33:18 2015 +0000 lieutenants: Add Neutron infra lieutenants It's become clear we need to have a centralized contact point (or points) for Neutron interactions with infra. Lets start out by making that Doug and Armando for now. Note this list is alphabetized by last name for those curious on the ordering. Change-Id: If736dc2c6482d0c2722cf0a5049c8ee5511ed970 Signed-off-by: Kyle Mestery commit 419ce6281dd1e44597617d44fe5496580536b0e5 Author: Oleg Bondarev Date: Thu Jul 2 15:47:34 2015 +0300 DVR: do not reschedule router for down agents on compute nodes Scheduling/unscheduling of DVR routers with l3 agents in 'dvr' mode running on a compute nodes is done according to DVR serviced ports created/deleted on that compute nodes. It doesn't make sense to reschedule router from l3 agent on compute node even if it's down - no other l3 agent can handle VMs running on that compute node. Closes-Bug: #1470889 Change-Id: Ib998b9e459dd1a9ab740fafa5d84dc3211ca0097 commit f1457af336b8b4ed72105b9d98a53f95c28c0c1e Author: Isaku Yamahata Date: Tue Oct 21 11:30:32 2014 +0900 Replace internal calls of create_{network, subnet, port} When API controller calls method create_{network, subnet, port), it made sure that the necessary default values for attrs are filled properly according to attr mapping. However, internal calls to these methods do not follow the convention, when extension codes miss these values, exceptions will be thrown. This patch introduces helper functions to fix up arguments and replaces the direct callers of those methods. Co-Authored-By: gong yong sheng Co-Authored-By: yalei wang Change-Id: Ibc6ff897a1a00665a403981a218100a698eb1c33 Closes-Bug: #1383546 commit 0006275fe7b9a5b0e5a2ffaa024a77097c673939 Author: YAMAMOTO Takashi Date: Fri Aug 14 19:19:31 2015 +0900 ml2: Remove a redundant assignment in _bind_port_level Don't mark binding FAILED here, as the caller does the same. Change-Id: I95d9a64965d0ca9bf8a870f05c73fa11cf189f8f commit 977e7856c0ce81162c13c61a832b6bbef79c3aad Author: YAMAMOTO Takashi Date: Fri Aug 14 19:08:38 2015 +0900 ml2: _commit_port_binding: Don't use None to mean False The second return value is a boolean. Change-Id: Id5b2b00bdfcb7c81ba05b1905cd781f38e6ebad8 commit 65c8da40e40d17f028ca1e23eabcc4f5a3272875 Author: Amit Saha Date: Fri Aug 14 13:28:06 2015 +0530 Minor typo fix Change-Id: Id6f50b56c9af6a1161e95a3ac0b3411d3513aa2e commit ff709d5b83abdc954311be9e7d52dfa9e9c3d7ba Author: Isaku Yamahata Date: Wed Jul 15 19:27:16 2015 -0700 l3: not use L2 plugin _get_subnet unnecessarily This patch is clean up to prevent future breakage by eliminating potentially dangerous code. l3_db and related code use L2 plugin _get_subnet and related method unnecessarily instead of get_subnet. It's dangerous because _get_subnet returns ORM db object which allows the caller to update db rows directly. So the caller of _get_subnet may update subnet db without notifying L2 plugin unintentionally. In that case, L2 plugin or ML2 mechanism driver will be confused. This patch replaces _get_subnet and _get_subnets_by_network with get_subnet, get_subnets_by_network where possible. Change-Id: I85769e639a408a292b5bd70a9d9a1ac292e2b51c Related-Bug: #1475093 commit 9ba23658a34eac696a7eed9a8aaca6a4625d1391 Author: Isaku Yamahata Date: Wed Jul 15 12:34:12 2015 -0700 l3_db: not use L2 plugin _get_port unnecessarily This patch is clean up to prevent future breakage by eliminating potentially dangerous code. l3_db uses L2 plugin _get_port method unnecessarily instead of get_port. It's dangerous because _get_port returns ORM db object which allows the caller to update db rows directly. So the caller of _get_port may update port db without notifying L2 plugin unintentionally. In that case, L2 plugin or ML2 mechanism driver will be confused. This patch replace _get_port with get_port method where possible. Change-Id: I5a23f6cac5ea359645e6947fd69978f060c4ba97 Related-Bug: #1475093 commit 59434672b405f3734d1c319aac311af75a88325f Author: Kevin Benton Date: Thu Aug 13 16:58:02 2015 -0700 Break down _bind_port_if_needed in ML2 Separate the looping and retry logic in _bind_port_if_needed from the actual binding attempts. This also eliminates the 'while True' loop with a regular for loop counter to make it a little easier to reason about. A suggestion to do this came up in a code review for I437290affd8eb87177d0626bf7935a165859cbdd because the function was difficult to reason about. Change-Id: I6171cf39a4562ed1da9467e8e604d4519a813977 commit 228206c024452287e07fbbed2b8059d04da8c0b9 Author: Brian Haley Date: Thu Aug 13 16:57:59 2015 -0400 Remove 'action' argument from _handle_fip_nat_rules() There's only one caller of _handle_fip_nat_rules(), and they always specify 'add_rules' as the argument, so it's not necessary any more. Also, the interface passed must be valid since the caller has already used it, and would have thrown an exception before this call was made. Found during another code review. Change-Id: Ie7d4faf2d1bb8e0e8fc4ffc3f18e9214474acf5c commit 0b19a1ef55b2533a55e9909755f31ee2026ce40f Author: Shih-Hao Li Date: Thu Aug 13 13:22:33 2015 -0700 Remove vmware plugin from neutron (etc part) Remove neutron:/etc/neutron/plugins/vmware/ because it has been moved to vmware-nsx:/vmware_nsx/etc/ in commit# b27bc1942195ff551cd22ddaf6853a25302cbb7e. This is the first part of vmware plugin decomposition (etc, extensions, and database). Partial-bug: #1483453 Change-Id: Ic6fe5e256369a1b6aabdaadf019989f0e6a6e444 commit 25420bb1bbccb037866872efdf1e5d3458d286a6 Author: Doug Wiegley Date: Tue Aug 11 15:46:31 2015 -0600 Setup reference service providers for API test runs Partial-bug: #1483266 Change-Id: Ia979fa2fdf25f3c1dbe9e7160d6dde2df51c305e commit e9468fcd0c7c6028a4a4dc72ae42b2b7cf80ec9f Author: Ihar Hrachyshka Date: Wed Jul 29 00:16:17 2015 +0200 [neutron-db-manage] check_migration: validate labels Guard against potential down_revision interleave by checking that each revision has the only revision that corresponds to its location in the migration tree, and that its parent also has that same single label. Partially-Implements: blueprint online-schema-migrations Change-Id: Ia812e8283f4da955610fe043aba3ad0298ede24b commit 0a4812d6e8eacc2a1b5f6dab082c7e7af95d080a Author: Cyril Roelandt Date: Thu Aug 13 16:01:07 2015 +0200 Python 3: fix neutron.tests.unit.api.test_extensions Change-Id: I4db43d93ae22c4a480aa1d103c8e7cf1427d49db commit 98618644ce3c36eabfcc0aea49e7962b0506a567 Author: John Schwarz Date: Wed Aug 12 13:39:28 2015 +0300 Add configurable options for HA networks The L3 HA mechanism creates a project network for HA (VRRP) traffic among routers. The HA project network uses the first (default) network type in 'tenant_network_types'. Depending on the environment, this combination may not provide a desirable path for HA traffic. For example, some operators may prefer to use a specific network for HA traffic to prevent split-brain issues. This patch adds configurable options that target the network_type and the physical_network of the created HA network. Doc-Impact Closes-Bug: #1481443 Change-Id: I3527a780179b5982d6e0eb0b8c32d6dafeeab730 commit 43f3d7506121084e29d5084ea3da7cbd2e7e7902 Author: Ann Kamyshnikova Date: Fri Aug 7 16:53:53 2015 +0300 Add test that checks external tables are not changed Alembic migrations should not change tables which models were moved out of Neutron. This change add check for this. Also this change remove clear_override from db_sync in _TestModelsMigrations which is not needed. Closes-bug: #1466704 Change-Id: I587cd6fb2baa82fd7e452bb8597136efa5b8084e commit 452f95bc634a5259fcf5097a45eaacb2e96988fb Author: Ihar Hrachyshka Date: Wed Jul 29 09:38:48 2015 +0200 [neutron-db-manage] remove old HEAD file when updating for branches Partially-Implements: blueprint online-schema-migrations Change-Id: I259d4f9090df821ade9d58f440c809e79458211d commit afd08e066cb359b2bafc88f687f0ed6a30c57391 Author: Cedric Brandily Date: Sun Jul 19 21:16:54 2015 +0200 Remove unneeded shebangs This change removes unneeded shebangs in python modules. Change-Id: Id0a3664eddf1ee26830998f4c73e89d0de5249d6 commit 60a9f4a6f8a1f31093a2a888466f91ff202b971f Author: Cedric Brandily Date: Wed Jul 29 11:19:45 2015 +0000 Python 3: hmac requires bytes key/msg This change encodes hmac key/msg inputs because py3K requires it. Change-Id: I54a6789aee2fb707c0d753f569d0b2d5fd460682 Blueprint: neutron-python3 commit 7f4777f42f8b21b4ba663e063acb7aca3ec255bd Author: fumihiko kakuma Date: Sat Aug 8 22:08:39 2015 +0900 Python 3: encode unicode response bodies This change adds a file needing a python 3 support by Ie0dc57fbe3ed9b19dac2e958de14387bc4c1a260. Change-Id: Ice6e8ae618b82ff45398c338c3eee27ed9d5a105 Blueprint: neutron-python3 commit 603c0d03aed5fdeefb471086c0aef879938f9641 Author: Henry Gessau Date: Sun Jul 5 03:29:38 2015 -0400 Support for independent alembic branches in sub-projects Sub-projects shall now register their independent alembic migrations via entrypoints in setup.cfg, and neutron-db-manage will discover them and run them automatically. If a service or sub-project is specified explicitly, then neutron-db-manage will run on only that service or sub-project. The advanced services project are just special cases of sub-projects. For example, specifying the CLI option '--service lbaas' is the same as specifying '--subproject neutron-lbaas'. Specifying no service or sub-project will cause neutron-db-manage to run the command on neutron and all installed sub-projects. Added and consolidated documentation into devref for alembic migrations. Partial-Bug: #1471333 Partial-Bug: #1470625 Change-Id: I9a06de64ce35675af28adf819de6f22dc832390d commit 74a5e9166702031e7b6657e3e67bec00fd6145cb Author: Kanzhe Jiang Date: Wed Aug 12 20:36:54 2015 -0700 Remove bigswitch mech_driver entry point definition After vendor driver split, the entry point for bigswitch ml2 mechanism_driver is no longer valid. The new entry point is defined in the networking-bigswitch stackforge repo. Change-Id: Ie6e19a13e49d9d3e95f8ea2f10181592e9f156e5 Closes-Bug: #1484341 commit 7e070bddad2c2df20e8f43d4c038aea7c7e55900 Author: OpenStack Proposal Bot Date: Thu Aug 13 02:14:42 2015 +0000 Updated from global requirements Change-Id: Ieb2e8eaf3eb9fee93d5fcb8cb4e683a0a6555fc0 commit 9744ef78e6916f6eca8dd73da6417d0f1f79563e Author: fumihiko kakuma Date: Sat Aug 8 23:20:45 2015 +0900 Python 3: specify a bytes to an argument for a format type 's' of struct.pack() In python 3, a format type 's' of struct.pack() requires a bytes object to an argument. Change-Id: Ia4640b31c31b5b7454cd1582af46562fb1885726 Blueprint: neutron-python3 commit de81ab8385e8490b2320e23ee7dd86b43e22fd32 Author: Adolfo Duarte Date: Thu Jun 18 19:50:13 2015 -0700 Preserve DVR FIP rule priority over Agent restarts IP rule priorities assigned to DVR floating IPs need to be preserved over L3 agent restarts. Reuse the ItemAllocator class decomposed from Link Local IP address allocation. Also move commn unit tests to ItemAllocator class. Closes-Bug: #1414779 Change-Id: I6a75aa8ad612ee80b391f0a27a8a7e29519c3f8d Co-Authored-By: Rajeev Grover Co-Authored-By: Ryan Moats commit ca497aa1fbbcc71f7f840c568fa338666da97cac Author: James E. Blair Date: Wed Aug 12 10:51:18 2015 -0700 Treat sphinx warnings as errors Change-Id: I65fcca7eb3397c8f5a777bab1c9c20161263ed26 commit 2bb48eb58ad28a629dd12c434b83680aa3f240a4 Author: yangxurong Date: Sat Dec 27 17:29:27 2014 +0800 Distributed router can not add routes Centralized router can add routes, but distributed router can not, the neutron router-update operation fails silently. This is because on a distributed router commands need to be run in the snat-* namespace, and not the qrouter-* namespace as on a centralized router. Change-Id: I517effcfc299c67c3413f7dc3352b97515ff69db Closes-Bug: #1405910 Co-Authored-By: Ryan Moats commit 9d1bc8195c91d55c5d1cf0ff10f089fd2aa8a359 Author: Assaf Muller Date: Wed Aug 12 13:20:10 2015 -0400 Update fullstack multinode simulation image Change-Id: I9d332e296b1f72e423ee64b01a82ae36b688c27e commit ea50c9e19c0997b04436d92abd32b5eccff4ea91 Author: Assaf Muller Date: Wed Aug 12 13:29:50 2015 -0400 Fix docs job It looks like the docs job is passing when it shouldn't. Change-Id: I4b65e470e913cd84e63231259e355c5842878c4b commit 6d004c41449a84bfb00d1bbc9affdbd8b08f2fa8 Author: armando-migliaccio Date: Tue Aug 11 18:16:30 2015 -0700 Improve callback registry devref documentation and usability Latest developments have revealed that the registry can be misused under certain circumstances, and that it can be harder to use by projects that extend Neutron. This patch improves the devref documentation so that developers know what to expect. Change-Id: I565b6a2f2a58bf22eae5b36f03c4fd24ba0774d2 commit 26b226f43ed436b190ca6392d289df3b0e090b30 Author: Henry Gessau Date: Wed Aug 12 11:43:29 2015 -0400 Final decomposition of the ML2 NCS driver Closes-Bug: #1484160 Related-Blueprint: core-vendor-decomposition Depends-On: I713f2378050f514a427fb9937b2a1fc5cc48bd6f Change-Id: I0a447fd5b176faf96fc0f5e164fa7a3b098ae74f commit a3285ac71acb83880c3e055728acff0c5e339062 Author: John Davidge Date: Fri Aug 7 16:27:47 2015 +0100 Fix update_subnet for prefix delegation A misnamed function call and execution order issue was causing update_subnet to fail when a PD enabled subnet received a new CIDR. This patch fixes the issues, and introduces an rpc api test to ensure the function works. This includes altering the process_prefix_update RPC handler to expose the issue to the test. Change-Id: Id1e781291f711865fd783ed5e0208694097b7024 Closes-Bug: 1482676 commit cf7086701b02b08c30c5a20b6b3473f6dc79f3fe Author: huangpengtao Date: Wed Aug 5 23:05:06 2015 +0800 The unnecessary value "sgids" was deleted The value "sgids" is unnecessary to be used. Even it is a bit confused to use "sgids", the code will be easier to understand without it. Change-Id: I8b881139a71bdc9f3742e7208610eb56081fbbc7 commit 0b5b6c7e746839d3f9bece6e782092bca3c9725e Author: Assaf Muller Date: Mon Apr 13 13:26:06 2015 -0400 Fix DVR interface delete by port when gateway is set When removing a DVR interface by port, the subnet_id passed to delete_csnat_router_interface_ports is None, and so it deletes all the DVR SNAT ports for the router. This patch fixes this issue by passing in the right subnet_id to the delete_csnat_router_interface_ports. Change-Id: I16735195c6575454876acd0e99ef45f382963566 Closes-Bug: #1443524 Co-Authored-By: Swaminathan Vasudevan Co-Authored-By: Oleg Bondarev commit 764e716cd658dfa9b4cbb07be6bbbeff99e21eaf Author: Sean M. Collins Date: Wed Aug 12 07:42:04 2015 -0400 Skip FwaaS test that is failing due to race condition Change-Id: I8a7669b6aff0b407b192af803fbfb636c8f118bb Related-Bug: #1483875 commit 653fd35be2ebc7bdfd1eb417d086cf0884be29cd Author: shihanzhang Date: Tue Jun 9 17:47:39 2015 +0800 Destroy ipset when the corresponding rule is removed if a security group has a rule which allow a remote group access, but this remote group has no IPv4 and IPv6 members, L2 agent should not clear the remote group in internal cache of sg_members, because when above rule is deleted, L2 agent can get the remote group id from the diff of pre_sg_members-sg_members, then destroy the ipset set for remote group. Change-Id: I801b14c9f506c5a07f8875b8f9be1b05d181b842 Closes-bug: #1463331 commit 7809f1574ce7c2adad070c5d00b17d818ae3cae5 Author: Cedric Brandily Date: Wed Jul 29 11:15:49 2015 +0000 Python 3: compare response.body to bytes in namespace_proxy test WebOb response bodies should be compared to bytes not string. Change-Id: I2c17d39cc394a1d583b4f4971c0db9ba1875a0d0 Blueprint: neutron-python3 commit bb1546df15b57923fdbb9057407274bdcce59c50 Author: John Schwarz Date: Mon Aug 3 18:55:31 2015 +0300 Forbid attaching rules if policy isn't accessible Following up patch If06de416dfe0eb7115fd4be9feb461fae8e8358d, this patch continues to make sure all access to QoS policies are attempted safely - if the policy doesn't exist or it's not accessible (for tenant_id reasons), then an exception will be raised instead. Change-Id: Id7e64c745cdd63d650a3f69572635dc10197259c Partially-Implements: quantum-qos-api commit 4418bf426ac48935b27d235139912c2e3ec1d1b5 Author: Oleg Bondarev Date: Wed Aug 12 12:29:25 2015 +0300 DVR: fix router rescheduling on server side This fixes router rescheduling for dvr routers to correctly handle CSNAT portion rescheduling on server side. Next patch will make L3 agent aware of possible SNAT role rescheduling to/from it. Partial-Bug: #1472205 Change-Id: I069500a2f1de9a734124544a3f2d793e9fa2d27c commit d56fea0a39cbb53c36b0f7df3f7baef34588ec9a Author: Miguel Angel Ajo Date: Tue Aug 11 13:51:16 2015 +0200 Fix the low level OVS driver to really do egress It seems that the Queue + QoS + linux-htb implementation was really limiting ingress by default. So this patch switches the implementation to the ovs ingress_policing_rate and ingress_policing_burst parameters of the Interface table. Later in time we may want to revise this, to make TC & queueing possible, but this is good enough for egress limiting. Also, removed the _update_bandwidth_limit del+set on OvS QoS driver for the bandwidth limit rule update, since that's not needed anymore. Change-Id: Ie802a235ae19bf679ba638563ac7377337448f2a Partially-Implements: ml2-qos commit 995c35221bd9d51a71022902a00a1d9e23449787 Author: Moshe Levi Date: Fri Aug 7 17:35:48 2015 +0300 SR-IOV: Add Agent QoS driver to support bandwidth limit This patch adds SR-IOV agent driver which uses eswitch manager to set VF rate limit. It also updates the agent to call port_delete api of the extension manager to cleanup when port is deleted. Partially-Implements: blueprint ml2-sriov-qos-with-bwlimiting Change-Id: I364fc8158e502d4dcc3510d6157f12969961a11d commit 08f0bb9ce5c821b421394d2c7d9186f40c417f7d Author: Yalei Wang Date: Thu Aug 6 01:03:20 2015 +0800 Pass the extension driver exception to plugin The extension driver is intercepted by driver manager currently. It will cover the errors/exceptions happened in extension drivers. The extension process will continue even if preceding extension driver get a wrong/useless extended result, or even no result. This patch make process_[create|update]_() and extend__dict() methods return the exception, and log it with proper level respectively, and also include a minor optimization for the extend__dict() methods. Change-Id: I20a249c47b58292125476bc44b2372ca959509e3 Closes-Bug: #1468990 (cherry picked from commit 73845d564c910bb9113a3ba5963b368384efbaad) commit a17d97fc00d7467e9128f9691d3409636ce1e9b4 Author: Miguel Angel Ajo Date: Tue Aug 11 16:47:23 2015 +0200 Update documentation acording to last QoS/OvS changes Change Ie802a235ae19bf679ba638563ac7377337448f2a introduces a few changes to the low level ovs implementation of QoS, this patch updates documentation. Change-Id: I46a972b045c03f65888a22f55e893c69da3db14b Partially-Implements: ml2-qos commit 8aedbd7ef5f4c2accf75484cddffd4223faa51c6 Author: Jakub Libosvar Date: Tue Aug 11 12:36:05 2015 +0000 OVS agent functional test for policy rule delete Partially-Implements: ml2-qos Change-Id: I57a006352d97363005f4f2a7d79ec8f1c91d1555 commit 02b6ea5bbbe034d026544e536842f7bf56f7f531 Author: YAMAMOTO Takashi Date: Wed Aug 5 15:12:10 2015 +0900 Add Kuryr to sub_projects.rst Change-Id: I8974b140cd69ddf125fecad0ea4714e803bf9740 commit 780d571aed1b1278895e5b9e85b5209772d7ba16 Author: Assaf Muller Date: Tue Aug 11 14:20:07 2015 -0400 Clean up test_dvr_router_rem_fips_on_restarted_agent * self._add_fip wasn't actually doing anything useful, it just throws off the reader by making him/her think that line is important when it isn't. * Added an assertion that checks that the FIP namespace exists before the reconfiguration of the router. Change-Id: Ifd27f20d9d8d11575212b95e3bbe534bfe2d3b8f commit 0b0aa4a61dce3af9e6e2d773434ced0298d60275 Author: John Davidge Date: Tue Aug 11 13:55:51 2015 +0100 Fix _update_subnet_allocation_pools returning empty list _update_subnet_allocation_pools was returning an empty list in all cases due to trying to iterate over the same generator twice. Generators cannot be iterated over multiple times. This patch changes the generator into a list to fix this problem, and alters the unit test so that this issue is exposed. Change-Id: Iea98f3ae4f16964cd68154ac5edfeb125de889e0 Closes-Bug: 1483687 commit df257dec56ae3c1f834b0c423ae55ec85164981a Author: Ihar Hrachyshka Date: Mon Aug 10 18:51:24 2015 +0200 devref: update quality_of_service - note that we do not use versioning features of oslo.versionedobjects yet; - described the flow of updates from agent perspective; - mentioned the delete_port API of QoS drivers; - removed SR-IOV from the list of supported drivers since it's not in yet. Change-Id: I48940dc88b04e5e54e55187423295a6d34ee725d commit eef7983d4ec829ba910a6c1000e8dac95efe50d3 Author: Kevin Benton Date: Tue Aug 11 06:01:25 2015 -0700 Replace 'import json' with oslo_serialization Replace remaining occurences of 'import json' with 'from oslo_serialization import jsonutils as json' so pylint doesn't complain every time someone happens to make a change to one of the modules that still uses it. Change-Id: Ife9f0fc54ad36887bdb939028f8903be16e590d6 commit becfd6ebe603d5bac0148afb1e0892eaa3e325e5 Author: Moshe Levi Date: Tue Aug 11 07:08:11 2015 +0300 SR-IOV: Convert max rate from kbps to Mbps ip link tool configures max rate in Mbps and it the QoS model max rate is defined in kbps. This patch convert the max rate from kbps to Mbps. Also because zero disables the rate limit the min value is 1Mbps and not 1kbps. DocImpact Partially-Implements: blueprint ml2-sriov-qos-with-bwlimiting Change-Id: I91b08c5d8ccaa2867b6eafd0c86872f401dd04c8 commit 11da3bbe8b91c5cd9aa4a44b2c23e4ab001653da Author: Assaf Muller Date: Sat Aug 8 19:09:52 2015 -0400 Add testing coverage .rst, missing test infrastructure to-dos Change-Id: I1f3bc57ebc196a1c50b731c68cecb5aad3cda21d commit 07d3d6966394e2a354fa5bd7ba52959cf76cc81e Author: Cedric Brandily Date: Thu Jul 23 00:28:35 2015 +0200 Python 3: encode unicode response bodies WebOb disallows in py3K to set webob.Response.body to a unicode object, we should encode unicode bodies in such case. Change-Id: Ie0dc57fbe3ed9b19dac2e958de14387bc4c1a260 Blueprint: neutron-python3 commit 2aac5991aca3a90df40668a4e73c389010192287 Author: Jakub Libosvar Date: Mon Aug 10 16:55:11 2015 +0000 Update port functional tests for qos agent Change-Id: I4a1f4ec1ed9a9104fe7e5bbce66147d8ea6c0f27 Partially-Implements: quantum-qos-api commit ca0d7bce211d33ef8081684542ba4854cb743d74 Author: Ihar Hrachyshka Date: Mon Aug 10 08:29:52 2015 +0200 Removed configuration option for qos agent driver selection There is no (general) use case to allow users to configure qos driver to load by qos l2 agent extension. So instead of getting the driver name from the configuration file, hardcode it and potentially reuse for other extensions that may also be interested in splitting extension into agent agnostic and agent specific pieces. Added driver_type parameter to AgentCoreResourceExtension.initialize(). Also updated the method signature to reflect that we expect l2 extensions to receive connection. Finally, removed #noqa import for openvswitch.common.config from qos extension unit test since it seems unneeded. Change-Id: Iae4dcc20c967d1da216772a3a3660e0421263527 Partially-Implements: quantum-qos-api commit 991bcd671161f398cb77c6f96efb1638eddf35ae Author: Moshe Levi Date: Mon Aug 10 14:43:55 2015 +0300 Add delete_port api to agent extension manager This commit add delete_port api to the agent extension manager, the agent extension and the qos etension, and it update the ovs agent to call it upon delete port. Change-Id: Ia4e96c7c734cf4abe9a35c813bd8330b15b68f4c Partially-Implements: bluerint ml2-qos commit af2e56d86caad9b72c55dbc4248c63d9db7bb8e0 Author: Miguel Angel Ajo Date: Mon Aug 10 15:32:57 2015 +0200 Functional test for QoS policy bandwidth rule update Creates a port in a policy, and subsequently modifies the bandwidth limit rule in the policy, then verifies that the new limits are assigned to the port. Change-Id: I23fe45ef08618ad91567feb1707028e0a0bfe0d6 Partially-Implements: ml2-qos commit 53831c685bb6f9897dd384003c1307def062de05 Author: Federico Ressi Date: Wed Jul 15 17:23:22 2015 +0100 Support delegation of bind_port to networking-odl backend driver. The OpenDaylightMechanismDriver delegates bind_port to networking-odl backend driver. Move check_segment toghether with bind_port as is used only there. This will enabled extension of bind_port to support other port types such as vhost-user in a separated patch-set to networking-odl without requiring further changes to the front-end component in neutron. Change-Id: I27948ac0b440b8b4d04e496971593850e78739d0 Closes-Bug: #1477483 Depends-On: Id663147020b9780129c65ba0bb6d743a9de9cd4b commit 5ff3439df5942a9cb150ac4cd3da987e20a31f5c Author: Sergey Vilgelm Date: Mon Aug 10 15:46:27 2015 +0300 Use oslo.log library instead of system logging module The constants of log levels were added in the 1.8 version of the oslo.log library. So we can replace all usage of system logging module with log module from oslo.log. Change-Id: I2992df0bec6337aefa8a75d4853b132bd134fa42 Closes-Bug: 1481370 commit 4ef2dcc106eb8014daf0f94e12db1030eb86aab6 Author: Ihar Hrachyshka Date: Mon Aug 10 08:57:41 2015 +0200 resources_rpc: fixed singleton behavior for ResourcesPullRpcApi __init__ is called for any __call__ on a class, no matter whether it is a singleton. Meaning, client was reinitialized every time a caller instantiated the Rpc class. That's not a critical issue, but a minor performance hit. Change-Id: I24272ba44eb502c8552d3556c84214942944646c Partially-Implements: blueprint quantum-qos-api commit d83375960c3716241dd1d5e60fd773a647be0eda Author: Jakub Libosvar Date: Mon Aug 10 08:37:13 2015 +0000 Add thread locks on port routines for qos ext Only one routine can be executed at one time. Handling port updates or creations is a critical section of qos agent extension. With this patch only one routine can be executed and in case of incoming update/create, execution routine must wait until second routine is done with its job. Change-Id: I28931d2be00dd87a8155a50afe008e03e9699f17 Partially-Implements: blueprint quantum-qos-api commit 09dd8848d3ae309ddfbe9fa7cd1f9abf4442ec7d Author: Moshe Levi Date: Mon Aug 10 10:06:00 2015 +0300 SR-IOV: fixed singletion behavior for ESwitchManager __init__ is called for any __call__ on a class, no matter whether it is a singleton. Meaning, client was reinitialized every time a caller instantiated the ESwitchManager which break the SR-IOV agent when working with agent qos extension. Partially-Implements: blueprint ml2-sriov-qos-with-bwlimiting Change-Id: I31f59e1ee3bbd6bdb039cd149d7a335c692d538d commit 02c80d8e82970922f1f1b1462f8435aed8280a71 Author: venkata anil Date: Mon Aug 10 06:48:52 2015 +0000 Validate local_ip for OVS tunnel When tunneling is enabled in OVS, validate if the IP address in local_ip belongs to the host. Closes-bug: #1408603 Change-Id: I4b4527c28d0738890e33b343c9e17941e780bc24 commit f084686fc61c39cd5034b3dbf92a6001b5a0c887 Author: YAMAMOTO Takashi Date: Sat Jul 4 00:04:35 2015 +0900 db_base_plugin_v2: Avoid creating another session Instead of get_admin_context(), use context.elevated() to avoid creating another DB session. get_admin_context().session creates an independent DB session, while ctx.elevated().session shares the original context's session. Generally it's better to avoid using multiple DB sessions in a single thread as it's a bad idea for various reasons: - They can yield inconsistent views - They can ends up with a deadlock Change-Id: I5ef54cbabab552bad28a147254372b0cdc022832 commit ba23a40a976033c3584b6b730e220311a11fb1d9 Author: Sudhakar Babu Gariganti Date: Wed Jan 21 15:19:03 2015 +0530 Use DeferredOVSBridge in setup_default_table setup_default_table method in br-tun module fires multiple ofctl calls. Using DeferredOVSBridge will help us save us few OVS calls. Closes-Bug: #1259847 Change-Id: I2f01bae5d9efc5c6a6f577e92204c930eb1cf827 commit a7eeab83ebe1023c14cfaab6b8366a6950e3551d Author: Nir Magnezi Date: Sun Aug 2 08:56:56 2015 -0400 Fix get_objects to allow filtering At the moment, an attempt to retrieve a list of objects (like qos policy) and filter by name fails, because get_objects does not use filters and therefore, upon query by object name, the server replies with a list of all created objects (instead of a partial list). Change-Id: I9df9981129b8f3b82e867c8423986f5e0150186b Partially-Implements: blueprint quantum-qos-api commit 5f5be37899d5eb8815729a8677a9ab2247ecb07c Author: Ihar Hrachyshka Date: Sat Aug 8 00:21:09 2015 +0200 QoS core extension: fixed dict extension when QoS policy is unset Previously, if QoS policy was detached from a core resource, core resource extension didn't update the resource dict with the new QoS policy value (None), and that resulted in no notification sent to the agent about the change, so QoS rules were not flushed from the affected ports. Change-Id: I22397af3a43254d146abaa4a4429ac654b4c3c50 Partially-Implements: quantum-qos-api commit a034115e6160d8c2d7e63a1465fea97e1ced03fb Author: Miguel Angel Ajo Date: Thu Aug 6 18:22:36 2015 +0200 OVS agent QoS extension functional test for bandwidth limit rules This functional test spawns the OVS agent, with bandwidth limit rules in a policy attached to ports. Then it asserts that the low level OVS bandwidth limits are set for each port. To make this possible we refactor and extract the base OVS agent test framework into neutron.tests.functional.agent.l2.base. Partially-Implements: blueprint ml2-qos Change-Id: Ie5424a257b9ca07afa72a39ae6f1551d6ad351e7 commit 088289acd23a9fe84e8346c9475976d24efde580 Author: Jakub Libosvar Date: Wed Aug 5 18:15:26 2015 +0000 Propagate notifications to agent consumers callbacks The update policy works. We still need to track down the deletes which don't work currently. Change-Id: I48e04b42c07c34cf1daa17e7a29a6950453946ff Partially-Implements: blueprint quantum-qos-api commit ac3e1e1256402ab014902239a93ecceff76637d1 Author: Jakub Libosvar Date: Mon Aug 3 15:48:02 2015 +0000 Add rpc agent api and callbacks to resources_rpc This patch also refactors existing test cases for server side rpc classes in order to test code in generic manner. Finally, we remove notify() and get_resource() from consumers or producers modules respectively in order to remove circular dependencies. The notificitaion driver will send events directly using RPC api class instead of going through registry. Co-Authored-By: Miguel Angel Ajo Partially-Implements: blueprint quantum-qos-api Change-Id: I9120748505856acc7aa8d15d896697dd8487bb02 commit 11e22a435adc20d65196b937381c5d931130e771 Author: Miguel Angel Ajo Date: Fri Jul 24 02:45:35 2015 +0200 neutron.api.rpc.callbacks interface rework Split rpc.callbacks interface into consumer and producer parts. Better terms are chosen for two RPC APIs we have: - pull when a component actively requests a new object state; - push when a component updates anyone interested about an object change. Also, for callback registration, the following terms are used: - subscribe when a component is registered in consumer registry; - provide when a component is registered in provider registry. Covered the registries with some unit tests. Lots of existing tests utilize the registries now, and need to be isolated from other tests that mess with the managers (that are singletons), so introduced a common qos base test class to mock the manager with per-test instance of it). Co-Authored-By: Ihar Hrachyshka Partially-Implements: blueprint quantum-qos-api Change-Id: I130cfbc8b78da6df4405b90ea1ab47899491ba41 commit d5ee971d713e72ecd4e9465665ba06d9e3051c0e Author: Ihar Hrachyshka Date: Fri Aug 7 08:24:00 2015 +0200 Moved l2/agent_extensions_manager into l2/extensions/manager.py This is to keep manager more close to extensions. Also made some minor renames in ovs agent attributes that seemed more beautiful. Change-Id: Id5a356a595a052d0cf1f57d376ad8289e710a9b3 Partial-Implements: blueprint quantum-qos-api commit 4dd9841186ca258249f111bd68f4abbf748718e8 Author: Ihar Hrachyshka Date: Fri Aug 7 08:15:17 2015 +0200 Moved extensions/qos_agent.py into extensions/qos.py This file does not contain any separate QoS agent but just an extension for existing l2 agents to reuse. Change-Id: I0587d89b0e841e5fd19b91157602efb5aa97513e Partially-Implements: blueprint quantum-qos-api commit d148e68b71852f5cc0994a9137975ecf5393fb92 Author: Ihar Hrachyshka Date: Thu Aug 6 16:59:53 2015 +0200 Introduce base interface for core resource extensions The interface can be found in neutron.core_extensions.base. Adopted the interface in qos core resource extension. Alos moved qos_extension under neutron.core_extensions.qos. Partially, this is to avoid confusion around the fact that the module does not really contain a neutron API extension but core resource extension. Change-Id: I6f6976aa49694f7ef17afa4e93bc769cd0069f65 Partially-Implements: blueprint quantum-qos-api commit 29808803dfa7efb17b213cdf5f055aa2f04a17b2 Author: Ihar Hrachyshka Date: Fri Aug 7 13:56:35 2015 +0200 Don't claim Linux Bridge ml2 driver supports bandwidth limit QoS rules Since we don't want rule_types API to misbehave by claiming support for QoS for linuxbridge ml2 driver, let's trade API test for its service correctness. Note that we cannot enforce the supported rule_types for actual CRUD operations because then we would need to disable the whole API test coverage for rules, and we don't want it. This suggests we should get Linux Bridge support in some way or another. Change-Id: I86197d02d0474fd9a55a09efcce6a7380c08c5e0 Partially-Implements: blueprint ml2-qos commit 06368a001932a748fa78a6bb1f8419a5b78ee515 Author: Ihar Hrachyshka Date: Fri Aug 7 13:50:07 2015 +0200 Clean up QoS rules first, then QoS policies Since policy deletion kills all rules by CASCADE, cleaning rules up after policies is basically no-op. Instead, let's swap the order and in that way implicitly cover rule deletions. Change-Id: Id3a7d8ddf5599a532e3d5609d94522579f85b938 Partially-Implements: blueprint quantum-qos-api commit 23ef0da0fbc335d962bf1e0a4ec60c34394c2782 Author: Ihar Hrachyshka Date: Thu Aug 6 16:50:37 2015 +0200 Revert "Add extension callbacks support for networks" This reverts commit 3de65f57e30b73f5d7efc0344a102f1e40a6b40e. We don't rely on neutron.callbacks anymore to extend core resources, so the patch is out of scope for feature/qos. Change-Id: If611149be19c5c159fc7bd0a4ba2829c11735d52 Partially-Implements: blueprint quantum-qos-api commit f58d14ca02f8a5f6fd441ac55f6ec11afe070c80 Author: Ihar Hrachyshka Date: Thu Aug 6 16:45:17 2015 +0200 Updated quality_of_service devref doc to reflect reality This document will need to get more updates once we start to shuffle code in preparation for merging back into master. Change-Id: I69d1e4b3bab8b62c5d8e45ec6294f4195de7ef83 Partially-Implements: quantum-qos-api commit 81009f6b942e468214db9550d58cda11ecf06545 Author: Moshe Levi Date: Sun Aug 2 12:58:54 2015 +0300 SR-IOV: Update eswitch manager to support rate This patch update the eswitch manager to support max rate on VF, moreover it updates the eswitch manager to be singleton so it can be called from the SR-IOV qos driver. Partially-Implements: blueprint ml2-qos Change-Id: I3e0d0a3fe2effade4e7bcd94018313ab2beb8f28 commit 0e2ce9c5c4cf5a44b32858c1842a3e4bc9a46e37 Author: Ihar Hrachyshka Date: Tue Aug 4 15:29:37 2015 +0200 Follow up with some cleanup for agent qos_driver Removed error handling for missing rule type handler since the rule type is already filtered thru supported types for the backend, so in case the handler is really not present, that's a huge bug in the qos driver extension and should not be handled gracefully. Also fixed some grammar in docstrings. Change-Id: Id157bd1e105051a583fea8e5107326289c551739 Partially-Implements: quantum-qos-api commit 75737c5ef0f7abe8aab80f77336ff9be18494ebc Author: John Schwarz Date: Mon Aug 3 18:33:44 2015 +0300 Gracefully handle duplicate rule creation Previously, creating a second bandwidth limit rule for a policy raised an uncaught exception, which eventually caused 'ServerFault' on the client side. This patch replaces this exception with a NeutronException which leads to a more correct 'Conflict' error instead. Note that the code is implemented in the base object class. This means that future versioned objects will also feature this restriction if their database implies that no duplicate entries can be created. Change-Id: I882d60843e1e651f3f9754746ac670f499431466 Partially-Implements: quantum-qos-api commit 6e3817433e443fd008ef433f54068c197c78465b Author: Oleg Bondarev Date: Wed Aug 5 17:43:02 2015 +0300 Fix: Skip rescheduling networks if no DHCP agents available This fixes commit 1318437a0caf38e695a819848832a955fef7d909 which has inaccurate check for dead agents: in a case where there is only one network scheduled to a subset of dhcp agents, number of all dhcp agents will be not equal to the number of dead binded agents The unit test is updated to cover the described case. Closes-Bug: #1461714 Change-Id: I1c9501316c931293aa8ba755a98779a7da27578d commit a0b2c0f9d1ce515332ba1e42267a17c30a75ea5a Author: Cyril Roelandt Date: Wed Aug 5 11:22:24 2015 +0200 Python 3: do not compare int and NoneType This is an invalid operation in Python 3, even though it works in Python 2. Change-Id: I89d654c6acea10b53d19e50199565badf011e705 Blueprint:neutron-python3 commit df54b0a38c28ea6034b22dcb43491bfd8b84630c Author: huangpengtao Date: Tue Aug 4 11:33:38 2015 +0800 "FakeV4Subnet" class be inherited by following class "FakeV4Subnet" class can be inherited by following class,whick will be better to code Change-Id: Ib76a93da1081812e3ed595c41f5f6c72bdbb6547 commit 1753187d490758238a09827f867a2d6542ee941b Author: Moshe Levi Date: Tue Jul 28 15:46:10 2015 +0300 Update OVS driver to work with objects This patch updates the QoS OVS driver to work with policy NeutronObjects that are passed by the agent extension manager, instead of lists of rule dicts, as we originally expected. It also adds validation that the rules that are sent by the neutron-server are actually supported by the backend. Finally, port dict was not really enough to determine the name of the port in ovsdb. 'name' field is not really present in all port dicts, and does not reflect what is known to ovs anyway. So instead, we should rely on vif_port object to determine the ovs port name. Since ovs agent only added the vif_port value to details dict when binding was desired, I made adding the vif_port object unconditional, and covered that fact with unit tests. With this patch in place, I was able to get policy rules applied to a port in devstack installation. Functional tests will belong to a follow-up. Partially-Implements: blueprint quantum-qos-api Change-Id: I8926adb0a30728e4f82e55d71ad7e76676a22086 commit 7ccc705f6177d9fd198f079e8b57cf44e58b1963 Author: John Schwarz Date: Mon Aug 3 15:49:13 2015 +0300 Add API tests for non-accessible policies Tests which dealt with creating a rule for a policy that the tenant has no access to, or for a policy which does not even exist, were missing. This patch adds them. Partially-Implements: quantum-qos-api Change-Id: I0a2679fa1ccfb7bae6083df9a71c6cb5205a21d9 commit 0c154ca94438e26884770742822728ecde3810e0 Author: John Schwarz Date: Mon Aug 3 16:56:27 2015 +0300 Gracefully handle fetching nonexistent rule Currently, if we invoke the API for 'show rule' but the rule does not exist, an exception is raised from deep within Neutron. This in turns causes an uncaught exception and the user will see 'ServerFault'. This patch proposes a fix for this scenario - the case where the rule does not exist is handled and a NeutronException is caused, causing a proper 'NotFound' error on the client side instead. Partially-Implements: blueprint quantum-qos-api Change-Id: Ic703a0865d1cfa057ab1ad5290b793b22df06af6 commit 651eeb6a5f40e58b7a6b3ccb59826bb6f08827c0 Author: Ihar Hrachyshka Date: Sun Aug 2 23:44:53 2015 +0200 use single transaction to update qos policy associatation To make association changes atomic, use autonested transaction. Change-Id: I582ff43a0ce2f17e3f9fedf7cd32dfbac1ebae28 Partially-Implements: blueprint quantum-qos-api commit 12ff4d6b5890c2fd1e0a3e58f974be3e1f1465ca Author: John Schwarz Date: Mon Jul 27 12:09:10 2015 +0300 Replace to_dict() calls with a function decorator Up until now, API server functions would need to return simple iterable objects, such as dicts and lists of dicts. This patch introduces a decorator which allows such functions to return non-simple objects (as long as the returned object implements the 'to_dict()' method, or is a list of such objects) and converts them on its own, simplifying the user's code and removing code duplication. Change-Id: Ib30a9213b86b33826291197cf01f00bc1dd3db52 commit 2b280a634ecb6f57c44c1d5a34b07e0bdb4d750e Author: Ihar Hrachyshka Date: Wed Jul 29 20:44:54 2015 +0200 Guarantee there is only one bandwidth limit rule per policy Added corresponding db model constraint. Change-Id: I5592d49909408df66e4d01cebbc45204c2be66c1 Partially-Implements: blueprint quantum-qos-api commit c660173edcc137c53bad6194183188bcac3552a1 Author: Ihar Hrachyshka Date: Sun Aug 2 22:40:40 2015 +0200 Cleaned up some TODO comments for feature/qos that do not apply anymore 1. Removed comment to add tests for invalid input for attach/detach methods for QosPolicy. Those tests are already implemented in the test class, so the TODO became obsolete. 2. Removed TODO to use a constant for rule 'type' field. There is no 'type' field in rules anymore, so it does not apply any more. Change-Id: I205cbc2d9a2eeee1a0a9fb5794efc063de6f326d Partially-Implements: blueprint quantum-qos-api commit 336a547aad506ccf69a58e7ac11b9ea12e9f66f9 Author: Ihar Hrachyshka Date: Sun Aug 2 19:17:27 2015 +0200 L2 agent extension manager: read extensions list from config file This effectively disables qos extension in the OVS agent, but we don't rely on it in any functional or fullstack tests so far. To enable the extension, a user should add: [agent] extensions = qos to their openvswitch_agent.ini file. DocImpact Partially-Implements: blueprint quantum-qos-api Change-Id: Icfbf32c36f98cc6e203841b152c7f6fc4f48c20a commit 52f60ba6c7319b139e2d6e17a2d3fa07344786b3 Author: Ihar Hrachyshka Date: Sun Aug 2 17:27:56 2015 +0200 objects.qos.policy: forbid deletion when attached to a port or a network Similar to security groups, we forbid removing a policy that is attached to any port or a network. Change-Id: I0854c8ebc3b690c9195beeca92fe37f1121b410a Partially-Implements: blueprint quantum-qos-api commit cb8fb80a4b62e5d2fb15642c770c3b15495d2bf5 Author: Ihar Hrachyshka Date: Sun Aug 2 17:40:13 2015 +0200 Remove handle_network/handle_subnet from l2 agent extensions L2 agents do not care about networks or subnets, they only care about ports. Change-Id: I3b354765e0efc9fa511421e7acbb937ded1146d8 Partially-Implements: blueprint quantum-qos-api commit 87aa42bc765614750e4f3fab446d03384722133a Author: Ihar Hrachyshka Date: Mon Jul 27 20:53:26 2015 +0200 Moved QOS_POLICY_ID into qos_consts.py Partially-Implements: blueprint quantum-qos-api Change-Id: If789695b4084aed467d5f773c6b6bebea073724d commit f80aa722a664324de1efe453803794a50c9e5cb1 Author: Ihar Hrachyshka Date: Wed Jul 29 13:39:20 2015 +0200 Added missing [qos] section into neutron.conf Also renamed service_notification_drivers into notification_drivers since it's clear where it belongs anyway (it's in neutron.conf meaning it's a server side configuration value). Change-Id: I64610e4b60112daec982a8cacded9b9b936c10bd Partially-Implements: blueprint quantum-qos-api commit 80ff953069dc096383e04350a7013971214e1e5d Author: Ihar Hrachyshka Date: Wed Jul 29 20:34:49 2015 +0200 Enable rule delete test Change-Id: Ic950db35aec66fc0f81070a0641e0473f70d765c Partially-Implements: blueprint quantum-qos-api commit 1f2c05a0b13d429ba6822b2e6acb5b56e10cb0ed Author: Ihar Hrachyshka Date: Wed Jul 29 17:47:21 2015 +0200 objects: consolidate single transaction checks into test_base Cover all base methods with it. Change-Id: I0a6d401f6c1d35cbed397eed79a9aa7db07d179b Partially-Implements: blueprint quantum-qos-api commit 582d03e4642a1eb271c187e65527b0c232548a49 Author: Ihar Hrachyshka Date: Wed Jul 29 15:25:52 2015 +0200 objects.qos.policy: provide rules field, not type specific It should be forbidden to have multiple rules of the same type attached to a policy, so the idea of having per type lists is moot. Instead, we should have a single list of all rules that belong to the policy. Also fixed a test that validated a single transaction to actually work with multiple autonested transactions applied. Partially-Implements: blueprint quantum-qos-api Change-Id: Ia152b3ff385d2aa0cf40664ef039265b046b1d17 commit c9bdcb5557dbf8f782fe502dbb6c98c3550e5241 Author: Ihar Hrachyshka Date: Sat Jul 25 16:21:37 2015 +0200 Unite qos_rules and qos_*_rules tables The only values in qos_rules table are: type, id and qos_policy_id. Both id fields point to qos_*_rules and qos_policies objects. Type is redundant since qos_rule and qos_*_rule objects maintain 1-to-1 relationship. Keeping a separate table just to link qos_*_rule and qos_policy objects has no meaning. At the same time, it complicates the code for rule objects significantly. So instead of copying with all those issues, we just squash the tables into single one. It allows us to reuse all base methods from NeutronObject for rules. LOC stats for the patch clearly shows the point: 65 insertions(+), 267 deletions(-) And no actual functionality is lost. While at it, the following changes were applied: - some base tests are reimplemented to test objects in a more explicit way; - fields_no_update class attribute is now actually enforced in base object class. Partially-Implements: blueprint quantum-qos-api Change-Id: Iadabd14c3490c842608e53ceccf38c79dcdf8d85 commit 3b97f79ab7756a8737df53405b3dd458e79752be Author: John Schwarz Date: Sun Jul 26 16:00:12 2015 +0300 Fix accessing shared policies, add assoc tests This patch is two-fold: 1. Previously, policies that were created using the 'shared=True' flag were not accessible to other tenants, since the context used to search the policies was not elevated. This patch elevates the context prior to retrieving the policy, and if a match was found, makes sure that the user has permissions to access it (either the policy is shared or it's from the same tenant id). 2. Tests for both associations and disassociations of policies to both networks and ports are added in this patch, to make sure coverage is good and that the problem is fixed. Change-Id: Idec13ff4ec575b6d0c0a455c1b3bd9d9700ff7fb commit 11924b11532979090abdba9960dd2dad81debcfe Author: Ihar Hrachyshka Date: Thu Jul 30 13:51:24 2015 +0200 qos: forbid creating rules when there is no access to policy Change-Id: If06de416dfe0eb7115fd4be9feb461fae8e8358d Partially-Implements: blueprint quantum-qos-api commit 3a9c08b80b7f86fa2cd0cbc08de6d1845249ac13 Author: Moshe Levi Date: Wed Jul 15 08:25:38 2015 +0300 SR-IOV: update pci lib to support rate limit Partially-Implements: blueprint ml2-qos Change-Id: I3095f0e8249941f24cbf478cba142135272ebfd3 commit 8c7c33c85678e37da3a40e2167d37f01146ca9cc Author: Ihar Hrachyshka Date: Thu Jul 30 10:46:49 2015 +0200 QosPolicy: made shared field required and with default value = False Change-Id: Icc71ae923d88e2db193d4a33726f8455af4c5dd8 Partially-Implements: blueprint quantum-qos-api commit ef3c74ffa81f1efd53275133cc4012d9b9d11a8d Author: Ihar Hrachyshka Date: Wed Jul 29 17:25:35 2015 +0200 [qos] ovs: removed TODO for getting integration bridge from arguments I don't think it gives us anything if we would push it thru arguments. Change-Id: Ia5f7ce327eb9733faf948f68b5ff30d20df20635 Partially-Implements: blueprint quantum-qos-api commit ec1e812e34339f3d4b2f259a7dd294c5487d8f80 Author: Ihar Hrachyshka Date: Mon Jul 27 16:25:24 2015 +0200 Load the QoS notification driver from the configuration file The agent based RPC notification driver for message queue is the default. Added support for multiple notification drivers. DocImpact Partially-Implements: blueprint quantum-qos-api Change-Id: I4108c3d111067d8217bc4112c05e1bde0125e0ef commit 01e9b771031bd83c12f5ca2f1725927e70050763 Author: Eran Gampel Date: Wed Jul 1 18:32:30 2015 +0300 Add pluggable backend driver for QoS Service notification Added a reference driver for the agent based solutions RPC sending the messages over the message queue Partially-Implements: blueprint quantum-qos-api Change-Id: I725c876739ff85b4db8fb053de0362ce367ae78c commit e7ef7cace1da95e43401a086f314c3cb89d9fc9d Author: Ihar Hrachyshka Date: Mon Jul 27 14:43:56 2015 +0200 Add update tests for policies and rules This patch adds tests for 'update' for both policies and rules. This completes the CRUD tests and leaves the association/disassociation for a later patch. Note that deleting a rule isn't tested explicitly because of a bug with the rule delete logic on the server side. Once that code is fixed, the test should be added. to_dict() for policies should also convert any rules inside rule lists to dicts too, otherwise API layer receives rule object __repr__ strings instead of actual dicts. This patch introduces a fix to the existing to_dict() code to properly support policies. This patch also modifies the base infra to create policies and rules for admins and not for tenant. Partially-Implements: blueprint quantum-qos-api Change-Id: I13870680d7756be9dd020135bc8e91d1c12f728d Co-Authored-By: Ihar Hrachyshka commit 12f7abd3982d3580abdb9055c650bdad50900cf4 Author: Ihar Hrachyshka Date: Thu Jun 11 08:11:08 2015 +0200 Introduce mechanism to determine supported qos rule types for a plugin Every plugin that supports some of QoS rules will define a property called supported_qos_rule_types of list type. For ml2, determine supported qos rule types as a subset of rule types supported by all drivers. (In the future, we may expand the list to include all types supported by at least one of enabled drivers. This would require synchronized work with nova scheduler though.) For ml2, tests are limited, and should be expanded to check that common subset of qos rules is calculated properly when intersection != the list of each plugins. For now, it's enough since we don't have more than one rule type planned for Liberty. Added API test for the resource. Partially-Implements: blueprint ml2-qos Co-Authored-By: Irena Berezovsky Co-Authored-By: John Schwarz Change-Id: I0d18ae256877a129e203110003fcadd1d63590b4 commit a798840a40c3ec00d2b27edb772328403d1376c9 Author: Ihar Hrachyshka Date: Mon Jul 27 15:13:43 2015 +0200 get_info: request object backport only if desired version is different Partially-Implements: blueprint quantum-qos-api Change-Id: I93fde3c472e4ecd7af8a7ce50be832b7216e40f6 commit 612ffff9aff93e3e41c549097a1249f2ea37a8e0 Author: Ihar Hrachyshka Date: Mon Jul 27 13:51:36 2015 +0200 rpc.callbacks.registry: validate that callback provider is registered Partially-Implements: blueprint quantum-qos-api Change-Id: I05e1902c75e4ce5de7f88f5d6281934a3a9a84ac commit 92d94bf020ede2a37c3c966c9ac7ed68b139cccd Author: Ihar Hrachyshka Date: Sat Jul 25 21:35:44 2015 +0200 rpc.callbacks.registry: validate type of callback result Enforce appropriate type for the object returned by rpc callback. Partially-Implements: blueprint quantum-qos-api Change-Id: I994253ac15320254104862d2df8dacfc7fc00014 commit c240d381dc281e542f32045174333dd6909b44d2 Author: Jakub Libosvar Date: Tue Jul 14 14:48:28 2015 +0000 Add UT for agent_extensions_manager Partially-Implements: blueprint quantum-qos-api Change-Id: I86cf669dabbdad9680b6739d59e0f81a74c8629f commit 9193048edf186d90739ff2e1b3d9737fc3ba06fb Author: Ihar Hrachyshka Date: Sat Jul 25 17:42:23 2015 +0200 Don't set tenant_id for rule objects There is no such field anyway. Partially-Implements: blueprint quantum-qos-api Change-Id: Iac895d7eff8dc4f34b56007a48fa6fc64535fca3 commit fd0bf111838b90dcf76d670987770835904810fb Author: Jakub Libosvar Date: Tue Jul 21 11:17:18 2015 +0000 QoS: Remove type attribute from QoS rules The type is given by object itself. We don't specify type when creating resource cause it's a part of uri. This patch allows a bandwidth_limit_rule to be created in given policy. Partially-Implements: blueprint quantum-qos-api Change-Id: Ica4626083054200e3b82bef23984462e7c596e1e commit 5c21e5d826f7e7d184224f3817d8b5ee7346ee9b Author: Ihar Hrachyshka Date: Sat Jul 18 15:47:26 2015 +0200 Don't enforce qos ml2 extension driver It's now enabled in gate for feature/qos, so return to the original version of the code. Depends-On: I421c42aef2cf558935f91a6634a5a5b16e55a606 Change-Id: I5875fb24b7c95efb3bd7cd548bd5d9d21d6544ba commit 301ffb02ecccdddfee361ee6738b7ff84d7cc0d8 Author: Ihar Hrachyshka Date: Fri Jul 24 17:31:50 2015 +0200 ml2: added qos_profile_id to get_device_details payload This is needed to make l2 agent qos extension determine which rules to apply to the port, if any. Partially-Implements: blueprint quantum-qos-api Change-Id: Idefa819f9a21cf53762b1fb923dafb63f2b256e0 commit d2259240bb06f2e1d82465d3ddc0ee7073795087 Author: Moshe Levi Date: Thu Jul 9 13:21:49 2015 +0300 Add versioned object serialize/deserialize for resources RPC Also switched RPC callback API to consistently receive resource_type string and not a resource class. This is because for get_info(), we cannot propagate a class thru RPC but only a string that uniquely identifies the class. So it would be not optimal to require the server to discover the corresponding class from the type name passed from the agent. Also updated some comments in api/rpc/callbacks directory to reflect that we handle NeutronObjects, not dicts. Finally, killed the rule resource registration from QoS plugin and the rule type from supported resources since it's YAGNI at least now. Partially-Implements: blueprint quantum-qos-api Change-Id: I5929338953a2ad7fa68312d79394a306eb0164a2 commit 9599e748cafd504d469a0e225e37ede18345d5ee Author: Ihar Hrachyshka Date: Tue Jul 21 15:37:33 2015 +0200 policy: made attach_* and detach_* methods more robust Handle cases when a policy or a port or a network are not in the database without exposing database level exceptions to object consumers. Change-Id: I06a0b5c4f474b370072f2b6a13146f17a51eb847 commit 7ed1d4f61635e67d0a554ed34540a03222c3f9d3 Author: Jakub Libosvar Date: Tue Jul 21 08:04:00 2015 +0000 Support qos rules and fields parameters in GET requests Previously we didn't load the rules into policy object. This patch adds loading the rules and defines bandwidth_limit_rules as a policy resource in a single transaction. As a part of moving towards usage of single transaction, create() and update() of rule were modified accordingly. Finally, we support types in GET requests in this patch. API tests will follow in different patch. Change-Id: I25c72aae74469b687766754bbeb749dfd1b8867c commit 15b524c0d8e6b723fc5c9861ec6332b785039ff2 Author: Jakub Libosvar Date: Tue Jul 21 11:26:42 2015 +0000 Pass context when deleting bandwidth limit rule Context was missing in db_api leading to crashing when creating transaction. Change-Id: Ib4355481a51c9c568ab821c45b2c6fe863a594dd commit 69f4b813e8a086512f39ee3ef5b8f3354f9af8c0 Author: Ihar Hrachyshka Date: Tue Jul 21 15:05:33 2015 +0200 [qos] cleanup _find_object from neutron.db.api Instead of having a separate function for id-based search, make get_object accept any kwargs, including id=, and reuse it everywhere where we used _find_object before. Change-Id: Ibd94c41fb847d67aabb94172d0117bafc0fdbdf6 commit 517cf5b843922b6a789c4d4fd1381444acbb91d2 Author: Ihar Hrachyshka Date: Wed Jul 22 12:53:00 2015 +0200 Revert "Mute neutron.callbacks notification logs." This reverts commit e19eb49c1c066c8fa4a3c19183bca1daef553a5c. We don't use callbacks to extend resources, so no need to mute the logs. Change-Id: I8eaffa243f74a8f93dfc1638727ac9cd0bdf505d commit 5d58a6877336089ccd89acee6edc2b7c9ee9ee3c Author: Ihar Hrachyshka Date: Wed Jul 22 12:54:53 2015 +0200 qos: kill get_namespace() from service plugin Its usage was removed as of I3c406910991c33cf959c5345d76153eabe3ace2d that is now included in feature/qos branch. Change-Id: Iddab10729cf12e3b7425c5d2298f2a6b3436289c commit e467fb3f5bc3ae925838ad3fc8a7a41185a9c4c1 Author: John Schwarz Date: Tue Jun 30 17:57:19 2015 +0300 Base infrastructure for QoS API tests This introduces the basic methods in the tempest client, that allow the testing of the QoS plugin. This also contains 2 (very) simple tests which test creation and deletion of both policies and bandwidth rules, as well as list/show for both resources. While creation is done explicitly, deletion is done implicitly (all resources are deleted after the test, during tearDown) Minor fixes to the QoS plugin are included as well. Change-Id: I0f34ed8464857859bcd519e301a49b0b067593b0 commit 95e2b53a7bf9fd162960389fec7dfc97b1729c50 Author: Hirofumi Ichihara Date: Thu Jul 23 00:47:38 2015 +0900 Remove line number of link and useless link Some line numbers are wrong. This patch removes the number since the source which link points can be changed very frequently. The patch also removes useless links. Change-Id: Ie18f8567893975d4946888d114f0ae2666b56a65 commit 1ba38bfd3f4e505d53c40f3e1bee603bfc705b64 Author: sridhargaddam Date: Mon Jul 13 14:00:20 2015 +0000 Disable port creation when invalid MAC address is provided When a port is manually created with an invalid mac address like '00:00:00:00:00:00' and associated to neutron router, we see an exception in L3-agent logs. Since we do not have any valid use-case to have a port with a mac_address of all zeros, this patch disables the corresponding port creation/updation request. Along with all zeros MAC, validation aganist broadcast MAC is also included in this patch. DocImpact Closes-Bug: #1472243 Change-Id: I93875716550dbc1f299aee95c45144e4904af233 commit e82b0e108332964c90e9d2cfaf3d334a92127155 Author: Swaminathan Vasudevan Date: Tue Apr 28 22:50:31 2015 -0700 Fix gateway port could not retrieve for subnet In DVR routers when a port is added to a router, then the command succeeds but the l2 ovs agent raises an error stating that it could not retrieve the gateway port for the subnet. The reason for this is there is mismatch in the ip_address returned from the subnet for the gateway port and the actual ip_address of the port that we added to the router. Since the subnet info was passed to "get_subnet_for_dvr" this mismatch was seen. Instead of passing the subnet we will be passing the actual fixed_ips with all the details and the subnet gateway port will be filtered based on the ip_address in the fixed_ips passed. Closes-Bug: #1404823 Change-Id: I87a3983951f814350e79f5e2274f4639bb6bc0f5 commit ea02f25fbef43580c619eb778aab3dc874427eef Author: Moshe Levi Date: Wed Jul 15 11:13:50 2015 +0300 Update OVS Agent to work with Agent Extension Mgr Change-Id: I1887d402a4377babb648182727cf51b9f2627e1c commit c22cce92f8cc93392e07124d00771c3c5a962cba Author: Jakub Libosvar Date: Thu Jul 16 14:23:26 2015 +0200 Instantiate qos agent driver Change-Id: Icd8a725f231e2749bb81da0bcad0f7ef95beb676 commit ddd9ee9a4c1dc36b405cb4cb854bb1b46ed32e98 Author: Ihar Hrachyshka Date: Thu Jul 16 15:15:11 2015 +0200 objects.rule: enable database tests for QosRule While at it, simplified inheritance mess in test_policy. Change-Id: I6cf2394a27f8bb29a18c99effe2dc2251c138d59 commit 0395f142031bb200373b439c7798629eee1321eb Author: Mike Kolesnik Date: Wed Jul 15 10:44:15 2015 +0300 Handle qos_policy on network/port create/update Added handling for qos_policy_id field in the network and port entities via ML2 extension driver. The QoS profile will be associated to the network/port when requested as part of the entity creation or update. Allow ML2 extension manager to not register for any api extension (new use case). === Extend the resources using the QoS extension class Since the QoS extension for plugins is handles by this class, it makes sense for it to handle also property extension of resources. For ML2 this means that that extend_{network,port}_dict functions will handle the extension of resources by calling QosExtensionHandler. This logic can easily be reused by other plugins. Note: we should make sure that resource extension does not require db access, otherwise we see DBDeadLock errors and random tempest failures. To achieve this, we define a new SQLAlchemy joined relationship on policy bindings to make networks and ports receive those bindings on their fetch from database. After that, the only work to do left for resource extension handler is to copy the fetched policy into resource dictionary. === Also enable new qos ml2 extension until we configure it in gate via project-config and devstack-gate to make sure it's enabled and tested. Co-Authored-By: Ihar Hrachyshka Partially-implements: blueprint quantum-qos-api Change-Id: I1b7d4611215a471d5c24eb3d7208dcddb7e015f4 commit 0a33e355bcfb0a44ad3617f659ab452a04abdbdb Author: Ihar Hrachyshka Date: Fri Jul 10 18:00:34 2015 +0200 objects.qos.policy: support per type rule lists as synthetic fields This is a significant piece of work. It enables neutron objects to define fields that are lazily loaded on field access. To achieve that, - field should be mentioned in cls.synthetic_fields - obj_load_attr should be extended to lazily fetch and cache the field Based on this work, we define per type rule fields that are lists of appropriate neutron objects. (At the moment, we have only single type supported, but I tried hard to make it easily extendable, with little or no coding needed when a new rule type object definition is added to rule.py: for example, we inspect object definitions based on VALID_RULE_TYPES, and define appropriate fields for the policy object). To implement lazy loading for those fields, I redefined get_by_id for rules that now meld fields from both base and subtype db models into the corresponding neutron object. Added a simple test that checks bandwidth_rules attribute behaves for policies. Some objects unit test framework rework was needed to accomodate synthetic fields that are not propagated to db layer. Change-Id: Ia16393453b1ed48651fbd778bbe0ac6427560117 commit 6140da5f25da126cdbfae3e9ee397315e7834fc5 Author: Miguel Angel Ajo Date: Tue Jul 14 14:31:55 2015 +0200 QoS Service devref This is initial version that should be ready for merge. After we get it in the tree, we'll be able to expand on demand or even as part of patches that change the implementation in significant way. Co-Authored-By: Ihar Hrachyshka Change-Id: I3d89bcbb9c64b87d7425155c33b2f753176e94fd commit 4af0de954aabb51560d4c28f8ea246a53d214b20 Author: Mike Kolesnik Date: Tue Jun 30 12:07:48 2015 +0300 Implement QoS plugin Initial implementation of the QoS service plugin that just implements CRUD for policy and rule. There are no tests yet. path_prefix is now provided as an attribute to the plugin base, since that's required by the COMMON_PREFIXES removal from master branch. Partially-implements: blueprint quantum-qos-api Change-Id: Icf821dec17f435d8e47e1047fb05225e7dd071f0 commit bcb4d237a79be9af18f1bcc792e1827c18b058d2 Author: Kevin Benton Date: Thu Jul 16 02:07:48 2015 -0700 Add oslo db retry decorator to non-CRUD actions The previously added decorators to the create and update handlers in the API layer only applied to actions that followed the standard create/update path. However, for API operations like add_router_interface, a different path is followed that wasn't covered by a retry decorator. This patch adds the decorator to handle deadlocks in those operations as well. Closes-Bug: #1475218 Change-Id: Ib354074e6a3f68cedb95fd774f905d94ca16a830 (cherry picked from commit 435ffa7c67cf8668063588e2af760c1ff595dfbb) commit a1c05891a52fba19dec1122e25144446ee8717ae Author: Jakub Libosvar Date: Tue Jul 14 12:42:57 2015 +0000 Add qos section to ovs agent config [qos] section is introduced with qos driver for ovs agent. Similar manner should follow for all l2 agents using qos with different default drivers. Change-Id: I3c6a3711d3cd9924d55cf6d0ed84be18c993c275 commit e19eb49c1c066c8fa4a3c19183bca1daef553a5c Author: Miguel Angel Ajo Date: Wed Jul 15 15:42:52 2015 +0200 Mute neutron.callbacks notification logs. We believe they could be the source of some yielding, and consequient DBDeadlocks we're experiencing when using AFTER_READ to extend resources. This will need to be revised. Change-Id: I040b3a3c9e137267dfe237dd90fb525026b0d16e commit 1ec79bad468f65d0adfb16f652170f059c92a3bc Author: Jakub Libosvar Date: Wed Jul 15 15:47:40 2015 +0200 Small fixes in test_qos_agent UT Change-Id: Ib09824552edd287ec1df3bdd6700c9ce8a02df29 commit 3cbe446cb6db0ee18c928bb3ec1ff688db5febd4 Author: Gal Sagie Date: Tue Jul 14 17:37:08 2015 +0300 Add unit tests and fixes for OVS Agent QoS Extension Driver Add basic unit tests and fix some of the issues while doing the tests blueprint ml2-ovs-qos-with-bwlimiting Change-Id: I3962dd2c0e1273905781faf3f5c51886dea21cd4 commit cdcffc709baa3290934e6fc3e7f87862dbbbe0e1 Author: Gal Sagie Date: Wed Jul 1 15:36:51 2015 +0300 Add OVS QoS extension agent driver This is a prototype for the OVS agent driver for QoS extension. Should be adjusted to final API's once they are added blueprint ml2-ovs-qos-with-bwlimiting Depends-On: I9e388173dfe0eb43c961018bd687bc86f34c7a6a Change-Id: Ie952b63e3760d1924a34676e97319ec4301effca commit 9544ffb615f69f25268f0f2fd3d92ca4acc7d8cb Author: Moshe Levi Date: Wed Jun 24 18:44:08 2015 +0300 Qos Agent Extension This patch introduces the following: QosAgentExtension - implementation of AgentCoreResourceExtension QosAgentDriver - interface class This will allow any agent to implement their own low level driver for Qos Agent Extension. Co-Authored-By: Miguel Angel Ajo Change-Id: I9e388173dfe0eb43c961018bd687bc86f34c7a6a commit dd6cd44b2155605345a6925d3373bb6afe0bcf62 Author: Miguel Angel Ajo Date: Thu Jul 9 16:39:05 2015 +0200 Implement QoS policy detach from port and network Includes db.qos.api calls to delete port<->qos_profile and network<->qos_profile bindings. Change-Id: I8ab3e885bdf010fe95529157f3db4f1089326c86 commit 6f3b70b5061af332c7accd348ec31b453c272e98 Author: Irena Berezovsky Date: Tue Jul 7 11:54:39 2015 +0000 Add API stub for QoS support rule_type resource Rule_type is added as an API Resource. Using this API User can get list of supported QoS rule types. Change-Id: Ica80753ce3052b68ba8db2d2760ed4310ec0b976 commit 954e9de8b3b697b39e087f2d03b49f0856c44c32 Author: Ihar Hrachyshka Date: Thu Jul 9 14:12:56 2015 +0200 objects.base: fixed object.delete() It was using wrong call to delete an object from a session. Also, expanded test_create() test to check all basic operations: get_by_id, create, update, and delete. To facilitate update() check, introduced a new field for objects called fields_to_update that stores names of fields that are not expected to be updated in an object. This allows us to keep the above mentioned test untangled from specific object type. Also made get_by_id() behave correctly (returning None) if the object does not exist. Change-Id: I1aecb2e7c4d8cb8f239072d1cb9df3db29dcedde commit 31e09028e3b3c85954a9aebf32c412bd897afdbb Author: Ihar Hrachyshka Date: Thu Jul 9 12:37:01 2015 +0200 objects.qos.policy: fixed get_*_policy and attach_* methods Added sql unit tests for those methods. Change-Id: I6e95aa6cb61d5cc36600394b2198587793da8a0e commit 3edec57c2250daafdcdac88581efa1acc5acf237 Author: Ihar Hrachyshka Date: Wed Jul 8 18:06:12 2015 +0200 objects.base: reset changes after getting objects from database Now all objects are comparable. We need to reset changes, otherwise an object that is constructed and .create()d is different from the one that is .get_by_id()d from database (for primitive serialization contains list of changed fields for versioned objects). Added initial sql test case for objects (just create-fetch for policy for now, but can be easily extended to other types). Change-Id: I012b5fe4e95f166f66da91274734d7184c224dfd commit 78703ddefbbf93dda8ecb173f14086880bb9f82f Author: Ihar Hrachyshka Date: Wed Jul 8 17:47:12 2015 +0200 BaseObjectTestCase: rename test_class into _test_class It seems that testtools are trying to load that class as if it's a test case (for it considers everything inside a test class named as test_* as a test case). Change-Id: Ic4342cc0637d659191f084467ccdb9c90e89a023 commit 00589382cf1ea7034d5dee5aec8bf3814f7e92a5 Author: John Schwarz Date: Thu Jul 2 12:40:11 2015 +0300 Cleanup rule models and objects - drop tenant_id for base and bandwidth_limit rules; - added 'to_dict' function to convert objects into dicts. Change-Id: I28167e356e70235304b166c997df52ca1b28f836 commit a71cb067d0100a1ec3f6df037c6c4740a6b2771a Author: Ihar Hrachyshka Date: Fri Jul 3 01:57:03 2015 +0300 objects.qos: fixed create and update for QosBandwidthLimitRule To simplify Qos*Rule object type implementation, renamed 'qos_rule_id' field for qos_bandwidth_limit_rule table into 'id'. Also added unit test coverage for the object type. Change-Id: Id6bc992af9f1ab46c022d3c88aa66a0f3bb7f227 commit cbc7826f2c0b77f1283ed62a3adb332c639cbdd5 Author: Ihar Hrachyshka Date: Fri Jul 3 00:52:20 2015 +0300 objects.qos: added unit tests for QosPolicy neutron object Change-Id: Icecb3fc08c81bd9fb9f8bad54ed800a4eb55d399 commit 878e85527fa6833a85d7d9ad15e63e26aeb00ccd Author: Ihar Hrachyshka Date: Thu Jul 2 23:30:36 2015 +0300 objects.base: avoid db access if object does not have changes Also cover base object with unit tests. Change-Id: I2f58c767ba35eeee2f9ecc363e5b042ea8638faa commit 4ee9eebd7dd5ed7c87d481eda500b664ae564644 Author: John Schwarz Date: Thu Jul 2 12:32:05 2015 +0300 QoS extension fixes This patch introduces small fixes to the QoS extensions: 1. Adding a common tenant_id field for QoS API calls. 2. Making sure the function interface is correct. Co-Authored-By: Irena Berezovsky Change-Id: If9c7a7b9b8a5d2367d8f3225fbf07d8e3ec8865d commit c26142be338ef14f5fd0a4c7aa5b4ac42bc685d1 Author: Moshe Levi Date: Wed Jun 24 18:10:05 2015 +0300 AgentExtensionsManager and AgentCoreResourceExtension This patch introduces the following classes: L2Agent - abstract class for common L2Agent implementions. AgentExtensionsManager - to load AgentCoreResourceExtension. AgentCoreResourceExtension - interface class to define the AgentCoreResourceExtension API. This allows better segregation between L2 Agent Core and L2 Agent Extensions. The patch is missing unit test but it was tested manually. I added a unit tests @TODO comments to come back to them later. Change-Id: I813de7ff1bee188f4294f4b3eb3645ebd903297b commit 2d38c742e84aebccd367eb7312ddaaeb0d02bc01 Author: Moshe Levi Date: Tue Jun 30 22:23:26 2015 +0300 Generic Resources RPC This patch adds Generic Resource RPC from agent to server. Change-Id: I0ac8a009e781b6edb283d8634b1a2f047db092dc commit dc802438887265c1faa0a92df7c7c701854cf5fc Author: Miguel Angel Ajo Date: Thu Jun 11 15:21:28 2015 +0200 Generic rpc callback mechanism which could be reused This is a publisher/subscriber messaging mechanism optimized for agent consumption and server production without the need of creating new rpc messages when new resources are introduced. Oslo versionedobjects are the perfect match to ensure cross version compatibility even if the published/subscribed resources format change over time. This is still a basic stub allowing get_info of the resources, and the next change will introduce the RPC methods to call get_info: I0ac8a009e781b6edb283d8634b1a2f047db092dc The plugin is returning stub objects to be consumed from the agent to test the basic behaviour until we have DB. TODO: Update documentation, according to code changes, enforce versioned objects only doing deserial/serialization. Co-Authored-By: Miguel Angel Ajo Co-Authored-By: Eran Gampel Change-Id: I524cf5a14e99dc6bee4d4261557d98c75efa0809 commit e3dba1424114575581c153e02227282e036ad0a2 Author: Miguel Angel Ajo Date: Fri Jun 19 16:43:52 2015 +0200 Introduce the AFTER_READ callback for ports and networks This callback can be used by extensions and service plugins to extend port and network information on read time, without the need of plugin mixins. Partially-implements: blueprint quantum-qos-api Change-Id: Ifc92c19a69d28784c030d605c2eb161c2ba4b3f5 commit 3de65f57e30b73f5d7efc0344a102f1e40a6b40e Author: Mike Kolesnik Date: Tue Jun 30 15:21:30 2015 +0300 Add extension callbacks support for networks Add callbacks for extention to the network resource so that interested extensions can do custom logic when a network is created or updated. Currently it will be done the same way port notifications are done - i.e. only in ML2 plugin. We can revisit this in a floow up patch if the whole notification logic should be moved somewhere else as this merits further discussion which is out of scope for a mere patch. This will be utilized in a follow up commit. Partially-implements: blueprint quantum-qos-api Change-Id: I38528863e1145caf05fe3b2425511d1c5b5c0f93 commit b167ec6d4f5577c54a1a02e6a835b875a6e2150a Author: Ihar Hrachyshka Date: Thu Jul 2 11:14:17 2015 +0300 [qos] policy: add methods to interact with policy bindings Detachment is not supported in this patch. blueprint quantum-qos-api Change-Id: I66f87b99241a25d39d08c124bae3779c872bc567 commit e90b28662eb769e26f2f6c202a71910819c3ff41 Author: Ihar Hrachyshka Date: Tue Jun 30 13:32:27 2015 +0300 First QoS versioned objects, ever Well, first versioned objects in the tree. Binding to networks and ports is not implemented. No tests. Checked manually. blueprint quantum-qos-api Co-Authored-By: vikram.choudhary Change-Id: I9b6cacfda4f40230d746222bed5b6c490be63743 commit 3d6666af4921a28ccb95d25d88087e89e23e3ec5 Author: Gal Sagie Date: Wed Jul 1 19:15:55 2015 +0300 Add bandwidth_limit rule type constant Change-Id: I7228b3a288848833947271a0966ca415bfaa07c4 commit 3e2ef95dfdfe19a0097f8d68f453cbabbb8f2169 Author: Irena Berezovsky Date: Tue Jun 30 12:04:39 2015 +0000 Add bandwidth_limit rules as sub-collection of qos policy This patch add support for qos extension according to the spec modification [1]. [1] https://review.openstack.org/#/c/197004/ Change-Id: I9226932191464face6e20625e35ad4b7529db4ca commit 4310b4c2a68914aa78275a78f882c70eb57c1fde Author: Ramanjaneya Date: Wed Jun 24 17:24:11 2015 +0530 QoS: db models and migration rules This patch includes db models and migration rules for initial QoS objects. Comparing to the spec, it adds two more service tables to maintain links between networks and ports and their respective policies. We maintain uniqueness as a unique constraint. In some parallel world, we could have an additional field for networks and ports that could be nullable to point to a policy. That said, it breaks qos isolation a bit, and will also be a bit more painful if and when we decide to spin out qos service pieces outside the tree. blueprint quantum-qos-api Co-Authored-By: Ramanjaneya Co-Authored-By: vikram.choudhary Co-Authored-By: Ihar Hrachyshka Co-Authored-By: Miguel Angel Ajo Change-Id: I55a7dac602e2e770c21b6c7957430cb7115e5bdc commit be1d242fa3efcef9e7095fbbf0e2de022fa86a45 Author: Gal Sagie Date: Sat Jun 27 13:16:11 2015 +0300 Add Create/Destroy API to OVS QoS BW Limiting Add infrastructure needed for the implementations (CLI and native) and add API to ovs_lib Add functional tests for ovs_lib blueprint ml2-ovs-qos-with-bwlimiting Change-Id: Ided0740548987ca91f1549f251c7906e6449f91d commit b17f865f85fddafaab367f55470c2b7ae8135e62 Author: Ihar Hrachyshka Date: Wed Jul 1 10:42:09 2015 +0300 docs: link quality of service doc stub to devref index Since I433126a8247e7e1c316f2c96bb21e15582b247ce, doc warnings are considered as failures in gate. Unlinked .rst file generates one, making docs job broken for feature/qos. Same for an empty file with no title. Change-Id: Iba82d9728e99238bcc55b12f0ab9eb936fd62147 commit 2ff19be1db96f97b833052af633abda55f497f1d Author: Miguel Angel Ajo Date: Fri Jun 19 16:45:13 2015 +0200 QoS service plugin stub This patch introduces the QoS service plugin which implements a stub of the API extension. This is patch is a basic step to be able to create an experimental job enabling this service so we can do api tests. Change-Id: Ib583e98c232ca628ba2a4bd48527eb84584c6212 commit 96d1cb1ae2f0188988102a56c2886870af94d88e Author: Miguel Angel Ajo