Replace dict.iteritems() across modules in networking-cisco repo

Bug #1463560 reported by Saksham Varma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-cisco
Fix Committed
Undecided
Saksham Varma

Bug Description

pep8 runtests: commands[1] | flake8
2015-06-08 19:15:30.744 | /home/jenkins/workspace/gate-networking-cisco-pep8$ /home/jenkins/workspace/gate-networking-cisco-pep8/.tox/pep8/bin/flake8
2015-06-08 19:15:32.434 | ./networking_cisco/tests/unit/cisco/l3/test_l3_router_appliance_plugin.py:136:9: N327 Use six.iteritems() instead of dict.iteritems().
2015-06-08 19:15:32.434 | for resource, attrs in attributes.RESOURCE_ATTRIBUTE_MAP.iteritems():
2015-06-08 19:15:32.434 | ^
2015-06-08 19:15:32.434 | ./networking_cisco/plugins/cisco/db/l3/device_handling_db.py:484:13: N327 Use six.iteritems() instead of dict.iteritems().
2015-06-08 19:15:32.435 | for key, value in filters.iteritems():
2015-06-08 19:15:32.435 | ^
2015-06-08 19:15:32.619 | ./networking_cisco/plugins/ml2/drivers/cisco/ncs/driver.py:175:13: N327 Use six.iteritems() instead of dict.iteritems().
2015-06-08 19:15:32.619 | obj = dict((self.escape(k), self.escape_keys(v))
2015-06-08 19:15:32.620 | ^
2015-06-08 19:15:32.620 | ./networking_cisco/plugins/ml2/drivers/cisco/ucsm/ucsm_network_driver.py:469:9: N327 Use six.iteritems() instead of dict.iteritems().
2015-06-08 19:15:32.620 | for host_id, value in self.ucsm_host_dict.iteritems():
2015-06-08 19:15:32.620 | ^
2015-06-08 19:15:32.725 | ERROR: InvocationError: '/home/jenkins/workspace/gate-networking-cisco-pep8/.tox/pep8/bin/flake8'
2015-06-08 19:15:32.725 | ___________________________________ summary ____________________________________
2015-06-08 19:15:32.725 | ERROR: pep8: commands failed

Tags: l3 ncs nexus ucsm
Saksham Varma (sakvarma)
Changed in networking-cisco:
assignee: nobody → Saksham Varma (sakvarma)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (master)

Reviewed: https://review.openstack.org/189932
Committed: https://git.openstack.org/cgit/stackforge/networking-cisco/commit/?id=2814776d57e0e884e0ad8a0204b5bb49d6abd4c8
Submitter: Jenkins
Branch: master

commit 2814776d57e0e884e0ad8a0204b5bb49d6abd4c8
Author: Saksham Varma <email address hidden>
Date: Tue Jun 9 13:45:45 2015 -0700

    Fix more pep8 and py27 failures due to neutron core changes

    pep8 failed since dict.iteritems() is not Python3 compatible.
    This fix replaces these calls with six.iteritems(dict)

    py27 failed due to olso.config not allowing config files to
    end in .test, see https://review.openstack.org/189646

    Co-Authored-By: Henry Gessau <email address hidden>
    Closes-Bug: #1463560

    Change-Id: I5b408a6b99595e02c6188c752379e8b1a672ae42

Changed in networking-cisco:
status: New → Fix Committed
Sam Betts (sambetts)
Changed in networking-cisco:
milestone: none → 2.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.