TypeError: LocalVlanManager.get() missing 1 required positional argument: 'segmentation_id'

[Corey Bryant]

Several unit tests are failing for master branch (zed) due to:

======================================================================
FAIL: networking_bagpipe.tests.unit.agent.bgpvpn.test_agent_extension.TestOVSAgentExtension.test_port_with_prefix_route_then_delete_port
networking_bagpipe.tests.unit.agent.bgpvpn.test_agent_extension.TestOVSAgentExtension.test_port_with_prefix_route_then_delete_port
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/neutron/tests/base.py", line 182, in func
    return f(self, *args, **kwargs)
  File "/<<PKGBUILDDIR>>/networking_bagpipe/tests/unit/agent/bgpvpn/test_agent_extension.py", line 1453, in test_port_with_prefix_route_then_delete_port
    self._port_assoc_notif(port_assoc, rpc_events.CREATED)
  File "/<<PKGBUILDDIR>>/networking_bagpipe/tests/unit/agent/bgpvpn/test_agent_extension.py", line 227, in _port_assoc_notif
    self.agent_ext.handle_notification_port_assocs(
  File "/usr/lib/python3/dist-packages/oslo_log/helpers.py", line 67, in wrapper
    return method(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/oslo_concurrency/lockutils.py", line 395, in inner
    return f(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/networking_bagpipe/agent/bgpvpn/agent_extension.py", line 419, in handle_notification_port_assocs
    self._add_association_for_port(port_info, port_assoc)
  File "/usr/lib/python3/dist-packages/oslo_log/helpers.py", line 67, in wrapper
    return method(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/networking_bagpipe/agent/bgpvpn/agent_extension.py", line 458, in _add_association_for_port
    self._add_association_for_net(port_info.network.id, assoc,
  File "/usr/lib/python3/dist-packages/oslo_log/helpers.py", line 67, in wrapper
    return method(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/networking_bagpipe/agent/bgpvpn/agent_extension.py", line 346, in _add_association_for_net
    self._gateway_traffic_redirect(net_info)
  File "/usr/lib/python3/dist-packages/oslo_log/helpers.py", line 67, in wrapper
    return method(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/networking_bagpipe/agent/bgpvpn/agent_extension.py", line 676, in _gateway_traffic_redirect
    vlan = self.vlan_manager.get(net_info.id).vlan
TypeError: LocalVlanManager.get() missing 1 required positional argument: 'segmentation_id'

Support is required for a recent change introduced to neutron:

6ec0bc70a79 (Sahid Orentino Ferdjaoui 2022-04-27 09:03:55 +0200 114) def get(self, net_id, segmentation_id):
6ec0bc70a79 (Sahid Orentino Ferdjaoui 2022-04-27 09:03:55 +0200 115) if net_id in self.mapping and segmentation_id in self.mapping[net_id]:
6ec0bc70a79 (Sahid Orentino Ferdjaoui 2022-04-27 09:03:55 +0200 116) return self.mapping[net_id][segmentation_id]
6ec0bc70a79 (Sahid Orentino Ferdjaoui 2022-04-27 09:03:55 +0200 117) raise MappingNotFound(net_id=net_id, seg_id=segmentation_id)

[Lajos Katona (lajos-katona)]

Hi, sorry for not finding this bug earlier, the fix is already merged:
https://review.opendev.org/c/openstack/networking-bagpipe/+/855886

sorry for inconvinence.

[Lajos Katona (lajos-katona)]

17.0.0.0rc1 has the fix could you check it if it solves all the issues?