bagpipe: bagpipe-bgp does not start with EVPN and OVS driver

[Fedor Tarasenko]

In Train bagpipe-bgp does not start having configuration with EVPN and dataplane_driver = ovs http://paste.openstack.org/show/794631/ with trace below http://paste.openstack.org/show/794630/.

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon [-] Error while starting BGP daemon: KeyError: 'os_ken_app'

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon Traceback (most recent call last):

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/bgp_daemon.py", line 98, in daemon_main

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon pecan_api = api.PecanAPI()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/api/api.py", line 58, in __init__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon app = setup_app()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/api/api.py", line 43, in setup_app

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon guess_content_type_from_ext=True

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/pecan/__init__.py", line 86, in make_app

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon app = Pecan(root, **kw)

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/pecan/core.py", line 832, in __init__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon super(Pecan, self).__init__(*args, **kw)

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/pecan/core.py", line 240, in __init__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon root = self.__translate_root__(root)

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/pecan/core.py", line 275, in __translate_root__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon module = __import__(name, fromlist=fromlist)

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/api/controllers.py", line 349, in <module>

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon class RootController(object):

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/api/controllers.py", line 362, in RootController

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon attach_localport = AttachController()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/api/controllers.py", line 67, in __init__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon self.manager = vpn_manager.VPNManager.get_instance()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/vpn/manager.py", line 495, in get_instance

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon cls._create_instance()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 328, in inner

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon return f(*args, **kwargs)

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/vpn/manager.py", line 481, in _create_instance

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon cls._instance = cls()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/common/log_decorator.py", line 39, in wrapper

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon return method(*args, **kwargs)

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/vpn/manager.py", line 71, in __init__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon self.dataplane_drivers = dp_drivers.instantiate_dataplane_drivers()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/vpn/dataplane_drivers.py", line 88, in instantiate_dataplane_drivers

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon drivers[vpn_type] = driver_class()

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/networking_bagpipe/bagpipe_bgp/vpn/evpn/ovs.py", line 248, in __init__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon br_tun.OVSTunnelBridge(self.config.ovs_bridge)

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon File "/var/lib/kolla/venv/lib/python2.7/site-packages/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py", line 62, in __init__

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon self._app = kwargs.pop('os_ken_app')

2020-06-09 08:59:00.292 6 ERROR networking_bagpipe.bagpipe_bgp.bgp_daemon KeyError: 'os_ken_app'

Future investigation shows that https://opendev.org/openstack/networking-bagpipe/src/branch/stable/train/networking_bagpipe/bagpipe_bgp/vpn/evpn/ovs.py#L248 passes fewer options that expected. Same for master branch.

We get errors with stable/train neutron and these packages:
networking-bgpvpn==11.0.1
neutron-lib==1.29.1

[Lajos Katona (lajos-katona)]

I can reproduce it on master as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/735934

[Lajos Katona (lajos-katona)]

@ftarasenko: could you please check this? I have only a tiny devstack to test now, so not sure what I destroyed :-)
I ask somebody to check it with deeper os-ken knowledge.

[Fedor Tarasenko (ftarasenko)]

@lajos-katona: I can confirm that bagpipe-bgp starts with this patch applied. Thank you!

[Fedor Tarasenko (ftarasenko)]

@lajos-katona: futher working with module shows that after creating VPN, module fails with AttributeError: 'OVSDataplaneDriver' object has no attribute 'bridge'
More details in https://pastebin.com/1RNdtH5P

[Lajos Katona (lajos-katona)]

Hi Fedor,
Could you please check https://review.opendev.org/735934 , I think I made it work, at least in my local dummy environment.
Sorry for late answer.

[David Espinel (davidespinel)]

Hi Lajos,

I've implemented your proposed changes in a local deployment and I've encountered a fail when executing an attach_localport: An error ocurred during local port plug to VPN: AttributeError: 'OVSDataplaneDriver' object has no attribute 'tunnel_mgr'

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/networking-bagpipe/+/735934
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.