Bagpipe-bgp agent won't start

[Slawek Kaplonski]

In our ci jobs this agent don't starts, error in logs is like:

-- Logs begin at Tue 2020-02-18 20:31:55 UTC, end at Tue 2020-02-18 21:05:56 UTC. --
Feb 18 21:03:58.253701 ubuntu-bionic-rax-dfw-0014668421 systemd[1]: Started Devstack <email address hidden>.
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: usage: bagpipe-bgp [-h] [--config-dir DIR] [--config-file PATH] [--debug]
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: [--log-config-append PATH] [--log-date-format DATE_FORMAT]
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: [--log-dir LOG_DIR] [--log-file PATH] [--nodebug]
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: [--nouse-journal] [--nouse-json] [--nouse-syslog]
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: [--nowatch-log-file] [--state_path STATE_PATH]
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: [--syslog-log-facility SYSLOG_LOG_FACILITY] [--use-journal]
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: [--use-json] [--use-syslog] [--version] [--watch-log-file]
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: action
Feb 18 21:04:00.665455 ubuntu-bionic-rax-dfw-0014668421 bagpipe-bgp[28653]: bagpipe-bgp: error: the following arguments are required: action
Feb 18 21:04:00.871089 ubuntu-bionic-rax-dfw-0014668421 systemd[1]: <email address hidden>: Main process exited, code=exited, status=2/INVALIDARGUMENT
Feb 18 21:04:00.871114 ubuntu-bionic-rax-dfw-0014668421 systemd[1]: <email address hidden>: Failed with result 'exit-code'.

It causes CI job failure, like e.g.:
https://752297f676458b8a2623-e4b91e6d25d9d026716a0ef16d509bd8.ssl.cf1.rackcdn.com/703601/15/check/neutron-tempest-plugin-bgpvpn-bagpipe/3d99496/controller/logs/screen-neutron-bagpipe-bgp.txt

[Lajos Katona (lajos-katona)]

Hmmmm....
As I see this parameter for bagpipe-bgp comes from here:
https://opendev.org/openstack/networking-bagpipe/src/branch/master/networking_bagpipe/bagpipe_bgp/common/config.py#L74-L80

In an environment where previously devstack plus the devstack plugin was executed there was no problem, but when I just tried to run bagpipe-bgp (from a fullstack tox virtualenv) I got the same error.

[Lajos Katona (lajos-katona)]

Ok in a freshly built devstack I got the same error.
I think this option can be deleted, as it is deprecated anyway

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/708648
Committed: https://git.openstack.org/cgit/openstack/networking-bagpipe/commit/?id=46777858a7a88630289a70b07365787ca9ec4f38
Submitter: Zuul
Branch: master

commit 46777858a7a88630289a70b07365787ca9ec4f38
Author: elajkat <email address hidden>
Date: Wed Feb 19 13:15:46 2020 +0100

    Remove bagpipe-bgp's deprecated action CLI option

    Remove old and deprecated CLI option for bagpipe-bgp, and make
    neutron-tempest-plugin-bgpvpn-bagpipe job voting again.

    Change-Id: I423ed03ebb814154bb17462512732c39eb9f71c0
    Closes-Bug: #1863855