bgpvpn agent extension: fails to update route_targets to []

[Thomas Morin]

The test_bgpvpn_negative_update_to_empty_rt_list test added in [1] fails.
The reason seems to be that the agent bgpvpn extension, when receiving an update_bgpvpn RPC with empty RTs, does not propagate the information to bagpipe-bgp.

agent logs: http://logs.openstack.org/12/518312/3/check/legacy-tempest-dsvm-networking-bgpvpn-bagpipe/e43a8db/logs/screen-q-agt.txt.gz#_Nov_10_16_02_54_710147

[1] https://review.openstack.org/#/c/518312/

[Thomas Morin (tmmorin-orange)]

need to confirm: does this still happen with OVO-based push RPCs ?

[Łukasz Rajewski (rajewluk)]

I've just launched test. Unfortunately still the same result.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/537817
Committed: https://git.openstack.org/cgit/openstack/networking-bagpipe/commit/?id=5d18f11d46aef4ffc456a939fcbf62cbf93d6ba5
Submitter: Zuul
Branch: master

commit 5d18f11d46aef4ffc456a939fcbf62cbf93d6ba5
Author: Thomas Morin <email address hidden>
Date: Thu Jan 25 10:36:41 2018 +0100

    bgpvpn: agent extension, do not skip processing when RTs are empty

    Skipping processing for a BGPVPN when RTs are empty
    results, with the current code, in also failing to
    update the RTs to empty RTs (bug 1732070).

    This change removes this very marginal optimization.

    Change-Id: I615acd193a90eeea2ab3dd9bd3b41912a6304193
    Closes-Bug: 1732070

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-bagpipe 8.0.0.0rc1 release candidate.