bagpipe agent extension pushes malformed RT to bagpipe-bgp

[Thomas Morin]

There is a regression in https://review.openstack.org/454739 :

2017-05-18 06:49:22.804 1850 ERROR networking_bagpipe.bagpipe_bgp.api.controllers [-] attach_localport: An error occurred during local port plug to VPN: Malformed route target: '6'
2017-05-18 06:49:22.804 1850 INFO networking_bagpipe.bagpipe_bgp.api.controllers [-] Traceback (most recent call last):
  File "/opt/stack/new/networking-bagpipe/networking_bagpipe/bagpipe_bgp/api/controllers.py", line 156, in process
    attach_params.get('vni', 0),
  File "/opt/stack/new/networking-bagpipe/networking_bagpipe/bagpipe_bgp/common/log_decorator.py", line 40, in wrapper
    return method(*args, **kwargs)
  File "/opt/stack/new/networking-bagpipe/networking_bagpipe/bagpipe_bgp/vpn/manager.py", line 313, in plug_vif_to_vpn
    import_rts = convert_route_targets(import_rts)
  File "/opt/stack/new/networking-bagpipe/networking_bagpipe/bagpipe_bgp/vpn/manager.py", line 57, in convert_route_targets
    raise Exception("Malformed route target: '%s'" % rt)
Exception: Malformed route target: '6'

Beyond the bug, it seems that we should have had a unit test to guard from that.
I haven't investigated what is missing.

[Thomas Morin (tmmorin-orange)]

http://logs.openstack.org/08/408008/60/experimental/gate-networking-bagpipe-dsvm-fullstack-ubuntu-xenial-nv/e473590/logs/dsvm-fullstack-logs/TestBaGPipeML2ConnectivitySameNetwork.test_connectivity_BaGPipe-native-VXLAN_/bagpipe-bgp--2017-05-18--06-49-09-419551.txt.gz#_2017-05-18_06_49_22_804

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/466004

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466004
Committed: https://git.openstack.org/cgit/openstack/networking-bagpipe/commit/?id=e3c84ae3988bd246a629aad6000febf7f6155f9d
Submitter: Jenkins
Branch: master

commit e3c84ae3988bd246a629aad6000febf7f6155f9d
Author: Yannick Thomas <email address hidden>
Date: Thu May 18 17:09:11 2017 +0200

    Fix pushing malformed RT to bagpipe-bgp

    Convert RTs received from bagpipe L2 to list when compiling port attach

    Signed-off-by: Thomas Morin <email address hidden>
    Submitted on behalf of a third-party: Orange

    Change-Id: I84621fca964ff22599f09451008055954e3e23f4
    Closes-Bug: 1691750

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-bagpipe 7.0.0.0b2 development milestone.