| 2022-01-03 23:47:33 |
Magnus Hyllander |
bug |
|
|
added bug |
| 2022-03-22 09:11:25 |
Lukas Märdian |
netplan: status |
New |
Triaged |
|
| 2022-03-22 09:11:27 |
Lukas Märdian |
netplan: importance |
Undecided |
Medium |
|
| 2022-03-22 12:37:13 |
Nicolas Bock |
bug |
|
|
added subscriber Nicolas Bock |
| 2022-03-23 08:57:12 |
Lukas Märdian |
netplan: status |
Triaged |
In Progress |
|
| 2022-05-13 17:50:58 |
Nicolas Bock |
attachment added |
|
focal.debdiff https://bugs.launchpad.net/netplan/+bug/1956264/+attachment/5589628/+files/focal.debdiff |
|
| 2022-05-16 12:32:30 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu) |
|
| 2022-05-16 12:32:42 |
Lukas Märdian |
netplan: status |
In Progress |
Fix Committed |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
nominated for series |
|
Ubuntu Kinetic |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Kinetic) |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
nominated for series |
|
Ubuntu Focal |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Focal) |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
nominated for series |
|
Ubuntu Jammy |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Jammy) |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
nominated for series |
|
Ubuntu Impish |
|
| 2022-05-16 12:33:01 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Impish) |
|
| 2022-05-16 12:55:33 |
Lukas Märdian |
netplan.io (Ubuntu Kinetic): status |
New |
In Progress |
|
| 2022-05-16 12:55:36 |
Lukas Märdian |
netplan.io (Ubuntu Kinetic): assignee |
|
Lukas Märdian (slyon) |
|
| 2022-05-16 16:24:41 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2022-05-16 16:24:48 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2022-05-23 13:23:48 |
Launchpad Janitor |
netplan.io (Ubuntu Kinetic): status |
In Progress |
Fix Released |
|
| 2022-06-06 22:37:27 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~nicolasbock/netplan/+git/netplan/+merge/424017 |
|
| 2022-06-08 12:12:40 |
Lukas Märdian |
netplan.io (Ubuntu Jammy): status |
New |
In Progress |
|
| 2022-06-08 12:12:50 |
Lukas Märdian |
netplan.io (Ubuntu Jammy): assignee |
|
Nicolas Bock (nicolasbock) |
|
| 2022-06-27 09:56:04 |
Launchpad Janitor |
netplan.io (Ubuntu Focal): status |
New |
Confirmed |
|
| 2022-06-27 09:56:04 |
Launchpad Janitor |
netplan.io (Ubuntu Impish): status |
New |
Confirmed |
|
| 2022-06-29 15:49:53 |
Lukas Märdian |
description |
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to runing & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
|
| 2022-06-30 06:53:44 |
Lukas Märdian |
description |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to runing & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to runing & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
|
| 2022-07-01 23:42:51 |
Steve Langasek |
netplan.io (Ubuntu Jammy): status |
In Progress |
Incomplete |
|
| 2022-07-04 12:05:54 |
Lukas Märdian |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2022-07-04 13:55:44 |
Lukas Märdian |
description |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to runing & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to runing & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
Furthermore, we want to validate the device renaming still works as expected and the new "udev test IFACE" call in "netplan apply" does not have side effects:
$ ip addr
=> observe interface name, e.g. "enp5s0"
$ netplan get # update your netplan config to match this output, adopting the MAC address of enp5s0
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth99"
$ netplan apply
$ ip addr
=> observe that "enp5s0" got renamed to "eth99"
$ netplan set ethernets.id0.set-name=eth42
$ netplan get
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth42"
$ reboot
=> observe the interface's name has now changed to "eth42"
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
|
| 2022-07-04 13:57:29 |
Lukas Märdian |
netplan.io (Ubuntu Jammy): status |
Incomplete |
In Progress |
|
| 2022-07-04 13:57:31 |
Lukas Märdian |
netplan.io (Ubuntu Impish): status |
Confirmed |
In Progress |
|
| 2022-07-04 13:57:33 |
Lukas Märdian |
netplan.io (Ubuntu Focal): status |
Confirmed |
In Progress |
|
| 2022-07-08 17:29:17 |
Steve Langasek |
description |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to runing & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
Furthermore, we want to validate the device renaming still works as expected and the new "udev test IFACE" call in "netplan apply" does not have side effects:
$ ip addr
=> observe interface name, e.g. "enp5s0"
$ netplan get # update your netplan config to match this output, adopting the MAC address of enp5s0
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth99"
$ netplan apply
$ ip addr
=> observe that "enp5s0" got renamed to "eth99"
$ netplan set ethernets.id0.set-name=eth42
$ netplan get
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth42"
$ reboot
=> observe the interface's name has now changed to "eth42"
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
Furthermore, we want to validate the device renaming still works as expected and the new "udev test IFACE" call in "netplan apply" does not have side effects:
$ ip addr
=> observe interface name, e.g. "enp5s0"
$ netplan get # update your netplan config to match this output, adopting the MAC address of enp5s0
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth99"
$ netplan apply
$ ip addr
=> observe that "enp5s0" got renamed to "eth99"
$ netplan set ethernets.id0.set-name=eth42
$ netplan get
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth42"
$ reboot
=> observe the interface's name has now changed to "eth42"
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
|
| 2022-07-08 17:30:09 |
Steve Langasek |
description |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
Furthermore, we want to validate the device renaming still works as expected and the new "udev test IFACE" call in "netplan apply" does not have side effects:
$ ip addr
=> observe interface name, e.g. "enp5s0"
$ netplan get # update your netplan config to match this output, adopting the MAC address of enp5s0
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth99"
$ netplan apply
$ ip addr
=> observe that "enp5s0" got renamed to "eth99"
$ netplan set ethernets.id0.set-name=eth42
$ netplan get
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth42"
$ reboot
=> observe the interface's name has now changed to "eth42"
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
Furthermore, we want to validate the device renaming still works as expected and the new "udev test IFACE" call in "netplan apply" does not have side effects:
$ ip addr
=> observe interface name, e.g. "enp5s0"
$ netplan get # update your netplan config to match this output, adapting the MAC address of enp5s0
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth99"
$ netplan apply
$ ip addr
=> observe that "enp5s0" got renamed to "eth99"
$ netplan set ethernets.id0.set-name=eth42
$ netplan get
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth42"
$ reboot
=> observe the interface's name has now changed to "eth42"
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
|
| 2022-07-08 17:30:37 |
Steve Langasek |
netplan.io (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2022-07-08 17:30:40 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2022-07-08 17:30:42 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2022-07-08 17:30:47 |
Steve Langasek |
tags |
patch |
patch verification-needed verification-needed-jammy |
|
| 2022-07-08 19:19:34 |
Steve Langasek |
netplan.io (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2022-07-08 19:19:41 |
Steve Langasek |
tags |
patch verification-needed verification-needed-jammy |
patch verification-needed verification-needed-focal verification-needed-jammy |
|
| 2022-07-18 09:40:44 |
Lukas Märdian |
description |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
Furthermore, we want to validate the device renaming still works as expected and the new "udev test IFACE" call in "netplan apply" does not have side effects:
$ ip addr
=> observe interface name, e.g. "enp5s0"
$ netplan get # update your netplan config to match this output, adapting the MAC address of enp5s0
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth99"
$ netplan apply
$ ip addr
=> observe that "enp5s0" got renamed to "eth99"
$ netplan set ethernets.id0.set-name=eth42
$ netplan get
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth42"
$ reboot
=> observe the interface's name has now changed to "eth42"
autopkgtest logs:
* Jammy: TBD
* Impish: TBD
* Focal: TBD
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
[Impact]
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests
(that contains new tests to check for this new feature), as described in
https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
to make sure the link offload stanza is working properly:
$ cat /etc/netplan/test.yaml
network:
version: 2
ethernets:
eth1:
receive-checksum-offload: false
transmit-checksum-offload: false
tcp-segmentation-offload: false
tcp6-segmentation-offload: false
generic-segmentation-offload: false
generic-receive-offload: false
large-receive-offload: false
$ netplan apply
$ cat /run/systemd/network/10-netplan-eth1.link | grep Offload
=> Make sure the *Offload settings are correctly set to "=false".
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off":
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
$ reboot
$ ethtool -k eth1
=> Make sure the offloading options have been set to "off" after reboot:
rx-checksumming: off
tx-checksumming: off
tcp-segmentation-offload: off
tx-tcp6-segmentation: off
generic-segmentation-offload: off
generic-receive-offload: off
large-receive-offload: off
Furthermore, we want to validate the device renaming still works as expected and the new "udev test IFACE" call in "netplan apply" does not have side effects:
$ ip addr
=> observe interface name, e.g. "enp5s0"
$ netplan get # update your netplan config to match this output, adapting the MAC address of enp5s0
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth99"
$ netplan apply
$ ip addr
=> observe that "enp5s0" got renamed to "eth99"
$ netplan set ethernets.id0.set-name=eth42
$ netplan get
network:
version: 2
ethernets:
id0:
match:
macaddress: "00:16:3e:1a:23:dd"
dhcp4: true
dhcp6: true
set-name: "eth42"
$ reboot
=> observe the interface's name has now changed to "eth42"
autopkgtest logs:
* Jammy:
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/jammy-amd64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/jammy-arm64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/jammy-armhf.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/jammy-ppc64el.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/jammy-s390x.log
* Impish: EOL
* Focal:
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/focal-amd64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/focal-arm64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/focal-armhf.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/focal-ppc64el.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1956264/focal-s390x.log
[Where problems could occur]
* The settings exist since systemd-232 which means Bionic and up can use
this feature
This upload touches netplan's generator, if anything goes wrong it could impact
the rendering of network configuration and break a system's network connectivity
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted
into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== original description ===
In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set the offload options that are exposed by systemd.link was added. Unfortunately, the implementation only allows setting the offload options to true. Setting the options to false results in nothing being written to the generated .link file, because "false" is treated the same as "unset" by netplan.
See the current implementation https://git.launchpad.net/netplan/tree/src/networkd.c#n260.
netplan needs to handle three different values for the offload options: "true", "false", and "unset"
(I have a specific case in mind, https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to set TSO to off when using the e1000e driver. The current netplan implementation does not support that; as a workaround I created a separate .link file in /etc/systemd/network to disable TSO.) |
|
| 2022-07-18 09:40:56 |
Lukas Märdian |
netplan.io (Ubuntu Impish): status |
In Progress |
Won't Fix |
|
| 2022-07-18 10:02:41 |
Lukas Märdian |
tags |
patch verification-needed verification-needed-focal verification-needed-jammy |
patch verification-done-jammy verification-needed verification-needed-focal |
|
| 2022-07-18 10:23:38 |
Lukas Märdian |
tags |
patch verification-done-jammy verification-needed verification-needed-focal |
patch verification-done-focal verification-done-jammy verification-needed |
|
| 2022-07-26 12:17:23 |
Launchpad Janitor |
netplan.io (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2022-07-26 12:17:28 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2022-08-03 06:40:16 |
Launchpad Janitor |
netplan.io (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-10-13 09:58:05 |
Lukas Märdian |
netplan: status |
Fix Committed |
Fix Released |
|
