| 2021-10-13 10:09:24 |
Michael Vogt |
bug |
|
|
added bug |
| 2021-10-13 10:09:24 |
Michael Vogt |
attachment added |
|
Reproducer https://bugs.launchpad.net/bugs/1946957/+attachment/5532384/+files/netplan-dbus-perculiar2.sh |
|
| 2021-10-13 12:24:10 |
Lukas Märdian |
netplan: status |
New |
Triaged |
|
| 2021-10-13 12:24:33 |
Lukas Märdian |
netplan: importance |
Undecided |
Low |
|
| 2021-10-13 12:25:07 |
Lukas Märdian |
tags |
|
fr-1800 |
|
| 2021-10-21 12:32:56 |
Lukas Märdian |
summary |
Unset of a subtree crashes with dbus (but not cli) |
Unset of a subtree crashes with invalid (non existing) origin-hint |
|
| 2021-11-25 08:52:39 |
Lukas Märdian |
netplan: status |
Triaged |
In Progress |
|
| 2021-11-25 08:52:41 |
Lukas Märdian |
netplan: assignee |
|
Lukas Märdian (slyon) |
|
| 2021-11-29 13:44:30 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu) |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
nominated for series |
|
Ubuntu Impish |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Impish) |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
nominated for series |
|
Ubuntu Jammy |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Jammy) |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
nominated for series |
|
Ubuntu Focal |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Focal) |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
nominated for series |
|
Ubuntu Hirsute |
|
| 2021-11-29 13:44:42 |
Lukas Märdian |
bug task added |
|
netplan.io (Ubuntu Hirsute) |
|
| 2021-11-29 14:06:27 |
Lukas Märdian |
attachment added |
|
repro.sh https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/1946957/+attachment/5544083/+files/repro.sh |
|
| 2021-11-29 15:30:39 |
Lukas Märdian |
description |
Hey, sorry to bother you again with a crash. Help welcome!
I have:
$ $ apt list netplan.io
Listing... Done
netplan.io/now 0.103-0ubuntu5~21.04.2 amd64 [installed,local]
$ zcat /usr/share/doc/netplan.io/changelog.Debian.gz |head -n 6
netplan.io (0.103-0ubuntu5~21.04.2) hirsute; urgency=medium
* Backport patches from impish:
+ Add d/p/0006-netplan-set-make-it-possible-to-unset-a-whole-devtyp.patch:
Fix unset of a devtype subtree, e.g. "netplan set network.ethernets=null"
(LP: #1942930)
With:
$ netplan get
network:
renderer: NetworkManager
version: 2
When I do the following:
$ sudo netplan set network.ethernets=null
that works just fine now.
But when I do (what I think is) the dbus equivalent:
path=$(dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan /io/netplan/Netplan io.netplan.Netplan.Config|grep path|cut -f2 -d'"')
dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan "$path" io.netplan.Netplan.Config.Set string:"network.ethernets=null" string:"90-snapd-conf"
I get:
Error org.freedesktop.DBus.Error.Failed: netplan set failed: Child process exited with code 1
stdout: ''
stderr: 'Traceback (most recent call last):
File "/usr/sbin/netplan", line 23, in <module>
netplan.main()
File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 53, in run
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 106, in command_set
self.write_file(subtree, hint + '.yaml', self.root_dir)
File "/usr/share/netplan/netplan/cli/commands/set.py", line 176, in write_file
raise Exception('Invalid input: {}'.format(set_tree))
Exception: Invalid input: {'network': {'ethernets': None}}
'
Any help or tips appreciated! |
[Impact]
snapd uses netplan's DBus API to create config objects and set/try/apply changed configuration. It uses origin-hints (like 90-snapd-conf.yaml) to separate it's configuration from the user owned YAML configuration.
If this origin-hint file does not exist or is empty, it might lead to crashes inside the 'netplan set' CLI, depending on the called operation and configuration.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests (that contains new tests to check for the cases described in this bug), as described in https://wiki.ubuntu.com/NetplanUpdates we want to run the two reproducer scripts attached to this bug and make sure they do not show any python crashes from the netplan CLI:
$ ./netplan-dbus-perculiar2.sh
$ ./repro.sh
autopkgtest logs:
* Impish:
TBD: amd64, arm64, armhf, ppc64el, s390x
* Hirsute:
TBD: amd64, arm64, armhf, ppc64el, s390x
* Focal:
TBD: amd64, arm64, armhf, ppc64el, s390x
[Where problems could occur]
This upload contains changes to the CLI of netplan, if anything goes wrong it could impact the interactive usage of 'netplan set' by the user.
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== Original Description ===
Hey, sorry to bother you again with a crash. Help welcome!
I have:
$ $ apt list netplan.io
Listing... Done
netplan.io/now 0.103-0ubuntu5~21.04.2 amd64 [installed,local]
$ zcat /usr/share/doc/netplan.io/changelog.Debian.gz |head -n 6
netplan.io (0.103-0ubuntu5~21.04.2) hirsute; urgency=medium
* Backport patches from impish:
+ Add d/p/0006-netplan-set-make-it-possible-to-unset-a-whole-devtyp.patch:
Fix unset of a devtype subtree, e.g. "netplan set network.ethernets=null"
(LP: #1942930)
With:
$ netplan get
network:
renderer: NetworkManager
version: 2
When I do the following:
$ sudo netplan set network.ethernets=null
that works just fine now.
But when I do (what I think is) the dbus equivalent:
path=$(dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan /io/netplan/Netplan io.netplan.Netplan.Config|grep path|cut -f2 -d'"')
dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan "$path" io.netplan.Netplan.Config.Set string:"network.ethernets=null" string:"90-snapd-conf"
I get:
Error org.freedesktop.DBus.Error.Failed: netplan set failed: Child process exited with code 1
stdout: ''
stderr: 'Traceback (most recent call last):
File "/usr/sbin/netplan", line 23, in <module>
netplan.main()
File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 53, in run
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 106, in command_set
self.write_file(subtree, hint + '.yaml', self.root_dir)
File "/usr/share/netplan/netplan/cli/commands/set.py", line 176, in write_file
raise Exception('Invalid input: {}'.format(set_tree))
Exception: Invalid input: {'network': {'ethernets': None}}
'
Any help or tips appreciated! |
|
| 2021-11-30 05:39:57 |
Launchpad Janitor |
netplan.io (Ubuntu Jammy): status |
New |
Fix Released |
|
| 2021-11-30 08:13:59 |
Lukas Märdian |
netplan: status |
In Progress |
Fix Committed |
|
| 2021-11-30 18:54:20 |
Brian Murray |
netplan.io (Ubuntu Impish): status |
New |
Fix Committed |
|
| 2021-11-30 18:54:23 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-11-30 18:54:25 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2021-11-30 18:54:29 |
Brian Murray |
tags |
fr-1800 |
fr-1800 verification-needed verification-needed-impish |
|
| 2021-11-30 18:56:42 |
Brian Murray |
netplan.io (Ubuntu Hirsute): status |
New |
Fix Committed |
|
| 2021-11-30 18:56:50 |
Brian Murray |
tags |
fr-1800 verification-needed verification-needed-impish |
fr-1800 verification-needed verification-needed-hirsute verification-needed-impish |
|
| 2021-11-30 18:58:06 |
Brian Murray |
netplan.io (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2021-11-30 18:58:13 |
Brian Murray |
tags |
fr-1800 verification-needed verification-needed-hirsute verification-needed-impish |
fr-1800 verification-needed verification-needed-focal verification-needed-hirsute verification-needed-impish |
|
| 2021-12-01 11:31:03 |
Lukas Märdian |
description |
[Impact]
snapd uses netplan's DBus API to create config objects and set/try/apply changed configuration. It uses origin-hints (like 90-snapd-conf.yaml) to separate it's configuration from the user owned YAML configuration.
If this origin-hint file does not exist or is empty, it might lead to crashes inside the 'netplan set' CLI, depending on the called operation and configuration.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests (that contains new tests to check for the cases described in this bug), as described in https://wiki.ubuntu.com/NetplanUpdates we want to run the two reproducer scripts attached to this bug and make sure they do not show any python crashes from the netplan CLI:
$ ./netplan-dbus-perculiar2.sh
$ ./repro.sh
autopkgtest logs:
* Impish:
TBD: amd64, arm64, armhf, ppc64el, s390x
* Hirsute:
TBD: amd64, arm64, armhf, ppc64el, s390x
* Focal:
TBD: amd64, arm64, armhf, ppc64el, s390x
[Where problems could occur]
This upload contains changes to the CLI of netplan, if anything goes wrong it could impact the interactive usage of 'netplan set' by the user.
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== Original Description ===
Hey, sorry to bother you again with a crash. Help welcome!
I have:
$ $ apt list netplan.io
Listing... Done
netplan.io/now 0.103-0ubuntu5~21.04.2 amd64 [installed,local]
$ zcat /usr/share/doc/netplan.io/changelog.Debian.gz |head -n 6
netplan.io (0.103-0ubuntu5~21.04.2) hirsute; urgency=medium
* Backport patches from impish:
+ Add d/p/0006-netplan-set-make-it-possible-to-unset-a-whole-devtyp.patch:
Fix unset of a devtype subtree, e.g. "netplan set network.ethernets=null"
(LP: #1942930)
With:
$ netplan get
network:
renderer: NetworkManager
version: 2
When I do the following:
$ sudo netplan set network.ethernets=null
that works just fine now.
But when I do (what I think is) the dbus equivalent:
path=$(dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan /io/netplan/Netplan io.netplan.Netplan.Config|grep path|cut -f2 -d'"')
dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan "$path" io.netplan.Netplan.Config.Set string:"network.ethernets=null" string:"90-snapd-conf"
I get:
Error org.freedesktop.DBus.Error.Failed: netplan set failed: Child process exited with code 1
stdout: ''
stderr: 'Traceback (most recent call last):
File "/usr/sbin/netplan", line 23, in <module>
netplan.main()
File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 53, in run
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 106, in command_set
self.write_file(subtree, hint + '.yaml', self.root_dir)
File "/usr/share/netplan/netplan/cli/commands/set.py", line 176, in write_file
raise Exception('Invalid input: {}'.format(set_tree))
Exception: Invalid input: {'network': {'ethernets': None}}
'
Any help or tips appreciated! |
[Impact]
snapd uses netplan's DBus API to create config objects and set/try/apply changed configuration. It uses origin-hints (like 90-snapd-conf.yaml) to separate it's configuration from the user owned YAML configuration.
If this origin-hint file does not exist or is empty, it might lead to crashes inside the 'netplan set' CLI, depending on the called operation and configuration.
[Test Plan]
In addition to running & passing the full set of unit- and integration-tests (that contains new tests to check for the cases described in this bug), as described in https://wiki.ubuntu.com/NetplanUpdates we want to run the two reproducer scripts attached to this bug and make sure they do not show any python crashes from the netplan CLI:
$ ./netplan-dbus-perculiar2.sh
$ ./repro.sh
autopkgtest logs:
* Impish:
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/impish_amd64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/impish_arm64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/impish_armhf.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/impish_ppc64el.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/impish_s390x.log
* Hirsute:
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/hirsute_amd64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/hirsute_arm64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/hirsute_armhf.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/hirsute_ppc64el.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/hirsute_s390x.log
* Focal:
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/focal_amd64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/focal_arm64.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/focal_armhf.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/focal_ppc64el.log
https://git.launchpad.net/~slyon/+git/files/tree/LP1949893/focal_s390x.log
[Where problems could occur]
This upload contains changes to the CLI of netplan, if anything goes wrong it could impact the interactive usage of 'netplan set' by the user.
[Other Info]
The full set of autopkgtest logs will be attached after the upload is accepted into -proposed and the tests have been run on the official autopkgtest.u.c
infrastructure.
=== Original Description ===
Hey, sorry to bother you again with a crash. Help welcome!
I have:
$ $ apt list netplan.io
Listing... Done
netplan.io/now 0.103-0ubuntu5~21.04.2 amd64 [installed,local]
$ zcat /usr/share/doc/netplan.io/changelog.Debian.gz |head -n 6
netplan.io (0.103-0ubuntu5~21.04.2) hirsute; urgency=medium
* Backport patches from impish:
+ Add d/p/0006-netplan-set-make-it-possible-to-unset-a-whole-devtyp.patch:
Fix unset of a devtype subtree, e.g. "netplan set network.ethernets=null"
(LP: #1942930)
With:
$ netplan get
network:
renderer: NetworkManager
version: 2
When I do the following:
$ sudo netplan set network.ethernets=null
that works just fine now.
But when I do (what I think is) the dbus equivalent:
path=$(dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan /io/netplan/Netplan io.netplan.Netplan.Config|grep path|cut -f2 -d'"')
dbus-send --system --print-reply --type=method_call --dest=io.netplan.Netplan "$path" io.netplan.Netplan.Config.Set string:"network.ethernets=null" string:"90-snapd-conf"
I get:
Error org.freedesktop.DBus.Error.Failed: netplan set failed: Child process exited with code 1
stdout: ''
stderr: 'Traceback (most recent call last):
File "/usr/sbin/netplan", line 23, in <module>
netplan.main()
File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 53, in run
self.run_command()
File "/usr/share/netplan/netplan/cli/utils.py", line 310, in run_command
self.func()
File "/usr/share/netplan/netplan/cli/commands/set.py", line 106, in command_set
self.write_file(subtree, hint + '.yaml', self.root_dir)
File "/usr/share/netplan/netplan/cli/commands/set.py", line 176, in write_file
raise Exception('Invalid input: {}'.format(set_tree))
Exception: Invalid input: {'network': {'ethernets': None}}
'
Any help or tips appreciated! |
|
| 2021-12-01 11:58:52 |
Lukas Märdian |
tags |
fr-1800 verification-needed verification-needed-focal verification-needed-hirsute verification-needed-impish |
fr-1800 verification-done-impish verification-needed verification-needed-focal verification-needed-hirsute |
|
| 2021-12-01 12:00:32 |
Lukas Märdian |
tags |
fr-1800 verification-done-impish verification-needed verification-needed-focal verification-needed-hirsute |
fr-1800 verification-done-hirsute verification-done-impish verification-needed verification-needed-focal |
|
| 2021-12-01 12:53:16 |
Lukas Märdian |
tags |
fr-1800 verification-done-hirsute verification-done-impish verification-needed verification-needed-focal |
fr-1800 verification-done-focal verification-done-hirsute verification-done-impish verification-needed |
|
| 2021-12-06 20:04:14 |
Brian Murray |
tags |
fr-1800 verification-done-focal verification-done-hirsute verification-done-impish verification-needed |
fr-1800 verification-done-hirsute verification-done-impish verification-needed verification-needed-focal |
|
| 2021-12-07 11:57:52 |
Lukas Märdian |
tags |
fr-1800 verification-done-hirsute verification-done-impish verification-needed verification-needed-focal |
fr-1800 verification-done-focal verification-done-hirsute verification-done-impish verification-needed |
|
| 2021-12-07 22:14:50 |
Launchpad Janitor |
netplan.io (Ubuntu Impish): status |
Fix Committed |
Fix Released |
|
| 2021-12-07 22:14:54 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-12-07 22:16:38 |
Launchpad Janitor |
netplan.io (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
| 2021-12-07 22:18:40 |
Launchpad Janitor |
netplan.io (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-01-11 16:01:11 |
Lukas Märdian |
netplan: status |
Fix Committed |
Fix Released |
|
