Activity log for bug #1802322

Date Who What changed Old value New value Message
2018-11-08 15:02:48 Dmitrii Shcherbakov bug added bug
2018-11-08 15:03:33 Dmitrii Shcherbakov bug added subscriber Canonical Field Critical
2018-11-08 15:24:43 Ryan Harper bug added subscriber Ryan Harper
2018-11-08 15:36:59 Octavian Ciuhandu bug added subscriber Mihai Gheorghe
2018-11-08 15:39:55 Mihai Gheorghe attachment added network.tar.gz https://bugs.launchpad.net/netplan/+bug/1802322/+attachment/5210385/+files/network.tar.gz
2018-11-08 15:40:43 Mihai Gheorghe attachment added syslog https://bugs.launchpad.net/netplan/+bug/1802322/+attachment/5210386/+files/syslog
2018-11-08 15:51:40 Alex Tomlins bug added subscriber Alex Tomlins
2018-11-08 16:15:52 Mathieu Trudel-Lapierre bug task added netplan.io (Ubuntu)
2018-11-08 16:16:08 Mathieu Trudel-Lapierre netplan.io (Ubuntu): status New Triaged
2018-11-08 16:16:10 Mathieu Trudel-Lapierre netplan.io (Ubuntu): importance Undecided High
2018-11-08 16:16:12 Mathieu Trudel-Lapierre netplan.io (Ubuntu): assignee Mathieu Trudel-Lapierre (cyphermox)
2018-11-08 16:16:13 Mathieu Trudel-Lapierre netplan: assignee Mathieu Trudel-Lapierre (cyphermox)
2018-11-08 16:16:15 Mathieu Trudel-Lapierre netplan: importance Undecided High
2018-11-08 16:16:17 Mathieu Trudel-Lapierre netplan: status New Triaged
2018-11-08 16:16:28 Mathieu Trudel-Lapierre tags cpe-onsite cpe-onsite regression-release
2018-11-08 16:17:10 Mathieu Trudel-Lapierre tags cpe-onsite regression-release cpe-onsite regression-update
2018-11-10 13:34:49 Francis Ginther tags cpe-onsite regression-update cpe-onsite id-5be4a491c40aa00e98bc940a regression-update
2018-11-22 04:01:32 Launchpad Janitor netplan.io (Ubuntu): status Triaged Fix Released
2018-11-26 18:17:05 Mathieu Trudel-Lapierre description After an update for https://bugs.launchpad.net/netplan/+bug/1770082 was released for bionic and our systems started getting the new packages, *clean* MAAS + Juju + Bionic + LXD container deployments started to fail on bridge activation. juju model-config logging-config='<root>=WARNING;unit=DEBUG;juju.network.netplan=TRACE' 2018-11-08 13:44:10 DEBUG juju.network.netplan activate.go:99 Netplan activation result "Traceback (most recent call last): File \"/usr/sbin/netplan\", line 23, in <module> netplan.main() File \"/usr/share/netplan/netplan/cli/core.py\", line 50, in main self.run_command() File \"/usr/share/netplan/netplan/cli/utils.py\", line 130, in run_command self.func() File \"/usr/share/netplan/netplan/cli/commands/apply.py\", line 43, in run self.run_command() File \"/usr/share/netplan/netplan/cli/utils.py\", line 130, in run_command self.func() File \"/usr/share/netplan/netplan/cli/commands/apply.py\", line 102, in command_apply stderr=subprocess.DEVNULL) File \"/usr/lib/python3.6/subprocess.py\", line 291, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['ip', 'link', 'set', 'dev', 'enp5s0f0', 'name', 'enp4s0f0']' returned non-zero exit status 2. " "" 1 From the Juju machine agent code: command := fmt.Sprintf("%snetplan generate && netplan apply && sleep 10", params.RunPrefix) // ... logger.Debugf("Netplan activation result %q %q %d", result.Stderr, result.Stdout, result.Code) The rename operation in question does not seem to be justified by anything that juju would want to do. Inspecting closer it can be seen that 00:0a:f7:72:a7:28 is a mac address of enp4s0f0 which also happens to be a MAC address of the bond and gets applied to all members of a bond (enp5s0f0 is of specific interest) after the first run of netplan after the deployment. It looks like a subsequent `netplan generate && netplan apply` invocation by Juju causes netplan to try to apply "enp4s0f0" name to "enp5s0f0" interface because it has "00:0a:f7:72:a7:28" for a mac address as a result of becoming a bond member. netplan generated by cloud-init: http://paste.ubuntu.com/p/QfR4f5yMYP/ bond0: interfaces: - enp4s0f0 - enp5s0f0 enp4s0f0: match: macaddress: 00:0a:f7:72:a7:28 mtu: 9000 set-name: enp4s0f0 enp5s0f0: match: macaddress: 00:0e:1e:ac:67:00 mtu: 9000 set-name: enp5s0f0 curtin config: http://paste.ubuntu.com/p/NkvZKqZYjr/ # ip addr show enp5s0f0 8: enp5s0f0: <NO-CARRIER,BROADCAST,MULTICAST,SLAVE,UP> mtu 9000 qdisc mq master bond0 state DOWN group default qlen 1000 link/ether 00:0a:f7:72:a7:28 brd ff:ff:ff:ff:ff:ff # ip addr show enp4s0f0 6: enp4s0f0: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP> mtu 9000 qdisc mq master bond0 state UP group default qlen 1000 link/ether 00:0a:f7:72:a7:28 brd ff:ff:ff:ff:ff:ff This is currently blocking all of our bionic deployments as all of them have bonds. [Impact] Usage of juju to deploy systems with bridge configurations is severely broken if using layer3+4 bonding, as renaming might be attempted and break the application of config. [Test case] 1) Deploy a system using MaaS and Juju, with a network configuration such as:         bond0:             interfaces:             - enp4s0f0             - enp5s0f0 macaddress: 00:0a:f7:72:a7:28 mtu: 9000 parameters: down-delay: 0 lacp-rate: fast mii-monitor-interval: 100 mode: 802.3ad transmit-hash-policy: layer3+4 up-delay: 0         enp4s0f0:             match:                 macaddress: 00:0a:f7:72:a7:28             mtu: 9000             set-name: enp4s0f0         enp5s0f0:             match:                 macaddress: 00:0e:1e:ac:67:00             mtu: 9000             set-name: enp5s0f0 [Regression potential] This fix is to correct an existing regression. Changes in the rename code might otherwise impact the effect of attempting to rename interfaces when (and only when) 'netplan apply' is being run, which only ever happens as directed by the user (either directly at the command-line or via scripting such as via juju). Changes are limited to the behavior of 'netplan apply' in the interface renaming step; and the fix has been to ignore non-physical devices (which are not renamed anyway, but created) and physical devices members of a bond/bridge. --- After an update for https://bugs.launchpad.net/netplan/+bug/1770082 was released for bionic and our systems started getting the new packages, *clean* MAAS + Juju + Bionic + LXD container deployments started to fail on bridge activation. juju model-config logging-config='<root>=WARNING;unit=DEBUG;juju.network.netplan=TRACE' 2018-11-08 13:44:10 DEBUG juju.network.netplan activate.go:99 Netplan activation result "Traceback (most recent call last):   File \"/usr/sbin/netplan\", line 23, in <module>     netplan.main()   File \"/usr/share/netplan/netplan/cli/core.py\", line 50, in main     self.run_command()   File \"/usr/share/netplan/netplan/cli/utils.py\", line 130, in run_command     self.func()   File \"/usr/share/netplan/netplan/cli/commands/apply.py\", line 43, in run     self.run_command()   File \"/usr/share/netplan/netplan/cli/utils.py\", line 130, in run_command     self.func()   File \"/usr/share/netplan/netplan/cli/commands/apply.py\", line 102, in command_apply     stderr=subprocess.DEVNULL)   File \"/usr/lib/python3.6/subprocess.py\", line 291, in check_call     raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['ip', 'link', 'set', 'dev', 'enp5s0f0', 'name', 'enp4s0f0']' returned non-zero exit status 2. " "" 1 From the Juju machine agent code: command := fmt.Sprintf("%snetplan generate && netplan apply && sleep 10", params.RunPrefix) // ... logger.Debugf("Netplan activation result %q %q %d", result.Stderr, result.Stdout, result.Code) The rename operation in question does not seem to be justified by anything that juju would want to do. Inspecting closer it can be seen that 00:0a:f7:72:a7:28 is a mac address of enp4s0f0 which also happens to be a MAC address of the bond and gets applied to all members of a bond (enp5s0f0 is of specific interest) after the first run of netplan after the deployment. It looks like a subsequent `netplan generate && netplan apply` invocation by Juju causes netplan to try to apply "enp4s0f0" name to "enp5s0f0" interface because it has "00:0a:f7:72:a7:28" for a mac address as a result of becoming a bond member. netplan generated by cloud-init: http://paste.ubuntu.com/p/QfR4f5yMYP/         bond0:             interfaces:             - enp4s0f0             - enp5s0f0         enp4s0f0:             match:                 macaddress: 00:0a:f7:72:a7:28             mtu: 9000             set-name: enp4s0f0         enp5s0f0:             match:                 macaddress: 00:0e:1e:ac:67:00             mtu: 9000             set-name: enp5s0f0 curtin config: http://paste.ubuntu.com/p/NkvZKqZYjr/ # ip addr show enp5s0f0 8: enp5s0f0: <NO-CARRIER,BROADCAST,MULTICAST,SLAVE,UP> mtu 9000 qdisc mq master bond0 state DOWN group default qlen 1000     link/ether 00:0a:f7:72:a7:28 brd ff:ff:ff:ff:ff:ff # ip addr show enp4s0f0 6: enp4s0f0: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP> mtu 9000 qdisc mq master bond0 state UP group default qlen 1000     link/ether 00:0a:f7:72:a7:28 brd ff:ff:ff:ff:ff:ff This is currently blocking all of our bionic deployments as all of them have bonds.
2018-11-26 19:21:30 Adam Conrad netplan.io (Ubuntu Cosmic): status New Fix Committed
2018-11-26 19:21:31 Adam Conrad bug added subscriber Ubuntu Stable Release Updates Team
2018-11-26 19:21:34 Adam Conrad bug added subscriber SRU Verification
2018-11-26 19:21:39 Adam Conrad tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-cosmic
2018-11-26 19:26:04 Adam Conrad netplan.io (Ubuntu Bionic): status New Fix Committed
2018-11-26 19:26:10 Adam Conrad tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-bionic verification-needed-cosmic
2018-12-04 15:39:02 Mathieu Trudel-Lapierre tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-bionic verification-needed-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-done-cosmic
2018-12-04 16:49:43 Dmitrii Shcherbakov removed subscriber Canonical Field Critical
2018-12-04 20:22:33 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2018-12-04 20:22:29 Launchpad Janitor netplan.io (Ubuntu Cosmic): status Fix Committed Fix Released
2018-12-05 18:47:48 Launchpad Janitor netplan.io (Ubuntu Bionic): status Fix Committed Fix Released
2019-03-11 20:27:59 Mathieu Trudel-Lapierre netplan: status Triaged Fix Released
2019-03-22 09:12:01 Timo Aaltonen netplan.io (Ubuntu Cosmic): status Fix Released Fix Committed
2019-03-22 09:12:03 Timo Aaltonen bug added subscriber Ubuntu Stable Release Updates Team
2019-03-22 09:12:10 Timo Aaltonen tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-done-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-needed verification-needed-cosmic
2019-03-22 09:19:06 Timo Aaltonen netplan.io (Ubuntu Bionic): status Fix Released Fix Committed
2019-03-22 09:19:10 Timo Aaltonen tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-needed verification-needed-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-bionic verification-needed-cosmic
2019-03-22 09:22:05 Timo Aaltonen netplan.io (Ubuntu Bionic): status Fix Committed Fix Released
2019-03-22 09:22:14 Timo Aaltonen netplan.io (Ubuntu Cosmic): status Fix Committed Fix Released
2019-03-22 09:22:41 Timo Aaltonen tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-bionic verification-needed-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done verification-done-bionic verification-done-cosmic
2019-03-29 01:15:33 Steve Langasek netplan.io (Ubuntu Cosmic): status Fix Released Fix Committed
2019-03-29 01:15:40 Steve Langasek tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done verification-done-bionic verification-done-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-needed verification-needed-cosmic
2019-03-29 01:22:14 Steve Langasek netplan.io (Ubuntu Bionic): status Fix Released Fix Committed
2019-03-29 01:22:20 Steve Langasek tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-needed verification-needed-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-bionic verification-needed-cosmic
2019-04-02 15:32:31 Mathieu Trudel-Lapierre tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-needed verification-needed-bionic verification-needed-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-done-cosmic
2019-04-10 21:20:57 Steve Langasek tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-done-cosmic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-cosmic verification-needed verification-needed-bionic
2019-04-11 18:56:29 Mathieu Trudel-Lapierre tags cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-cosmic verification-needed verification-needed-bionic cpe-onsite id-5be4a491c40aa00e98bc940a regression-update verification-done-bionic verification-done-cosmic
2019-04-15 22:32:43 Launchpad Janitor netplan.io (Ubuntu Cosmic): status Fix Committed Fix Released
2019-04-18 23:39:59 Steve Langasek netplan.io (Ubuntu Cosmic): status Fix Released Fix Committed