netplan apply always exits with status 0

[Witold Krecicki]

netplan apply returns with status 0 even if it failed:

$ netplan apply && echo "Success!"
Cannot replug eno1: [Errno 13] Permission denied: '/sys/bus/pci/drivers/e1000e/unbind'
Success!

I believe that's an undesider behaviour.

[Mathieu Trudel-Lapierre (cyphermox)]

Was there any config provided when you did this? Seems like there are also all the service stop/start commands that should get attempted and fail (and these do throw exceptions). I don't think failing to unbind because of a missing file, for example, is critical enough to warrant to completing the apply, but failing to restart NM or systemd would definitely be.

I think this will at the very least need more information about the configuration that was used for netplan.

[Daniel Axtens (daxtens)]

I'm marking this as confirmed as the behaviour has come up in LP: #1735318.

[Daniel Axtens (daxtens)]

It looks like at least some of this changed between Bionic and Cosmic - here with a netplan 0.39:

root@netplan:~# netplan apply
Error in network definition /etc/netplan/50-cloud-init.yaml line 5 column 0: unknown key xxnetwork
root@netplan:~# echo $?
78

[Lee Trager (ltrager)]

I'm seeing the same thing in LP:1835275 except netplan doesn't output any errors.

[Mathieu Trudel-Lapierre (cyphermox)]

No; by now this is working exactly as expected; netplan should return 0 as long as there is no actual syntax error in the netplan config; for now everything else is left to the backends.