Lookupuser response missing "User Privilege" data

[Josh Stompro]

Hello, I'm noticing that if my LookupUser message includes a request for "User Privilege" additional information, it isn't included.

    <UserElementType>User Privilege</UserElementType>

It appears as if the code is trying to gather a response and send it.

https://gitlab.com/LARL/ncipserver/-/blob/master/lib/NCIP/ILS/Evergreen.pm#L1349

The "Name Information" and "User Address Information" seem to work fine in my testing.

    <UserElementType>Name Information</UserElementType>
    <UserElementType>User Address Information</UserElementType>

I'm not sure if the "Block or Trap" is working right now.

I'm curious if this works ok for others?
Josh

[Josh Stompro (u-launchpad-stompro-org)]

Block Or Trap does seem to work fine.

I can see a log entry for the pgt search, so it looks like it is getting that far.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

It seems like the UserPrivilege data is getting gathered just fine... I added some logging.

[2024-01-12 15:28:34] /usr/sbin/apache2 [INFO:17289:Evergreen.pm:1414:17050949091728918] Checking UserPrivilege - privilege is: $VAR1 = \bless( {'ValidToDate' => '2025-12-07T06:00:00','AgencyUserPrivilegeType' => 'LARL Staff','ValidFromDate' => '2004-08-27T05:00:00','AgencyId' => 'MOORHEAD','UserPrivilegeStatus' => bless( {'UserPrivilegeStatusType' => 'Active'}, 'NCIP::User::PrivilegeStatus' )}, 'NCIP::User::Privilege' );

So maybe when the XML is created there is an issue?

[Josh Stompro (u-launchpad-stompro-org)]

Found it, the templates/includes/UserOptionalFields.inc had an out of place End tag, all the UserPriviledge data was lumped in with the UserLanguage check. And since User Language isn't implemented it would never display.

https://gitlab.com/LARL/ncipserver/-/blob/master/templates/includes/UserOptionalFields.inc

I'll get a working branch going.
Josh

[Josh Stompro (u-launchpad-stompro-org)]

Working branch at user/stompro/lp2049230_UserOptionalFields_fix_UserPrivilege

https://git.evergreen-ils.org/?p=working/NCIPServer.git;a=shortlog;h=refs/heads/user/stompro/lp2049230_UserOptionalFields_fix_UserPrivilege

[Jason Stephenson (jstephenson)]

Thanks, Josh!

I verified the bug, applied the patch, and verified that the fix works.

I pushed it to NCIPServer main.