logengine crash on log messages with years in their timestamps

[Morten Brekkevold]

The logengine crashes when attempting to parse a log message containing a year in its origin timestamp. This results in a truncated log file and lots of discarded log messages.

The traceback, provided by Ronny Raudstein, is as follows:

Traceback (most recent call last):
File "logengine.py", line 298, in ?
message = createMessage(line)
File "logengine.py", line 123, in createMessage
oritime = DateTime.DateTime(year,month,day,hour,min)
TypeError: an integer is required

An example log message that will crash it:

Mar 20 10:27:26 sw_1 607977: Mar 20 2009 10:20:06: %SEC-6-IPACCESSLOGP: list fraVLAN800 denied tcp x.x.x.x(1380) -> y.y.y.y(80), 2 packets

Reference this nav-users thread: https://postlister.uninett.no/sympa/arc/nav-users/2009-03/msg00011.html (initially, it was thought that the message counter was the problem, but it turned out to be the year).

[Morten Brekkevold (mbrekkevold)]

Working on a series of patches for this.

1. The code sucks, so I'm slightly refactoring it to make it more legible.
2. Add error handling for situations like this.
3. Support years in timestamps

[Morten Brekkevold (mbrekkevold)]

Fixes committed and pushed to series/3.5.x:
http://metanav.uninett.no/hg/series/3.5.x/rev/aeea449f36ea
http://metanav.uninett.no/hg/series/3.5.x/rev/f2d8775d04bb
http://metanav.uninett.no/hg/series/3.5.x/rev/fcc4e981851f